[MacViews-Browser] Bookmarks Bar Folder Menu is placed a few px too high |
|||||
Issue descriptionChrome Version: Canary 67.0.3396.0 OS: macOS 10.12.6 What steps will reproduce the problem? (1) Enable MacViews-Browser (2) Click on a Bookmarks Bar Folder, so that the Menu appears (3) Take a look at the position of the Menu What is the expected result? The Menu could be placed at the same position like on the other buttons to be consistent. What happens instead? The Menu is placed some px higher than compared with the position on other buttons. Screenshots are attached. Please feel free to close this issue, if this is intentional. Thanks Mehmet
,
Apr 16 2018
,
Apr 25 2018
,
Apr 26 2018
there is a discrepancy between Cocoa and views impl on the position of bookmark dropdown menu. I am in contact with UI designer to see whether we should consolidate them. Still in progress.
,
Apr 26 2018
Thanks for the update :-)
,
Apr 27 2018
Thanks for filing! The current design is not intentional - the expected design is desired. Thanks again!
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e4774fc79110aa35c59cb9ba3de3863b8e40d2a8 commit e4774fc79110aa35c59cb9ba3de3863b8e40d2a8 Author: Wei Li <weili@chromium.org> Date: Tue May 01 01:16:16 2018 Position bookmark menu same as other menus Bookmark menu was positioned a couple pixels higher to flush button border for historical reason. Now bookmark button doesn't have border any more, we should make the menu position consistent as the other menus. Screenshots of before and after are in the following links: https://screenshot.googleplex.com/Tib2cdtRG7P.png (before) https://screenshot.googleplex.com/xYOxCeXfbes.png (after) BUG= 832672 TEST=Pls test bookmark menu drag and drop thoroughly, especially on Windows, to make sure nothing is broken. Change-Id: I977719e7ba6cbf7204c33ee5f238b9428ff236bf Reviewed-on: https://chromium-review.googlesource.com/1033349 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#554952} [modify] https://crrev.com/e4774fc79110aa35c59cb9ba3de3863b8e40d2a8/chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc [modify] https://crrev.com/e4774fc79110aa35c59cb9ba3de3863b8e40d2a8/ui/views/controls/menu/menu_controller.cc
,
May 1 2018
Thanks, mehmet@, for checking
,
May 2 2018
Verified the fix on Mac 10.13.1 using Chrome version #68.0.3417.0 as per the comment #0. Attaching screen shot for reference. Observed that Menu is placed at the right position. Hence, the fix is working as expected. Adding the verified labels. Note: Able to reproduce the issue on chrome version with out fix. Thanks...!! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by meh...@chromium.org
, Apr 13 2018