New issue
Advanced search Search tips

Issue 832661 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-05-23
OS: iOS
Pri: 2
Type: Task
Q2

Blocked on:
issue 804760

Blocking:
issue 818732



Sign in to add a comment

Adaptive Toolbar: Re-enable tip promo

Project Member Reported by gambard@chromium.org, Apr 13 2018

Issue description

The promo was disabled as the feature is not yet implemented in the UI refresh.
Re enable it once it is done.
 
Labels: -Q1 Q2
Blocking: 818732
Project Member

Comment 3 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bac8973545808351959ca486c4319602541709d

commit 8bac8973545808351959ca486c4319602541709d
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri May 11 12:23:58 2018

Re-enable promo EG tests for UI Refresh

This CL re-enable the EG tests for the promo when UI Refresh flag is
enabled.

Bug:  832661 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4102d6c61cd774387817d5dc30d4794d02f42ac2
Reviewed-on: https://chromium-review.googlesource.com/1052112
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557848}
[modify] https://crrev.com/8bac8973545808351959ca486c4319602541709d/ios/chrome/browser/feature_engagement/BUILD.gn
[modify] https://crrev.com/8bac8973545808351959ca486c4319602541709d/ios/chrome/browser/feature_engagement/feature_engagement_egtest.mm

NextAction: 2018-05-23
Status: Fixed (was: Assigned)
The NextAction date has arrived: 2018-05-23

Sign in to add a comment