Catapult EQT metric should use scheduler top level task. |
||
Issue descriptionCurrently it uses message loop top level task, but input events are blocked on scheduler tasks, not message loop tasks.
,
Apr 13 2018
sgtm :)
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/055c0339565a94426019ce1da26b14e6c2320c28 commit 055c0339565a94426019ce1da26b14e6c2320c28 Author: Ulan Degenbaev <ulan@chromium.org> Date: Tue Apr 17 15:27:46 2018 Use top-level scheduler tasks in EQT metric. The EQT metric currently uses message loop tasks, but input events are blocked on scheduler tasks. This patch extracts the top level scheduler tasks finding function from the TTI metric and uses it in both EQT and TTI metrics. The finding function now does only one pass over the slices and preserves the order of slices in the result. Bug: chromium:832651 Change-Id: I0127563b1ba9cf318b5c6b066b9a73235d1b389a Reviewed-on: https://chromium-review.googlesource.com/1012106 Reviewed-by: Timothy Dresser <tdresser@chromium.org> Reviewed-by: Ethan Kuefner <eakuefner@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> [modify] https://crrev.com/055c0339565a94426019ce1da26b14e6c2320c28/tracing/tracing/extras/chrome/event_finder_utils.html [modify] https://crrev.com/055c0339565a94426019ce1da26b14e6c2320c28/tracing/tracing/importer/find_load_expectations.html [modify] https://crrev.com/055c0339565a94426019ce1da26b14e6c2320c28/tracing/tracing/extras/chrome/event_finder_utils_test.html [modify] https://crrev.com/055c0339565a94426019ce1da26b14e6c2320c28/tracing/tracing/metrics/system_health/expected_queueing_time_metric.html
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d9e97dc832fdbcf9723c1b3c4dceaf9bcc74caf commit 6d9e97dc832fdbcf9723c1b3c4dceaf9bcc74caf Author: catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue Apr 17 19:14:16 2018 Roll src/third_party/catapult/ 69a36a622..055c03395 (1 commit) https://chromium.googlesource.com/catapult.git/+log/69a36a622381..055c0339565a $ git log 69a36a622..055c03395 --date=short --no-merges --format='%ad %ae %s' 2018-04-13 ulan Use top-level scheduler tasks in EQT metric. Created with: roll-dep src/third_party/catapult BUG= chromium:832651 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I47174a35e3658f1e5d17302f9cb3be9292bba63e Reviewed-on: https://chromium-review.googlesource.com/1014705 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551424} [modify] https://crrev.com/6d9e97dc832fdbcf9723c1b3c4dceaf9bcc74caf/DEPS
,
Apr 23 2018
,
Oct 15
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/c2f72b8a9299ddd88999b154b797bce10201d853 commit c2f72b8a9299ddd88999b154b797bce10201d853 Author: Deepanjan Roy <dproy@chromium.org> Date: Mon Oct 15 19:30:00 2018 Fix top level scheduler task title The top level scheduler task was renamed, so changing all refs to that name. The old TaskQueueManager::DoWork event now has category 'sequence_manager', and has different semantics. To maintain backwards compatibility, we still consider TaskQueueManager::DoWork events with 'toplevel' category to be scheduler top level tasks. This also changes total EQT to use scheduler task. This was a case that was missed while fixing crbug.com/832651 . Bug: chromium:871204 , chromium:832651 Change-Id: I430ae8553e64ff30a94ab109a045e58849a99390 Reviewed-on: https://chromium-review.googlesource.com/c/1278111 Reviewed-by: oysteine <oysteine@chromium.org> Reviewed-by: Ben Hayden <benjhayden@chromium.org> Commit-Queue: Deepanjan Roy <dproy@chromium.org> [modify] https://crrev.com/c2f72b8a9299ddd88999b154b797bce10201d853/tracing/tracing/extras/chrome/event_finder_utils.html [modify] https://crrev.com/c2f72b8a9299ddd88999b154b797bce10201d853/tracing/tracing/importer/user_model_builder_test.html [modify] https://crrev.com/c2f72b8a9299ddd88999b154b797bce10201d853/tracing/tracing/metrics/v8/runtime_stats_metric_test.html [modify] https://crrev.com/c2f72b8a9299ddd88999b154b797bce10201d853/tracing/tracing/metrics/system_health/power_metric_test.html [modify] https://crrev.com/c2f72b8a9299ddd88999b154b797bce10201d853/trace_processor/experimental/mappers/long_running_tasks_mapper.html [modify] https://crrev.com/c2f72b8a9299ddd88999b154b797bce10201d853/tracing/tracing/metrics/system_health/expected_queueing_time_metric_test.html [modify] https://crrev.com/c2f72b8a9299ddd88999b154b797bce10201d853/tracing/tracing/metrics/system_health/loading_metric_test.html [modify] https://crrev.com/c2f72b8a9299ddd88999b154b797bce10201d853/tracing/tracing/extras/chrome/estimated_input_latency_test.html [modify] https://crrev.com/c2f72b8a9299ddd88999b154b797bce10201d853/tracing/tracing/extras/chrome/event_finder_utils_test.html [modify] https://crrev.com/c2f72b8a9299ddd88999b154b797bce10201d853/tracing/tracing/metrics/system_health/expected_queueing_time_metric.html
,
Oct 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e4b18306674979a2fffe59ae60e51320aa20ad6e commit e4b18306674979a2fffe59ae60e51320aa20ad6e Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Oct 16 05:59:06 2018 Roll src/third_party/catapult 2be20fdd2d70..88afab4ff0f0 (4 commits) https://chromium.googlesource.com/catapult.git/+log/2be20fdd2d70..88afab4ff0f0 git log 2be20fdd2d70..88afab4ff0f0 --date=short --no-merges --format='%ad %ae %s' 2018-10-15 benjhayden@chromium.org Add ReportCacheRequest for v2spa service worker 2018-10-15 pasko@chromium.org event_finder_util: skip renderer events when no mainThread 2018-10-15 chiniforooshan@chromium.org Telemetry: fix a bug in percentage_smooth 2018-10-15 dproy@chromium.org Fix top level scheduler task title Created with: gclient setdep -r src/third_party/catapult@88afab4ff0f0 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:891797, chromium:895096 , chromium:871204 , chromium:832651 TBR=sullivan@chromium.org Change-Id: I2a5a1b05066c3c5f10bbec768c0bd430c80e5fa4 Reviewed-on: https://chromium-review.googlesource.com/c/1282342 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599878} [modify] https://crrev.com/e4b18306674979a2fffe59ae60e51320aa20ad6e/DEPS |
||
►
Sign in to add a comment |
||
Comment 1 by u...@chromium.org
, Apr 13 2018Status: Assigned (was: Available)