Ui work should be proportional to what's visible. |
||||||
Issue descriptionWe currently do work over all elements and it would be better (especially for WebVR) if we skipped work for elements that weren't visible. This had been done, but was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1011353. We should re-enable this if there are no remaining issues.
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16a8e9e490ffb596d8050b3f635bba5ee00aadf2 commit 16a8e9e490ffb596d8050b3f635bba5ee00aadf2 Author: Ian Vollick <vollick@chromium.org> Date: Fri Apr 13 23:08:17 2018 [vr] Disable optimized treewalks Also removes some code leftover from debugging. Bug: 832650 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I68271d0e97973b5dde393d6d1da3eaec32bd6259 Reviewed-on: https://chromium-review.googlesource.com/1012760 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#550780} [modify] https://crrev.com/16a8e9e490ffb596d8050b3f635bba5ee00aadf2/chrome/browser/vr/elements/ui_element.cc
,
Apr 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18a5665becb7cce9c10461631036bc847d76db45 commit 18a5665becb7cce9c10461631036bc847d76db45 Author: Ian Vollick <vollick@chromium.org> Date: Mon Apr 16 18:05:31 2018 [vr] Ensure unticked transitions complete If a transition was enqueued but not serviced and, much later, another transition is enqueued, it should transition from the final value of the earlier transition. Bug: 832650 , 830592 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I751c5d26101bfa197818ccd2f72188513ed044f2 Reviewed-on: https://chromium-review.googlesource.com/1014008 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#551035} [modify] https://crrev.com/18a5665becb7cce9c10461631036bc847d76db45/chrome/browser/vr/animation.cc [modify] https://crrev.com/18a5665becb7cce9c10461631036bc847d76db45/chrome/browser/vr/animation_unittest.cc [modify] https://crrev.com/18a5665becb7cce9c10461631036bc847d76db45/chrome/browser/vr/elements/ui_element.cc [modify] https://crrev.com/18a5665becb7cce9c10461631036bc847d76db45/chrome/browser/vr/ui_scene_creator.cc
,
Apr 16 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44cc4deeb0e0fbbfaca0a97d611a6bb50dcecef2 commit 44cc4deeb0e0fbbfaca0a97d611a6bb50dcecef2 Author: Ian Vollick <vollick@chromium.org> Date: Fri Apr 13 15:38:03 2018 [vr] Re-enable the pruned tree walks The issues now seem to be resolved. Bug: 832650 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Id43bc440805fb4ed74d430ed7384eed78bce289f Reviewed-on: https://chromium-review.googlesource.com/1011678 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#550627} [modify] https://crrev.com/44cc4deeb0e0fbbfaca0a97d611a6bb50dcecef2/chrome/browser/vr/elements/ui_element.cc
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16a8e9e490ffb596d8050b3f635bba5ee00aadf2 commit 16a8e9e490ffb596d8050b3f635bba5ee00aadf2 Author: Ian Vollick <vollick@chromium.org> Date: Fri Apr 13 23:08:17 2018 [vr] Disable optimized treewalks Also removes some code leftover from debugging. Bug: 832650 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I68271d0e97973b5dde393d6d1da3eaec32bd6259 Reviewed-on: https://chromium-review.googlesource.com/1012760 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#550780} [modify] https://crrev.com/16a8e9e490ffb596d8050b3f635bba5ee00aadf2/chrome/browser/vr/elements/ui_element.cc
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18a5665becb7cce9c10461631036bc847d76db45 commit 18a5665becb7cce9c10461631036bc847d76db45 Author: Ian Vollick <vollick@chromium.org> Date: Mon Apr 16 18:05:31 2018 [vr] Ensure unticked transitions complete If a transition was enqueued but not serviced and, much later, another transition is enqueued, it should transition from the final value of the earlier transition. Bug: 832650 , 830592 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I751c5d26101bfa197818ccd2f72188513ed044f2 Reviewed-on: https://chromium-review.googlesource.com/1014008 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#551035} [modify] https://crrev.com/18a5665becb7cce9c10461631036bc847d76db45/chrome/browser/vr/animation.cc [modify] https://crrev.com/18a5665becb7cce9c10461631036bc847d76db45/chrome/browser/vr/animation_unittest.cc [modify] https://crrev.com/18a5665becb7cce9c10461631036bc847d76db45/chrome/browser/vr/elements/ui_element.cc [modify] https://crrev.com/18a5665becb7cce9c10461631036bc847d76db45/chrome/browser/vr/ui_scene_creator.cc
,
Apr 27 2018
,
May 8 2018
,
Jul 4
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Apr 13 2018