New issue
Advanced search Search tips

Issue 832638 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

FeatureEngagementTestCase is failing with the UI Refresh flag enabled

Project Member Reported by gambard@chromium.org, Apr 13 2018

Issue description

With UI Refresh flag enabled.

Running the FeatureEngagementTestCase test suite fails.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d642a3d0019121d44f7012cc5cdc298c194719f

commit 5d642a3d0019121d44f7012cc5cdc298c194719f
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Apr 13 15:42:46 2018

Fix FeatureEngagementTestCase for UI Refresh

This CL fixes the test suite, fixing the test that should pass and
disabling the one for the features not yet implemented.

Bug:  832638 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2138a74a73b18c40ebdee6b22432541d7bc27a91
Reviewed-on: https://chromium-review.googlesource.com/1012104
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550628}
[modify] https://crrev.com/5d642a3d0019121d44f7012cc5cdc298c194719f/ios/chrome/browser/feature_engagement/BUILD.gn
[modify] https://crrev.com/5d642a3d0019121d44f7012cc5cdc298c194719f/ios/chrome/browser/feature_engagement/feature_engagement_egtest.mm
[modify] https://crrev.com/5d642a3d0019121d44f7012cc5cdc298c194719f/ios/chrome/browser/ui/popup_menu/cells/popup_menu_tools_item.mm
[modify] https://crrev.com/5d642a3d0019121d44f7012cc5cdc298c194719f/ios/chrome/browser/ui/tools_menu/reading_list_menu_view_item.mm

Status: Fixed (was: Assigned)
NextAction: 2018-04-25
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d642a3d0019121d44f7012cc5cdc298c194719f

commit 5d642a3d0019121d44f7012cc5cdc298c194719f
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Apr 13 15:42:46 2018

Fix FeatureEngagementTestCase for UI Refresh

This CL fixes the test suite, fixing the test that should pass and
disabling the one for the features not yet implemented.

Bug:  832638 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2138a74a73b18c40ebdee6b22432541d7bc27a91
Reviewed-on: https://chromium-review.googlesource.com/1012104
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550628}
[modify] https://crrev.com/5d642a3d0019121d44f7012cc5cdc298c194719f/ios/chrome/browser/feature_engagement/BUILD.gn
[modify] https://crrev.com/5d642a3d0019121d44f7012cc5cdc298c194719f/ios/chrome/browser/feature_engagement/feature_engagement_egtest.mm
[modify] https://crrev.com/5d642a3d0019121d44f7012cc5cdc298c194719f/ios/chrome/browser/ui/popup_menu/cells/popup_menu_tools_item.mm
[modify] https://crrev.com/5d642a3d0019121d44f7012cc5cdc298c194719f/ios/chrome/browser/ui/tools_menu/reading_list_menu_view_item.mm

The NextAction date has arrived: 2018-04-25

Comment 6 by cma...@chromium.org, Apr 25 2018

NextAction: ----
Labels: Proj-UIRefresh

Sign in to add a comment