Issue metadata
Sign in to add a comment
|
Regression:'Speech' and 'Direction' option is disabled in context menu of Bookmark's overlay.
Reported by
shruti.j...@etouch.net,
Apr 13 2018
|
||||||||||||||||||||||
Issue descriptionChrome version: 67.0.3396.0 (Official Build) Revision 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}(64 bit) OS:Mac OS X(10.12.6,10.13.1,10.13.5) Steps to reproduce: 1.Launch chrome and navigate to any page and bookmark. 2.Click on star and click on 'More..' 3.Edit Bookmark overlay opens now Right click on bookmark bar and add new folder. 4.Now Right click on 'New folder' select edit and observe 'speech' and 'Direction' in context menu option by right clicking on it. Actual Result:'Speech' and 'Direction' option is disabled in context menu. Expected Result:'Speech' and 'Direction' option should be enabled in context menu . This is regression issue broken in ‘M-67’ and providing bisect info below(Unable to provide bisect using per-revision script,Hence providing bisect with old script): Good Build:67.0.3390.0(Revision:548637) Bad Build:67.0.3393.0(Revision:549377) Narrow Bisect info : https://chromium.googlesource.com/chromium/src/+log/d7588992ff17348b0c9d74201f7fd4b605237d80..83ba87f975448f2dd6a1ca3ca1c5c7fad780a9bf?pretty=fuller&n=10000 Suspecting:https://chromium.googlesource.com/chromium/src/+/6c0aed57e2e803aadf029450180782e0471b8baa @Elly Fong-Jones : Could you please help to reassign if your change is not the cause for this change. Note :Issue is only reproducible on MAC(10.12.6,10.13.1,10.13.5) OS. Thank You!
,
Apr 13 2018
spqchan@, over to you :)
,
Apr 13 2018
,
Apr 16 2018
,
Apr 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/639c091c17ba822e4335546fb3d474945430060c commit 639c091c17ba822e4335546fb3d474945430060c Author: spqchan <spqchan@chromium.org> Date: Mon Apr 16 22:37:05 2018 [MacViews] Fix for disabled submenu items in textfield context menu Bug: 832631 Change-Id: I211b693337c93a53fabd5aacd41bc4024cefc7c2 Reviewed-on: https://chromium-review.googlesource.com/1013877 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551153} [modify] https://crrev.com/639c091c17ba822e4335546fb3d474945430060c/ui/base/cocoa/text_services_context_menu.cc [modify] https://crrev.com/639c091c17ba822e4335546fb3d474945430060c/ui/base/cocoa/text_services_context_menu.h [modify] https://crrev.com/639c091c17ba822e4335546fb3d474945430060c/ui/views/controls/views_text_services_context_menu_mac.mm
,
Apr 16 2018
CL listed at #5 will need a merge to M67.
,
Apr 16 2018
,
Apr 17 2018
,
Apr 17 2018
#8 LGTM
,
Apr 17 2018
Approving merge to M67 branch 3396 based on comments #8 and #9. Please merge ASAP so we can pick it up for tomorrow's dev release. ellyjones@, would it be possible for you to do the merge as spqchan@ is in SDY.
,
Apr 17 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24191e7601a1a8f5108c3547259f8425f1aa74c5 commit 24191e7601a1a8f5108c3547259f8425f1aa74c5 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Tue Apr 17 17:01:12 2018 [MacViews] Fix for disabled submenu items in textfield context menu TBR=spqchan@chromium.org (cherry picked from commit 639c091c17ba822e4335546fb3d474945430060c) Bug: 832631 Change-Id: I211b693337c93a53fabd5aacd41bc4024cefc7c2 Reviewed-on: https://chromium-review.googlesource.com/1013877 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#551153} Reviewed-on: https://chromium-review.googlesource.com/1015260 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#45} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/24191e7601a1a8f5108c3547259f8425f1aa74c5/ui/base/cocoa/text_services_context_menu.cc [modify] https://crrev.com/24191e7601a1a8f5108c3547259f8425f1aa74c5/ui/base/cocoa/text_services_context_menu.h [modify] https://crrev.com/24191e7601a1a8f5108c3547259f8425f1aa74c5/ui/views/controls/views_text_services_context_menu_mac.mm
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/639c091c17ba822e4335546fb3d474945430060c commit 639c091c17ba822e4335546fb3d474945430060c Author: spqchan <spqchan@chromium.org> Date: Mon Apr 16 22:37:05 2018 [MacViews] Fix for disabled submenu items in textfield context menu Bug: 832631 Change-Id: I211b693337c93a53fabd5aacd41bc4024cefc7c2 Reviewed-on: https://chromium-review.googlesource.com/1013877 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551153} [modify] https://crrev.com/639c091c17ba822e4335546fb3d474945430060c/ui/base/cocoa/text_services_context_menu.cc [modify] https://crrev.com/639c091c17ba822e4335546fb3d474945430060c/ui/base/cocoa/text_services_context_menu.h [modify] https://crrev.com/639c091c17ba822e4335546fb3d474945430060c/ui/views/controls/views_text_services_context_menu_mac.mm
,
Apr 18 2018
Update : Retested above issue on Mac(10.12.6,10.13.1,10.13.5) OS using Dev #67.0.3396.10 and issue is fixed.Kindly review the attached screen-cast. Thank you! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rbasuvula@chromium.org
, Apr 13 2018