Password manager doesn't autofill when username elements contain prefilled values used as placeholders |
||
Issue descriptionThere are websites that prefill the value of <input> fields with placeholder text, instead of using the placeholder attribute. The password manager should recognize these situations and autofill saved credentials. Sample of websites where this currently happens: - https://www.htcmania.com/portal.php - https://www.asiatech.ir/users/login - https://www.linuxquestions.org/ (top log in form) - http://www.avsforum.com/forum/index.php - etc.
,
May 1 2018
,
Jan 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cbf5e60a05bfa68fa2f8afd28fe668fa9f1e8ef6 commit cbf5e60a05bfa68fa2f8afd28fe668fa9f1e8ef6 Author: Dominic Battre <battre@chromium.org> Date: Tue Jan 08 09:56:18 2019 Improve prefilled username field matching Chrome does not fill credentials into login forms if the username field is prefilled on page load. Often this is some placeholder text. We have a list of strings that are known placeholders. This CL makes two contributions: - Adding a few new items to the list that were discovered during testing. - Making the comparison case insensitive (at least for ASCII characters). We had the situation that "Email Address" and "email address" where whitelisted but a site failed that used "Email address". Bug: 832622 Change-Id: Id07c1defd84236e22c8f6c23f041c7d1d6a8dbee Reviewed-on: https://chromium-review.googlesource.com/c/1396035 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by: Christos Froussios <cfroussios@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#620669} [modify] https://crrev.com/cbf5e60a05bfa68fa2f8afd28fe668fa9f1e8ef6/components/autofill/content/renderer/BUILD.gn [modify] https://crrev.com/cbf5e60a05bfa68fa2f8afd28fe668fa9f1e8ef6/components/autofill/content/renderer/password_autofill_agent.cc [add] https://crrev.com/cbf5e60a05bfa68fa2f8afd28fe668fa9f1e8ef6/components/autofill/content/renderer/prefilled_values_detector.cc [add] https://crrev.com/cbf5e60a05bfa68fa2f8afd28fe668fa9f1e8ef6/components/autofill/content/renderer/prefilled_values_detector.h [add] https://crrev.com/cbf5e60a05bfa68fa2f8afd28fe668fa9f1e8ef6/components/autofill/content/renderer/prefilled_values_detector_unittest.cc
,
Jan 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/580e4cb86e71451bfdaffcafd00d56669bc2183c commit 580e4cb86e71451bfdaffcafd00d56669bc2183c Author: Dominic Battre <battre@chromium.org> Date: Tue Jan 08 11:11:22 2019 More username placeholders This CL intorduces three extra username placeholders that we discovered in the wild. Bug: 832622 Change-Id: I2f68cab2368b876d640584b23ea7e5d00ce2a59f Reviewed-on: https://chromium-review.googlesource.com/c/1400268 Commit-Queue: Dominic Battré <battre@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#620680} [modify] https://crrev.com/580e4cb86e71451bfdaffcafd00d56669bc2183c/components/autofill/content/renderer/prefilled_values_detector.cc
,
Jan 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/780a940e1ab9456855dd84685383680783c2d967 commit 780a940e1ab9456855dd84685383680783c2d967 Author: Dominic Battre <battre@chromium.org> Date: Tue Jan 08 13:19:49 2019 Allow filling username fiels with values like @example.com Chrome by default does not override contents of the username field of a login form when filling credentials. A number of sites prepopulate the username field with "@theirdomain.com" so that the user only needs to type their name before the @ sign. This CL takes the security origin of a credential, reduces it to the eTLD+1 and checks whether the filled content of a username field matches "^@.*${eTLD+1}$". Bug: 832622 Change-Id: I1aae30c47dde9e11b3c5c6da9ddcdd751d1c9681 Reviewed-on: https://chromium-review.googlesource.com/c/1400682 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#620699} [modify] https://crrev.com/780a940e1ab9456855dd84685383680783c2d967/components/autofill/content/renderer/password_autofill_agent.cc [modify] https://crrev.com/780a940e1ab9456855dd84685383680783c2d967/components/autofill/content/renderer/prefilled_values_detector.cc [modify] https://crrev.com/780a940e1ab9456855dd84685383680783c2d967/components/autofill/content/renderer/prefilled_values_detector.h [modify] https://crrev.com/780a940e1ab9456855dd84685383680783c2d967/components/autofill/content/renderer/prefilled_values_detector_unittest.cc |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Apr 17 2018