devtools/service-workers/user-agent-override.js timeout with incremental marking |
||
Issue descriptionThe following test times out with incremental marking virtual/pwa-full-code-cache/http/tests/devtools/service-workers/user-agent-override.js gn args: is_component_build = true is_debug = true use_goma = true symbol_level = 2 enable_blink_heap_incremental_marking = true command line third_party/WebKit/Tools/Scripts/run-webkit-tests --debug --additional-driver-flag=--enable-blink-features=HeapIncrementalMarking virtual/pwa-full-code-cache/http/tests/devtools/service-workers/user-agent-override.js Flakiness dashboard shows that it also timeoust on ToT sometimes. I am unsure whether this is a GC issue or a general problem/ https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=service-workers%2Fuser-agent-override.js I tried debugging this locally by manually starting run-blink-httpd and then navigating to the .js url but content shell only shows me the source code. Any help appreciated on how to get this running and what to look for.
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f02cbd2284b7a8a8279daa6eab7faf72747d366b commit f02cbd2284b7a8a8279daa6eab7faf72747d366b Author: Michael Lippautz <mlippautz@chromium.org> Date: Thu Apr 19 19:09:13 2018 [oilpan] Flag test for being prone to timeout when run with incremental marking Tbr: haraken@chromium.org No-try: true Bug: chromium:832621 Change-Id: Ib5c59dbc2912a296b9e151d684c7b178d1b6eecb Reviewed-on: https://chromium-review.googlesource.com/1020077 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#552107} [add] https://crrev.com/f02cbd2284b7a8a8279daa6eab7faf72747d366b/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=HeapIncrementalMarking
,
Apr 26 2018
Ping, can somebody explain how to debug this test?
,
Apr 26 2018
Sorry for the delay, I will take a look at this today. Some docs [1] [2] are a little out of date, but there is a npm task for debugging DevTools scripts. `npm test -d test-path.js` or if you've run `npm run setup-dtrun` from "third_party/blink/renderer/devtools", you can do `dtrun test -d test-path.js` and open localhost:9222 in a web browser. Then, evaluating `test()` in the console will run the test. [1] https://github.com/ChromeDevTools/devtools-frontend/wiki/Layout-Tests
,
Apr 26 2018
Just tried again on ToT and I still ran into a timeout. The flag slightly changed, this is the cmd line: third_party/WebKit/Tools/Scripts/run-webkit-tests --debug --additional-driver-flag=--enable-blink-features=HeapIncrementalMarkingStress virtual/pwa-full-code-cache/http/tests/devtools/service-workers/user-agent-override.js
,
Jun 15 2018
I think we concluded that this is a general issue with GC being observable and not an issue with incremental marking per se. |
||
►
Sign in to add a comment |
||
Comment 1 by dgozman@chromium.org
, Apr 13 2018