New issue
Advanced search Search tips

Issue 832608 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Flaky WebviewLogin Tests

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Apr 13 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of rhalavati@chromium.org

media_blink_unittests failing on chromium.memory/Linux ChromiumOS MSan Tests

Builders failed on: 
- Linux ChromiumOS MSan Tests: 
  https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests


 
These tests are highly flaky on linux-chromeos-rel:

WebviewLoginTest.StoragePartitionHandling
WebviewProxyAuthLoginTest.ProxyAuthTransfer


Summary: Flaky WebviewLogin Tests (was: Flaky WebviewProxyAuthLoginTest.ProxyAuthTransfer ChromiumOS MSan Tests)
Disabling tests on ChromeOS: crrev.com/c/1012036
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/211683469ae9589cecbea70776dc242d04fcfbc6

commit 211683469ae9589cecbea70776dc242d04fcfbc6
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Apr 13 12:01:11 2018

Disable flaky WebviewLogin Tests on ChromeOS.

Disables:
WebviewLoginTest.StoragePartitionHandling
WebviewProxyAuthLoginTest.ProxyAuthTransfer

Bug:  832608 
Change-Id: Ie5e2d9c8b0fd99fd3c018a004f8b7b0c567d8c38
TBR: achuith@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1012036
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550595}
[modify] https://crrev.com/211683469ae9589cecbea70776dc242d04fcfbc6/chrome/browser/chromeos/login/webview_login_browsertest.cc

Labels: -Sheriff-Chromium
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ec363c295c3d2e89721f7143fa17411428d7c6a

commit 2ec363c295c3d2e89721f7143fa17411428d7c6a
Author: Alex Moshchuk <alexmos@chromium.org>
Date: Fri Apr 13 19:01:20 2018

Revert "Disable flaky WebviewLogin Tests on ChromeOS."

This reverts commit 211683469ae9589cecbea70776dc242d04fcfbc6.

Reason for revert: These tests were almost certainly fixed by the reverts in https://bugs.chromium.org/p/chromium/issues/detail?id=828529.

Original change's description:
> Disable flaky WebviewLogin Tests on ChromeOS.
> 
> Disables:
> WebviewLoginTest.StoragePartitionHandling
> WebviewProxyAuthLoginTest.ProxyAuthTransfer
> 
> Bug:  832608 
> Change-Id: Ie5e2d9c8b0fd99fd3c018a004f8b7b0c567d8c38
> TBR: achuith@chromium.org
> Reviewed-on: https://chromium-review.googlesource.com/1012036
> Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
> Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550595}

TBR=achuith@chromium.org,rhalavati@chromium.org

Change-Id: I70215f566a19f05b8b7bea8ce867a5e47e5c417f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  832608 
Reviewed-on: https://chromium-review.googlesource.com/1012757
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550707}
[modify] https://crrev.com/2ec363c295c3d2e89721f7143fa17411428d7c6a/chrome/browser/chromeos/login/webview_login_browsertest.cc

Owner: alex...@chromium.org
Status: Fixed (was: Available)
The revert in https://bugs.chromium.org/p/chromium/issues/detail?id=828529 should've fixed this, and I'll reland my changes there with fixes to these tests.  Please reopen if this occurs again.
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/211683469ae9589cecbea70776dc242d04fcfbc6

commit 211683469ae9589cecbea70776dc242d04fcfbc6
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Apr 13 12:01:11 2018

Disable flaky WebviewLogin Tests on ChromeOS.

Disables:
WebviewLoginTest.StoragePartitionHandling
WebviewProxyAuthLoginTest.ProxyAuthTransfer

Bug:  832608 
Change-Id: Ie5e2d9c8b0fd99fd3c018a004f8b7b0c567d8c38
TBR: achuith@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1012036
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550595}
[modify] https://crrev.com/211683469ae9589cecbea70776dc242d04fcfbc6/chrome/browser/chromeos/login/webview_login_browsertest.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ec363c295c3d2e89721f7143fa17411428d7c6a

commit 2ec363c295c3d2e89721f7143fa17411428d7c6a
Author: Alex Moshchuk <alexmos@chromium.org>
Date: Fri Apr 13 19:01:20 2018

Revert "Disable flaky WebviewLogin Tests on ChromeOS."

This reverts commit 211683469ae9589cecbea70776dc242d04fcfbc6.

Reason for revert: These tests were almost certainly fixed by the reverts in https://bugs.chromium.org/p/chromium/issues/detail?id=828529.

Original change's description:
> Disable flaky WebviewLogin Tests on ChromeOS.
> 
> Disables:
> WebviewLoginTest.StoragePartitionHandling
> WebviewProxyAuthLoginTest.ProxyAuthTransfer
> 
> Bug:  832608 
> Change-Id: Ie5e2d9c8b0fd99fd3c018a004f8b7b0c567d8c38
> TBR: achuith@chromium.org
> Reviewed-on: https://chromium-review.googlesource.com/1012036
> Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
> Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550595}

TBR=achuith@chromium.org,rhalavati@chromium.org

Change-Id: I70215f566a19f05b8b7bea8ce867a5e47e5c417f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  832608 
Reviewed-on: https://chromium-review.googlesource.com/1012757
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550707}
[modify] https://crrev.com/2ec363c295c3d2e89721f7143fa17411428d7c6a/chrome/browser/chromeos/login/webview_login_browsertest.cc

Sign in to add a comment