Issue metadata
Sign in to add a comment
|
Regression : 'GPU Process' entry appears twice in chrome task manager.
Reported by
avsha...@etouch.net,
Apr 13 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version : 67.0.3396.0 (Official Build) 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} 32/64-bit OS : Windows(7,8,8.1,10) What steps will reproduce the problem? 1. Install a fresh Chrome canary build #67.0.3396.0 and launch it. 2. Press Shift + Esc to open chrome task manager. 3. Observe the 'GPU Process'. Actual Result : 'GPU Process' task appears twice in chrome task manager. Expected Result : Only one instance of 'GPU Process' should be seen in chrome task manager. This is a regression issue, broken in M-67 and providing the bisect using per-revision script: Good Build : 67.0.3395.0 (Revision : 549860) Bad Build : 67.0.3396.0 (Revision : 550428) (Getting 'No enough builds..' error while performing bisect with per-revision script hence providing the bisect using old script) Narrow bisect URL : https://chromium.googlesource.com/chromium/src/+log/b27727abc409de34bbd452c03fe0916551b813de..ddae152e4329839e040ec0aa295fca18cf000b80?pretty=fuller&n=10000 Suspecting : r550361 ? @Maggie : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note : 1. This issue is not observed on Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.13.5) OS
,
Apr 13 2018
A second GPU process is created by design to detect whether DX12 and Vulkan are supported in the GPU drivers. But it should be destroyed once the job is done. I will take a look.
,
Apr 13 2018
I am working on the code to kill the second GPU process.
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/018244f73127cd9a15d8db35eae7b1e00c7ec2ab commit 018244f73127cd9a15d8db35eae7b1e00c7ec2ab Author: Maggie Chen <magchen@chromium.org> Date: Fri Apr 13 20:44:17 2018 Quit the second GPU process when its job to gather the DX12/Vulkan info is complete. The previous checkin for "996594:Adding SupportsDX12 and SupportsVulkan to UMA histogram for the Windows platform" did not quit the GPU process after the job is complete. base::RunLoop().QuitCurrentWhenIdleDeprecated() is added to the end of the function of the second GPU process to fix this issue. BUG= 832596 TEST=manual,Chrome task manager R=zmo@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ifadb24d39b24a9a5a6cdc0c33e66bcfc42d5a5a7 Reviewed-on: https://chromium-review.googlesource.com/1012595 Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#550751} [modify] https://crrev.com/018244f73127cd9a15d8db35eae7b1e00c7ec2ab/components/viz/service/gl/gpu_service_impl.cc
,
Apr 16 2018
Update : Retested above issue in latest Canary build #68.0.3397.0 on Windows(7,8,8.1,10) OS and the issue is fixed. In latest Canary, only one 'GPU Process' is seen in chrome task manager. Kindly review an attached screen-cast. Thank you!
,
Apr 16 2018
,
Apr 16 2018
[Auto-generated comment by a script] We noticed that this issue is targeted for M-67; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-67 label, otherwise remove Merge-TBD label. Thanks.
,
Apr 16 2018
,
Apr 16 2018
,
Apr 17 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/450f31f0c98f04ae72291387e5933c3e63d5e536 commit 450f31f0c98f04ae72291387e5933c3e63d5e536 Author: Maggie Chen <magchen@chromium.org> Date: Tue Apr 17 16:43:53 2018 Quit the second GPU process when its job to gather the DX12/Vulkan info is complete. The previous checkin for "996594:Adding SupportsDX12 and SupportsVulkan to UMA histogram for the Windows platform" did not quit the GPU process after the job is complete. base::RunLoop().QuitCurrentWhenIdleDeprecated() is added to the end of the function of the second GPU process to fix this issue. BUG= 832596 TEST=manual,Chrome task manager R=zmo@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ifadb24d39b24a9a5a6cdc0c33e66bcfc42d5a5a7 Reviewed-on: https://chromium-review.googlesource.com/1012595 Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550751}(cherry picked from commit 018244f73127cd9a15d8db35eae7b1e00c7ec2ab) Reviewed-on: https://chromium-review.googlesource.com/1014204 Cr-Commit-Position: refs/branch-heads/3396@{#43} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/450f31f0c98f04ae72291387e5933c3e63d5e536/components/viz/service/gl/gpu_service_impl.cc
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/018244f73127cd9a15d8db35eae7b1e00c7ec2ab commit 018244f73127cd9a15d8db35eae7b1e00c7ec2ab Author: Maggie Chen <magchen@chromium.org> Date: Fri Apr 13 20:44:17 2018 Quit the second GPU process when its job to gather the DX12/Vulkan info is complete. The previous checkin for "996594:Adding SupportsDX12 and SupportsVulkan to UMA histogram for the Windows platform" did not quit the GPU process after the job is complete. base::RunLoop().QuitCurrentWhenIdleDeprecated() is added to the end of the function of the second GPU process to fix this issue. BUG= 832596 TEST=manual,Chrome task manager R=zmo@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ifadb24d39b24a9a5a6cdc0c33e66bcfc42d5a5a7 Reviewed-on: https://chromium-review.googlesource.com/1012595 Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#550751} [modify] https://crrev.com/018244f73127cd9a15d8db35eae7b1e00c7ec2ab/components/viz/service/gl/gpu_service_impl.cc
,
Apr 18 2018
Update : Retested above issue in latest Dev build #67.0.3396.10 on Windows(7,8,8.1,10) OS and the issue is fixed hence adding TE-Verified labels. Kindly review an attached screen-cast. Thank you! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rbasuvula@chromium.org
, Apr 13 2018