With UI Refresh Phase 1 enabled. What steps will reproduce the problem? (1) Open the NTP on an iOS 11 device (2) Open the NTP on an iOS 10 device What is the expected result? The NTP should look the same on both device. What happens instead? The iOS 10 device's NTP is 20 pt higher. Because https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm?sq=package:chromium&dr=C&l=222 is only available in iOS 11.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2533dfa0d5490ca288ae89f5183d8386bd6dd18a commit 2533dfa0d5490ca288ae89f5183d8386bd6dd18a Author: Justin Cohen <justincohen@google.com> Date: Tue Apr 17 17:57:01 2018 [ios] More fixes for making NTP fullscreen. Bug: 819460 , 832593 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6ba2bfc9e22758203b5dc44698e40db5295c79ce Reviewed-on: https://chromium-review.googlesource.com/1005912 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#551386} [modify] https://crrev.com/2533dfa0d5490ca288ae89f5183d8386bd6dd18a/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/2533dfa0d5490ca288ae89f5183d8386bd6dd18a/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.mm [modify] https://crrev.com/2533dfa0d5490ca288ae89f5183d8386bd6dd18a/ios/chrome/browser/ui/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/2533dfa0d5490ca288ae89f5183d8386bd6dd18a/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm [modify] https://crrev.com/2533dfa0d5490ca288ae89f5183d8386bd6dd18a/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.mm [modify] https://crrev.com/2533dfa0d5490ca288ae89f5183d8386bd6dd18a/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/2533dfa0d5490ca288ae89f5183d8386bd6dd18a/ios/chrome/browser/ui/content_suggestions/content_suggestions_layout.mm [modify] https://crrev.com/2533dfa0d5490ca288ae89f5183d8386bd6dd18a/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
Comment 1 by justincohen@chromium.org
, Apr 13 2018