New issue
Advanced search Search tips

Issue 832591 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Missing buildflag dependencies in chrome/services/media_gallery_util/public/cpp

Project Member Reported by mpichlin...@opera.com, Apr 13 2018

Issue description

Building target chrome/services/media_gallery_util/public/cpp in clean repository will fail due to missing buildflags.h files:

In file included from ../../chrome/services/media_gallery_util/public/cpp/safe_media_metadata_parser.cc:12:
In file included from ../../extensions/browser/blob_reader.h:17:
../../net/url_request/url_request.h:38:10: fatal error: 'net/net_buildflags.h' file not found

#include "net/net_buildflags.h"
../../chrome/services/media_gallery_util/public/cpp/media_parser_provider.cc:10:10: fatal error: 'media/media_buildflags.h' file not found
#include "media/media_buildflags.h"

This may result in random failures when building other big targets which depends on chrome/services/media_gallery_util/public/cpp
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdf5ef7cd5955cb118a2fb068b990001dd84c63d

commit bdf5ef7cd5955cb118a2fb068b990001dd84c63d
Author: Michał Pichliński <mpichlinski@opera.com>
Date: Fri Apr 13 16:43:40 2018

Added missing depenencies in chrome/services/media_gallery_util/public/cpp

Bug:  832591 
Change-Id: I8d104a7e0ede58f20d71bb5ce00f8b398cf8e28b
Reviewed-on: https://chromium-review.googlesource.com/1012023
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Michal Pichlinski <mpichlinski@opera.com>
Cr-Commit-Position: refs/heads/master@{#550643}
[modify] https://crrev.com/bdf5ef7cd5955cb118a2fb068b990001dd84c63d/chrome/services/media_gallery_util/public/cpp/BUILD.gn

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdf5ef7cd5955cb118a2fb068b990001dd84c63d

commit bdf5ef7cd5955cb118a2fb068b990001dd84c63d
Author: Michał Pichliński <mpichlinski@opera.com>
Date: Fri Apr 13 16:43:40 2018

Added missing depenencies in chrome/services/media_gallery_util/public/cpp

Bug:  832591 
Change-Id: I8d104a7e0ede58f20d71bb5ce00f8b398cf8e28b
Reviewed-on: https://chromium-review.googlesource.com/1012023
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Michal Pichlinski <mpichlinski@opera.com>
Cr-Commit-Position: refs/heads/master@{#550643}
[modify] https://crrev.com/bdf5ef7cd5955cb118a2fb068b990001dd84c63d/chrome/services/media_gallery_util/public/cpp/BUILD.gn

Sign in to add a comment