Note that above is just example config. We need to check all V8 masters for such configs.

In Buildbot UI, only the part before | is displayed, e.g. just "FYI" for example above. In LUCI, that would create a subcategory, hence we remove anything after | when translating configs.

All mail notifier configs that need to be migrated: https://cs.chromium.org/search/?q=mail_notifier_cfg.py+file:master.client.v8.

After looking the these configs, many rules seem to be redundant with gatekeeper configs that we already have. Are they even sending any emails? Does anyone read them? How about just dropping them and adding more rules to gatekeeper if someone complains?

Michael, can you please verify if you get emails from ports mater according to rule at [1]?


[1]: https://cs.chromium.org/chromium/build/masters/master.client.v8.ports/mail_notifier_cfg.py?l=20&rcl=64f442ba32c3fe6a7b5d5439948a7800ab1ce798

Don't have an email in my inbox. But it might also just be that the bots didn't fail in decades...

A separate gatekeeper tree would do it I guess?

Update: confirmed with Michael that mailer still works, so we'll need to migrate the config to gatekeeper.

Oops. Looks like I forgot about this. Raising priority to keep track.

WIP CL: https://crrev.com/c/1152826

After analyzing buildbot logic, it seems some configs are actually useless, e.g.
https://cs.chromium.org/chromium/build/masters/master.client.v8.branches/mail_notifier_cfg.py defines 4 notifiers, yet IIUC based on the value passed to categories_steps none of them will result in any emails.

This is based on studying the code for isInterestingStep [1]. It sends emails in the following cases:
 1. categories are not defined (i.e. an empty dict or None) - emails are sent for all steps in all builders, see [1] and [2]
 2. a category is set to '*' - emails are sent for all steps in builders matching the category, see [3], [4] and [5]
 3. a category lists some steps - emails are sent for listed steps in builders matching the category, see [3], [6] and [5]

We define categories (so the rule 1 does not apply) and have an empty list of steps (rules 2 and 3 do not apply), thus we won't send any emails. Given this, I skip migrating these configs to gatekeeper.


[1]: https://cs.chromium.org/chromium/build/scripts/master/chromium_notifier.py?l=124&rcl=8d0ac4cc185a8bda6420bbd15bb78bee13876f83
[2]: https://cs.chromium.org/chromium/build/scripts/master/chromium_notifier.py?l=203&rcl=8d0ac4cc185a8bda6420bbd15bb78bee13876f83
[3]: https://cs.chromium.org/chromium/build/scripts/master/chromium_notifier.py?l=131&rcl=8d0ac4cc185a8bda6420bbd15bb78bee13876f83
[4]: https://cs.chromium.org/chromium/build/scripts/master/chromium_notifier.py?l=212&rcl=8d0ac4cc185a8bda6420bbd15bb78bee13876f83
[5]: https://cs.chromium.org/chromium/build/scripts/master/chromium_notifier.py?l=220&rcl=8d0ac4cc185a8bda6420bbd15bb78bee13876f83
[6]: https://cs.chromium.org/chromium/build/scripts/master/chromium_notifier.py?l=216&rcl=8d0ac4cc185a8bda6420bbd15bb78bee13876f83

Also config for clusterfuzz category in https://cs.chromium.org/chromium/build/masters/master.client.v8.fyi/mail_notifier_cfg.py is not relevant anymore since we do not have such builders any longer.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/b9802b920b9159eb8b5b6a4b50f6cac6bc5d9bd2

commit b9802b920b9159eb8b5b6a4b50f6cac6bc5d9bd2
Author: Sergiy Byelozyorov <sergiyb@chromium.org>
Date: Fri Jul 27 15:18:52 2018

Migrate mail_notifier configs from Buildbot masters to gatekeeper

This also renames v8 folder into v8_gatekeeper since it only contains gatekeeper
configs.

R=machenbach@chromium.org

Bug:  832583 
Change-Id: I98e69f4249e4497f9e810ffbf7837e020eddb2f5
Reviewed-on: https://chromium-review.googlesource.com/1152826
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>

[rename] https://crrev.com/b9802b920b9159eb8b5b6a4b50f6cac6bc5d9bd2/scripts/slave/v8_gatekeeper/tree_closers.json
[add] https://crrev.com/b9802b920b9159eb8b5b6a4b50f6cac6bc5d9bd2/scripts/slave/v8_gatekeeper/mail_notifiers.json
[modify] https://crrev.com/b9802b920b9159eb8b5b6a4b50f6cac6bc5d9bd2/scripts/slave/gatekeeper_trees.json
[rename] https://crrev.com/b9802b920b9159eb8b5b6a4b50f6cac6bc5d9bd2/scripts/slave/v8_gatekeeper/OWNERS
[modify] https://crrev.com/b9802b920b9159eb8b5b6a4b50f6cac6bc5d9bd2/scripts/slave/recipe_modules/gatekeeper/tests/call.expected/production_data.json
[delete] https://crrev.com/d9700e81c8990b71688873204c3e019c30757ab8/scripts/slave/v8/gatekeeper_v8_chromium.json
[modify] https://crrev.com/b9802b920b9159eb8b5b6a4b50f6cac6bc5d9bd2/scripts/slave/recipes/gatekeeper.expected/production_data.json