New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 832566 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug

Blocking:
issue 832610



Sign in to add a comment

git cl land fails on bling autorollers

Project Member Reported by olivierrobin@chromium.org, Apr 13 2018

Issue description

Traceback (most recent call last):
  File "/b/depot_tools/git_cl.py", line 6034, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/b/depot_tools/git_cl.py", line 6016, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/b/depot_tools/git_cl.py", line 5154, in CMDland
    options.verbose)
  File "/b/depot_tools/git_cl.py", line 2752, in CMDLand
    change=self.GetChange(self.GetCommonAncestorWithUpstream(), None))
TypeError: RunHook() takes exactly 6 arguments (5 given)
step returned non-zero exit code: 1


 
Components: -Infra Infra>SDK
Blocking: 832610

Comment 3 Deleted

Labels: Infra-Troopers
Labels: -Infra-Troopers
Olivier created a CL for this https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1011613 which is waiting to land.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/67b3faa8f2d35bac4b774a3de3f1f6e5fa8b531f

commit 67b3faa8f2d35bac4b774a3de3f1f6e5fa8b531f
Author: Edward Lesmes <ehmaldonado@chromium.org>
Date: Fri Apr 13 21:56:50 2018

git-cl: Add parallel option to git-cl land.

It is used by CMDland but it was not declared and is causing failures.

TBR=agable@chromium.org

Bug:  832566 
Change-Id: Ia8ba5df458f9a39e415b7a9495dc338def0b16a5
Reviewed-on: https://chromium-review.googlesource.com/1013056
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>

[modify] https://crrev.com/67b3faa8f2d35bac4b774a3de3f1f6e5fa8b531f/git_cl.py
[modify] https://crrev.com/67b3faa8f2d35bac4b774a3de3f1f6e5fa8b531f/recipes/trigger_recipe_roller.txt

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c4ccd5d785b3227e1bc611276ddc2cc5fe52eab

commit 1c4ccd5d785b3227e1bc611276ddc2cc5fe52eab
Author: depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Sat Apr 14 02:19:42 2018

Roll src/third_party/depot_tools/ b8f33bef5..adc953f92 (2 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b8f33bef55b8..adc953f927bd

$ git log b8f33bef5..adc953f92 --date=short --no-merges --format='%ad %ae %s'
2018-04-13 tandrii Remove tandrii@ from watching git cl changes.
2018-04-13 ehmaldonado git-cl: Add parallel option to git-cl land.

Created with:
  roll-dep src/third_party/depot_tools
BUG= chromium:832566 


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I90fcd945d318a7d45d0e4c60e79060becd5aba9a
Reviewed-on: https://chromium-review.googlesource.com/1013286
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#550861}
[modify] https://crrev.com/1c4ccd5d785b3227e1bc611276ddc2cc5fe52eab/DEPS

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c4ccd5d785b3227e1bc611276ddc2cc5fe52eab

commit 1c4ccd5d785b3227e1bc611276ddc2cc5fe52eab
Author: depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Sat Apr 14 02:19:42 2018

Roll src/third_party/depot_tools/ b8f33bef5..adc953f92 (2 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b8f33bef55b8..adc953f927bd

$ git log b8f33bef5..adc953f92 --date=short --no-merges --format='%ad %ae %s'
2018-04-13 tandrii Remove tandrii@ from watching git cl changes.
2018-04-13 ehmaldonado git-cl: Add parallel option to git-cl land.

Created with:
  roll-dep src/third_party/depot_tools
BUG= chromium:832566 


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I90fcd945d318a7d45d0e4c60e79060becd5aba9a
Reviewed-on: https://chromium-review.googlesource.com/1013286
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#550861}
[modify] https://crrev.com/1c4ccd5d785b3227e1bc611276ddc2cc5fe52eab/DEPS

Status: Fixed (was: Started)

Sign in to add a comment