Issue metadata
Sign in to add a comment
|
STS Word highlight larger than focus rect in Google Slides |
||||||||||||||||||||||||
Issue descriptionChrome OS with flag enabled: #enable-experimental-accessibility-features 67.0.3383.0 (Official Build) dev (64-bit) Google_Samus.6300.276.0 # Enable STS # Load any Google Slide, I just used a new slide with default template Note: this repros both with and without the accessibility menu on so for simplicity I recorded this bug without the accessibility menu # Hold down search and use the mouse to draw a rect around the text in a Slide Expected: word highlight lines up with focus rect Actual: word highlight is larger than focus rect Since there is no word highlight with ChromeVox and Switch Access, no comparison. See this video for repro: https://drive.google.com/file/d/1OqHplk2a2RH0XViis-9y3gBge2RldFSm/view
,
Jul 2
,
Jul 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0e452422d56ad93dde15fe843dd85dcfe97cb42 commit c0e452422d56ad93dde15fe843dd85dcfe97cb42 Author: Katie D <katie@chromium.org> Date: Wed Jul 11 17:35:52 2018 Clips Automation.BoundsForRange to clipped location. Instead of returning BoundsForRange compared to the unclipped node location, clips bounds to the clipped location, so that BoundsForRange can never be outside the visible node bounds. This will stop the highlight from showing up when text is scrolled below the bottom of the screen or overflows its parent node, for example. Only SelectToSpeak seems to use BoundsForRange, so this change should not break any other a11y features. Bug: 832548 , 830104 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I763ae2df2228450b9b5d7f1fed0316c74abe470f Reviewed-on: https://chromium-review.googlesource.com/1123030 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#574222} [modify] https://crrev.com/c0e452422d56ad93dde15fe843dd85dcfe97cb42/chrome/renderer/extensions/automation_internal_custom_bindings.cc [modify] https://crrev.com/c0e452422d56ad93dde15fe843dd85dcfe97cb42/chrome/test/data/extensions/api_test/automation/sites/bounds_for_range.html [modify] https://crrev.com/c0e452422d56ad93dde15fe843dd85dcfe97cb42/chrome/test/data/extensions/api_test/automation/tests/tabs/bounds_for_range.js [modify] https://crrev.com/c0e452422d56ad93dde15fe843dd85dcfe97cb42/third_party/closure_compiler/externs/automation.js
,
Jul 11
,
Jul 30
Google Chrome 70.0.3505.0 (Official Build) canary (64-bit) Firmware Version Google_Eve.9584.160.0 No magnification on, display looks like 1200 x 800 (Default), font size Medium (recommended), no zoom (set to 100% for this page in the Chrome menu) I am still able to repro this bug, please see video for example: https://drive.google.com/file/d/1O4__e2Tc2I-jBJbcz13-YA_RMtqm5KRx/view Note about this video: I'm not sure why highlight mouse cursor showed up at the beginning of the video. I checked and there are no other accessibility features enabled on this Chromebook. Please put on a11y-testers label back on when ready for another verification.
,
Jul 30
,
Jul 30
I can reproduce this only on a high-density screen (like Eve). It works properly on a low-density screen. I'll file a follow-up bug. Laura, please confirm on a normal/low-density screen that this is fixed.
,
Sep 24
Google Chrome 71.0.3554.0 (Official Build) dev (64-bit) Firmware Version Google_Caroline.7820.384.0 Works as expected using the steps listed above. The highlight lines up with the text in the slide. Verified. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by katie@chromium.org
, Apr 13 2018