New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 832544 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Flaky-Test: ImmersiveModeControllerAshHostedAppBrowserTest.Layout



Sign in to add a comment

ImmersiveModeControllerAshHostedAppBrowserTest.Layout is Flaky

Project Member Reported by Findit, Apr 13 2018

Issue description

Findit has detected a flake at test ImmersiveModeControllerAshHostedAppBrowserTest.Layout.

Culprit (70.0% confidence): https://chromium-review.googlesource.com/q/I72b59eaab031f20924057d1c7ec614f221c52c61
Regression range: None

Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyyQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKSAWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bSBPUyBBU2FuIExTYW4gVGVzdHMgKDEpLzI3MDE2L2Jyb3dzZXJfdGVzdHMvU1cxdFpYSnphWFpsVFc5a1pVTnZiblJ5YjJ4c1pYSkJjMmhJYjNOMFpXUkJjSEJDY205M2MyVnlWR1Z6ZEM1TVlYbHZkWFE9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw

If this result was incorrect, apply the label Findit-Incorrect-Result, mark the bug as Untriaged and the component Tools>Test>Findit>Flakiness.
 
Project Member

Comment 1 by Findit, Apr 13 2018

Findit identified the culprit r550098 with confidence 70.0% in the config "chromium.memory / Linux Chromium OS ASan LSan Tests (1)"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyyQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKSAWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bSBPUyBBU2FuIExTYW4gVGVzdHMgKDEpLzI3MDE2L2Jyb3dzZXJfdGVzdHMvU1cxdFpYSnphWFpsVFc5a1pVTnZiblJ5YjJ4c1pYSkJjMmhJYjNOMFpXUkJjSEJDY205M2MyVnlWR1Z6ZEM1TVlYbHZkWFE9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw


Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Flake Analyzer is in beta.
Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness

Comment 2 by ortuno@chromium.org, Apr 13 2018

Owner: ortuno@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/812f43ba6cda56b5d33ecacd18cb95ac9904f106

commit 812f43ba6cda56b5d33ecacd18cb95ac9904f106
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Fri Apr 13 08:56:45 2018

hosted-apps: Disable flaky immersive mode test

https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5170

TBR=ortuno@chromium.org

Bug:  832544 
Change-Id: I0252cf8bcf5c0c16028830fa92ac69b644a7397f
Reviewed-on: https://chromium-review.googlesource.com/1011529
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550558}
[modify] https://crrev.com/812f43ba6cda56b5d33ecacd18cb95ac9904f106/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc

Cc: rhalavati@chromium.org
 Issue 832602  has been merged into this issue.
Disabling the test in crrev.com/c/1012032 as it's still happening.

--Sheriff.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0594b7786dbe69c543a81840a98a4798f5057a8e

commit 0594b7786dbe69c543a81840a98a4798f5057a8e
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Apr 13 11:01:27 2018

Disable flaky ImmersiveModeControllerAshHostedAppBrowserTest.Layout.

TBR=ortuno@chromium.org

Bug:  832544 
Change-Id: Ifd414f8e86d4a791723c925f647c524436d4f807
Reviewed-on: https://chromium-review.googlesource.com/1012032
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550582}
[modify] https://crrev.com/0594b7786dbe69c543a81840a98a4798f5057a8e/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc

Labels: -Sheriff-Chromium
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/812f43ba6cda56b5d33ecacd18cb95ac9904f106

commit 812f43ba6cda56b5d33ecacd18cb95ac9904f106
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Fri Apr 13 08:56:45 2018

hosted-apps: Disable flaky immersive mode test

https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5170

TBR=ortuno@chromium.org

Bug:  832544 
Change-Id: I0252cf8bcf5c0c16028830fa92ac69b644a7397f
Reviewed-on: https://chromium-review.googlesource.com/1011529
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550558}
[modify] https://crrev.com/812f43ba6cda56b5d33ecacd18cb95ac9904f106/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0594b7786dbe69c543a81840a98a4798f5057a8e

commit 0594b7786dbe69c543a81840a98a4798f5057a8e
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Apr 13 11:01:27 2018

Disable flaky ImmersiveModeControllerAshHostedAppBrowserTest.Layout.

TBR=ortuno@chromium.org

Bug:  832544 
Change-Id: Ifd414f8e86d4a791723c925f647c524436d4f807
Reviewed-on: https://chromium-review.googlesource.com/1012032
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550582}
[modify] https://crrev.com/0594b7786dbe69c543a81840a98a4798f5057a8e/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc

Status: Started (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, May 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6af95cd58309ce678d8e1221c55b7cb90cfe2e48

commit 6af95cd58309ce678d8e1221c55b7cb90cfe2e48
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Tue May 01 01:21:16 2018

hosted-apps: Deflake test by using secure app

Since [1], any page not considered "secure" would cause the location bar
to show. The test became flaky, because it loaded a site not considered
secure, which caused the location bar to animate in.

The test starts by saving the height of content WebView, then performing
some actions, and finally checking that the height of the WebView
remained unchanged. If the location bar didn't finish animating when the
test started, the height saved at the beginning of the test would be
different from the height at the end of the test.

This CL changes the tests to load a secure page from the start so that
the location bar doesn't show up.

[1] https://chromium.googlesource.com/chromium/src/+/09fa83a759eb20ade48ab85b06c21d3ff05edba4

Bug:  832544 
Change-Id: Ibfe271340b6aa27d9702698f1a07dd794155a5f4
Reviewed-on: https://chromium-review.googlesource.com/1034489
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554955}
[modify] https://crrev.com/6af95cd58309ce678d8e1221c55b7cb90cfe2e48/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc

Status: Fixed (was: Started)

Sign in to add a comment