New issue
Advanced search Search tips

Issue 832508 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature



Sign in to add a comment

Crostini install flow to generate cros sshkeys and insert pub key into container

Project Member Reported by joelhockey@chromium.org, Apr 13 2018

Issue description

When crostini container is created, ssh keys should be generated and public key added to container authorized_keys file.

These keys must also be made available to FilesApp to use as client ssh keys when connecting to container.
 
Components: Platform>Apps>FileManager
Labels: CrOSFilesFeature-Crostini
Labels: -Pri-3 Pri-1
I don't believe that cros currently ships sshkeygen.  I expect we need to add that to standard cros image.
Labels: -Type-Bug Type-Feature
FilesApp requires generated cros private key (id_rsa), and also public key of crostini server (id_rsa.pub) which will be added to the cros known_hosts file.
Components: OS>Systems>Containers
Cc: jkardatzke@chromium.org
Labels: Hotlist-Crostini-Files

Comment 8 by vapier@chromium.org, Apr 23 2018

Components: Platform>Apps>Default>Hterm
Cc: benwells@chromium.org
Cc: -jkardatzke@chromium.org nverne@chromium.org
Owner: jkardatzke@chromium.org
Labels: -Restrict-View-Google
Project Member

Comment 12 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/5780e54d840fd952550ca34f7e5b7d0bb802f7cf

commit 5780e54d840fd952550ca34f7e5b7d0bb802f7cf
Author: Jeffrey Kardatzke <jkardatzke@google.com>
Date: Thu May 10 22:09:48 2018

Add GetContainerSshKeys call to vm_concierge

This adds a call for getting the ssh keys for a container and the host
that are used for doing an SFTP mount of the container's filesystem.

BUG= chromium:832508 
TEST=Builds

Change-Id: I373460ccf640b346e44097e93105be6e8521dd5f
Reviewed-on: https://chromium-review.googlesource.com/1053246
Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com>
Tested-by: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>

[modify] https://crrev.com/5780e54d840fd952550ca34f7e5b7d0bb802f7cf/dbus/vm_concierge/service.proto
[modify] https://crrev.com/5780e54d840fd952550ca34f7e5b7d0bb802f7cf/dbus/vm_concierge/dbus-constants.h

Project Member

Comment 13 by bugdroid1@chromium.org, May 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/23aa291f40a7563d0b241062f97994ff926bfed9

commit 23aa291f40a7563d0b241062f97994ff926bfed9
Author: Jeffrey Kardatzke <jkardatzke@google.com>
Date: Sat May 12 06:22:15 2018

vm_tools: Add SSH keys to vm_concierge

This adds SSH key generation, retrieval and passing to the container for
the purpose of SFTP mounting the container's filesystem in the Chrome OS
Files app.  There is one keypair for the host and then one keypair per
container.  Container keys are deleted if their corresponding VM is
deleted.

BUG= chromium:832508 
TEST=Verified keys are generated and passed into run_container script

Change-Id: I8818bf6c64294d83750bdcfb4ef84e028ec0dd2d
Reviewed-on: https://chromium-review.googlesource.com/1053296
Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com>
Tested-by: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/23aa291f40a7563d0b241062f97994ff926bfed9/vm_tools/host.gypi
[modify] https://crrev.com/23aa291f40a7563d0b241062f97994ff926bfed9/vm_tools/concierge/service.cc
[modify] https://crrev.com/23aa291f40a7563d0b241062f97994ff926bfed9/vm_tools/concierge/client.cc
[add] https://crrev.com/23aa291f40a7563d0b241062f97994ff926bfed9/vm_tools/concierge/ssh_keys.h
[modify] https://crrev.com/23aa291f40a7563d0b241062f97994ff926bfed9/vm_tools/concierge/service.h
[add] https://crrev.com/23aa291f40a7563d0b241062f97994ff926bfed9/vm_tools/concierge/ssh_keys.cc

Project Member

Comment 15 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c613fec7bf46edabb6fdbaf5972159f6bb51a32c

commit c613fec7bf46edabb6fdbaf5972159f6bb51a32c
Author: Jeffrey Kardatzke <jkardatzke@google.com>
Date: Wed May 16 18:34:28 2018

Pass cryptohome_id into the StartContainer call

Bug:  832508 
Test: Verified key generation by concierge from Chrome call
Change-Id: Ie031d59ab95da3f5394c9621413a5a48066619a5
Reviewed-on: https://chromium-review.googlesource.com/1053273
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Cr-Commit-Position: refs/heads/master@{#559202}
[modify] https://crrev.com/c613fec7bf46edabb6fdbaf5972159f6bb51a32c/chrome/browser/chromeos/crostini/crostini_manager.cc
[modify] https://crrev.com/c613fec7bf46edabb6fdbaf5972159f6bb51a32c/chrome/browser/chromeos/crostini/crostini_manager.h
[modify] https://crrev.com/c613fec7bf46edabb6fdbaf5972159f6bb51a32c/chrome/browser/chromeos/crostini/crostini_manager_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment