New issue
Advanced search Search tips

Issue 832503 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----

Blocked on:
issue 829806



Sign in to add a comment

[WPT] New failures introduced in external/wpt/css/css-align by import https://crrev.com/c/1011120

Project Member Reported by monorail...@ecosystem-infra.iam.gserviceaccount.com, Apr 13 2018

Issue description

WPT import https://crrev.com/c/1011120 introduced new failures in external/wpt/css/css-align:

List of new failures:
external/wpt/css/css-align/default-alignment/shorthand-serialization-001.html new failing tests: https://crrev.com/c/1011120/4/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/shorthand-serialization-001-expected.txt

This import contains upstream changes from 827efec49afed216d98738b9cc60f63ca2bfc401 to bdcafaec67a8ab326a5b625fc6e2f1ffb239c4ae:
Let overflow parse two values.: https://github.com/w3c/web-platform-tests/commit/bdcafaec67a8ab326a5b625fc6e2f1ffb239c4ae [affecting this directory]
Implement Request.destination. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1402892 gecko-commit: 284b35d145ffcdd31fd0ecfef5031aac1bc82553 gecko-integration-branch: mozilla-inbound gecko-reviewers: asuth, baku: https://github.com/w3c/web-platform-tests/commit/96f16c57fbc99a793c9014f908f4ce9d235d8505
Remove http/tests/w3c: https://github.com/w3c/web-platform-tests/commit/51704839c172ba8a70910bff484837c25adbfc9a
Use version-specific prefs files when running Firefox (#10443): https://github.com/w3c/web-platform-tests/commit/cf2ef62f1c470b47a03275c795c6dedd69eace88
Backed out changeset 0f81334efa0a (bug 1445883) for crashes (bug 1446902). a=backout (#10412): https://github.com/w3c/web-platform-tests/commit/7e8bc611993cc4546bd8aaf0fb4e7a3513a9e1a2
Fix regression allowing text value for -webkit-background-origin: https://github.com/w3c/web-platform-tests/commit/fc7af09fb3eea0ef511a061e5734c1dc8e539b0d
Merge pull request #10170 from ewilligers/backgrounds-borders-parsing: https://github.com/w3c/web-platform-tests/commit/56a257efe6f0603bb17eff06934074d37587d9ad
Update by testing Firefox nightly 61.01a: https://github.com/w3c/web-platform-tests/commit/940c743ef143aa60d71f4c3236c24572d53ecc5d [affecting this directory]
Rename cakey.pem to cacert.key for consistency: https://github.com/w3c/web-platform-tests/commit/a5bb6d23ac757fcb5e8aef6fd7ed7587324982db
Update marionette_driver from 2.5.0 to 2.6.0 (#10437): https://github.com/w3c/web-platform-tests/commit/0ac0ee7a22c2b8f6fd609a7986b104c75c5428bd
Return null from contentDocument/getSVGDocument() for cross-origin documents.: https://github.com/w3c/web-platform-tests/commit/e965af7f2ed188e8cd7c343d494b0d334e15c18d
[css-layout-api] Fix DCHECK with the custom layout and multicol.: https://github.com/w3c/web-platform-tests/commit/976e2c1f4b37821272f303aee639b62e1fd085f9 [affecting this directory]
followup: Remove a explicit testharness.css link to appease wptlint.  on a CLOSED TREE bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1339656 gecko-commit: e90ac14a383f2a3ae97358d68dfcfc47f68e60c2 gecko-integration-branch: central gecko-reviewers: me: https://github.com/w3c/web-platform-tests/commit/19a42b96905c8518ca6598867da87c7617af8095 [affecting this directory]
css-align] Upstream our shorthand serialization tests. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1339656 gecko-commit: 4ac4932953254018e6fbd110ab8ab5ca76885069 gecko-integration-branch: central gecko-reviewers: mats: https://github.com/w3c/web-platform-tests/commit/13758ad1f5a49ebd90689951fb86618ed5f58cc3 [affecting this directory]
css-align] Don't restrict shorthand parsing now that's not ambiguous. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1339656 gecko-commit: 91ae8e15b175edc6e6e74b99f68fc155438b20ef gecko-integration-branch: central gecko-reviewers: mats: https://github.com/w3c/web-platform-tests/commit/b3a9b56e6a0a3c7d6efa6a1dee2e55444269d209 [affecting this directory]
S13nSW: Update wpt/service-workers/service-worker/navigation-preload/broken-chunked-encoding.https.html: https://github.com/w3c/web-platform-tests/commit/1dcdb61cb2eb054e6d16733d4eb4a6b56793b598
[css-typed-om] Support remaining multi-col properties.: https://github.com/w3c/web-platform-tests/commit/0060eb41b1da8a5989772e12c034e14e8d025fae [affecting this directory]
Add tests for liveness of NodeLists/HTMLCollections (#8993): https://github.com/w3c/web-platform-tests/commit/2d4fbd417e6772267c7755004e1022801fd3b92e
Stop generating stylo expectations. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1452113 gecko-commit: ea3453cc7d92df2539adeb45f390b9dfece2c4e6 gecko-integration-branch: central gecko-reviewers: jgraham: https://github.com/w3c/web-platform-tests/commit/7bbb8d0cc0cb5adad07deb1c2aa76a047f8921b7
Add test for checking property order after setting property on CSSStyleDeclaration: https://github.com/w3c/web-platform-tests/commit/c5c79bb418341bb0b2ed304f1325cd522bf4306e [affecting this directory]
Add webdriver.Element string representation. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1453084 gecko-commit: bdb78cb3d6d3cd0a5ebc31ee91a3c2590f54bb17 gecko-integration-branch: central gecko-reviewers: whimboo: https://github.com/w3c/web-platform-tests/commit/6003ea3102498b94445a4253d5da98d6a24a13ae
Add webdriver.Session string representation. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1453084 gecko-commit: 097b57bbeb46b0f3abc2b6fcec1c41a42d87f5da gecko-integration-branch: central gecko-reviewers: whimboo: https://github.com/w3c/web-platform-tests/commit/7f139952827f507a469d263d3917770a18fa7395
Stop running tests on pypy (#10435): https://github.com/w3c/web-platform-tests/commit/5a0d559e1acb9856b784e0d02e34856d9d8fad90
Don't store logger on the Config object (#10430): https://github.com/w3c/web-platform-tests/commit/03d76cc0bf283aead5520fd4137a7fc7607ee917
accname: Updated tests (#10433): https://github.com/w3c/web-platform-tests/commit/4cf7a66b04de7869777091b118892aac79659f6f
s/host/browser_host/ in wdspec fixture: https://github.com/w3c/web-platform-tests/commit/4b3342e16f320b69fef3c1809bb2614dc2109590
Add support for serializing the config as a dictionary.: https://github.com/w3c/web-platform-tests/commit/ddcc729bca5abcc460db875952eb693b04fe2e41
Part 9: Fix wpt reftest shape-image-025.html to make every frame of the animated GIF use a green box in the lower-left quadrant.: https://github.com/w3c/web-platform-tests/commit/a31d306732d898c13184a5dbefaa582e214047e8 [affecting this directory]
Part 8: Fix wpt reftest shape-image-001.html to correct a too-wide container.: https://github.com/w3c/web-platform-tests/commit/6b2fe34df13d646cab0a4b35dc33ee0202301851 [affecting this directory]
Part 5: Add web-platform-tests for linear-gradient with writing-modes.: https://github.com/w3c/web-platform-tests/commit/ccd2afabdea9e5325028220262f67a11383e5005 [affecting this directory]
Part 4: Replace hash '#' with %23 in SVG data URIs, to fix XML parse errors.: https://github.com/w3c/web-platform-tests/commit/1cda980346fcd679353c2a1d74c5f1f98d030ce3 [affecting this directory]
Use unicode-segmentation to iterate graphemes instead of chars (#10220): https://github.com/w3c/web-platform-tests/commit/9bc2e7439192ae1247de7421d23c60281037c037
Add a WPT test to verify dedicated workers have a separate client ID from their owning document. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1451124 gecko-commit: aed7d4d9be32f8806138d2a23f4b8b0332498085 gecko-integration-branch: central gecko-reviewers: asuth: https://github.com/w3c/web-platform-tests/commit/6571e31adb61b5c42f8dcf612e467958c9561650
Improve error when unable to find SSL key or cert. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1321517 gecko-commit: c7abc1d5b6ec9d32f54745f51e96065a89b774bf gecko-integration-branch: central gecko-reviewers: ato: https://github.com/w3c/web-platform-tests/commit/6e61ed2f67de550d0b04c22d6b6178a41b84fa01
Check for FTP subresource after applying CSP. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1404744 gecko-commit: b2c0699b9bd405300986bc26f256e8bb9c0c53a7 gecko-integration-branch: central gecko-reviewers: ckerschb: https://github.com/w3c/web-platform-tests/commit/002991d123354e1495ba66a4b6f04a0e6f19da9f
Change more web-platform tests to avoid using FTP.  CLOSED TREE bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1404744 gecko-commit: 42cda784d2c54c8730e7fd218a00fb5846263e76 gecko-integration-branch: central gecko-reviewers: me: https://github.com/w3c/web-platform-tests/commit/3ed3aadd4dc48c259493ec9f916faaee921f6ef3
Simple sub-resource only test. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1404744 gecko-commit: 1035ca43655e0bc157804943c21729d4a27823cd gecko-integration-branch: central gecko-reviewers: ckerschb: https://github.com/w3c/web-platform-tests/commit/6d1dd02664a8965e0086f994b9a476c9e7b4b62f
Disable test_pause_dblclick bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1432105 gecko-commit: f424114c6a2ccb65c256f42a835377eeb0f92d5c gecko-integration-branch: central gecko-reviewers: whimboo: https://github.com/w3c/web-platform-tests/commit/9b7e9bae73b6b2ed4515935937a72c783d779059
Stop pointer action tests from restarting Firefox bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1432105 gecko-commit: f6b8d9c6cbfa3b4a1b0437cee337ff636b3cfcbe gecko-integration-branch: central gecko-reviewers: whimboo: https://github.com/w3c/web-platform-tests/commit/cf39c87ae4712892c3da1238e672dba932996ae5
Merge pull request #10415 from w3c/font-variant-descriptor: https://github.com/w3c/web-platform-tests/commit/7967c43d852345c8750e06f165fb0ba6ff27adf3
[css-typed-om] Support remaining inline properties.: https://github.com/w3c/web-platform-tests/commit/9a2ba239ec826c0007352368d44fcfc02804ff16 [affecting this directory]
Add tests for transferring ImageBitmap objects.: https://github.com/w3c/web-platform-tests/commit/5d9948bbae3cb9517460f444350c13cc3d3a1888
quick test to see if descriptor supported anywhere: https://github.com/w3c/web-platform-tests/commit/98cc5c8bb77ef18be9c4464c8e66873654ade128 [affecting this directory]
Don't reparse stylesheets when assigning empty string to empty element.: https://github.com/w3c/web-platform-tests/commit/17b721557fe68928f16187318b80098f1a1b125a [affecting this directory]
update rel help (#10188): https://github.com/w3c/web-platform-tests/commit/991a413a0058a50288bbc508c00319e209c5ba02 [affecting this directory]
Add python handler directory to Python path in wptserve (#10397): https://github.com/w3c/web-platform-tests/commit/b3b6ea0b307a2a47cb19d1e843c7344769c410d9
[css-typed-om] Support remaining svg properties.: https://github.com/w3c/web-platform-tests/commit/d44cd21c00741101f22d62772efc070ba59e8f04 [affecting this directory]
[css-typed-om] Support remaining mask properties.: https://github.com/w3c/web-platform-tests/commit/e6f6bbfafe3dd4d35f01e5467911d0f4cbf7e618 [affecting this directory]
[css-typed-om] Support remaining text properties.: https://github.com/w3c/web-platform-tests/commit/3b7b8db90148105a987cc367165f7551edd8519f [affecting this directory]
[css-typed-om] Add support for scroll properties.: https://github.com/w3c/web-platform-tests/commit/387fba3809b776a98e6b11725c6d9a5be037bbca [affecting this directory]
Make DOMTokenList.supports() case-insensitive: https://github.com/w3c/web-platform-tests/commit/2e8fa7ba82e6d796bf460567be21fbe3d4902568
[KeyboardLock] Updating API to reject the first promise if lock is called twice: https://github.com/w3c/web-platform-tests/commit/1bb2bd025c3729192ded265adfbd57079ada2c5e
Automate more focus tests with testdriver (#10396): https://github.com/w3c/web-platform-tests/commit/6934f152ea12746ab33950caf6926ef8d99a5097
Firefox serialition: https://github.com/w3c/web-platform-tests/commit/fd10426a47d917110bc6f04995f01559ae817f05 [affecting this directory]
update rel help: https://github.com/w3c/web-platform-tests/commit/601982949bd7c58e9b19e60c41943fba08a45766 [affecting this directory]
CSS Backgrounds and Borders 3 parsing tests: https://github.com/w3c/web-platform-tests/commit/67918e50c7f9aae6c81060ae466a47b8482d6beb [affecting this directory]

 
Owner: jfernan...@igalia.com
Status: Started (was: Untriaged)
I started to work on this.
Blockedon: 829806
Status: (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3afa6045ecc3baf120c4436238807c063e5bf7a5

commit 3afa6045ecc3baf120c4436238807c063e5bf7a5
Author: Javier Fernandez <jfernandez@igalia.com>
Date: Fri Apr 20 10:03:46 2018

[css-align] Simple syntax for the Alignment shorthands

Now that the issue [1] about the syntax ambiguity has been resolved we
don“t need to use the custom syntax anymore. The Alignment shorthands
use now the simple syntax, defined based on the longhands' syntax.

Since we allow all the values valid for each longhand, we'll update
in this CL the corresponding web platform tests. Additionally, this CL
updates also the shorthand serialization tests [2], which didn't
consider the new value 'legacy' for justify-items (and place-items) due
to the bug [3] Firefox still has pending to be fixed.


[1] https://github.com/w3c/csswg-drafts/issues/1001
[2] css/css-align/default-alignment/shorthand-serialization-001.html
[3] https://bugzilla.mozilla.org/show_bug.cgi?id=1363875

Bug:  832503 ,  829806 
Change-Id: I53f803b384cc55b0b38292540262e54f803586da
Reviewed-on: https://chromium-review.googlesource.com/1013710
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#552293}
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/WebKit/LayoutTests/external/wpt/css/css-align/content-distribution/place-content-shorthand-001.html
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/WebKit/LayoutTests/external/wpt/css/css-align/content-distribution/place-content-shorthand-002.html
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/parse-justify-items-001.html
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/parse-justify-items-003.html
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/place-items-shorthand-001.html
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/place-items-shorthand-002.html
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/place-items-shorthand-004.html
[delete] https://crrev.com/6907b8c1532ec198277a6090afa7b295b5132d4a/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/shorthand-serialization-001-expected.txt
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/shorthand-serialization-001.html
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/WebKit/LayoutTests/external/wpt/css/css-align/resources/alignment-parsing-utils.js
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/WebKit/LayoutTests/external/wpt/css/css-align/self-alignment/place-self-shorthand-001.html
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/WebKit/LayoutTests/external/wpt/css/css-align/self-alignment/place-self-shorthand-002.html
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/WebKit/LayoutTests/external/wpt/css/css-align/self-alignment/place-self-shorthand-004.html
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/blink/renderer/core/css/properties/css_parsing_utils.h
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/blink/renderer/core/css/properties/shorthands/place_content_custom.cc
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/blink/renderer/core/css/properties/shorthands/place_items_custom.cc
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/blink/renderer/core/css/properties/shorthands/place_self_custom.cc

Status: Fixed
This issue should be FIXED now.

Sign in to add a comment