New issue
Advanced search Search tips

Issue 832498 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Integer-overflow in blink::IntRect::MaxY

Project Member Reported by ClusterFuzz, Apr 13 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6741794084356096

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  blink::IntRect::MaxY
  NormalizeRect
  blink::ParseOptions
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=549059:549062

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6741794084356096

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Apr 13 2018

Components: Blink>Canvas Platform
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Apr 13 2018

Labels: Test-Predator-Auto-Owner
Owner: tkent@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/238613f2364a704efa82a4e252f6c2058d7b1924 (Fix build on case-sensitive file systems after the Great Blink mv.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.

Comment 3 by tkent@chromium.org, Apr 13 2018

Components: -Platform
Labels: Test-Predator-Wrong-CLs
Owner: ----
Status: Untriaged (was: Assigned)
Cc: szager@chromium.org
Status: Available (was: Untriaged)
This issue looks similar to  bug 831461 , hence cc'ing to szager@ and marking it as available.

Thanks!
Owner: davidqu@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b8a0ab46cd487ecf42081735aef1292abc604b9

commit 0b8a0ab46cd487ecf42081735aef1292abc604b9
Author: Stefan Zager <szager@chromium.org>
Date: Fri Jul 27 22:03:37 2018

Prevent integer overflow when normalizing rect.

BUG= 832498 
R=davidqu@chromium.org

Change-Id: I8325e427df62ed97627ba3090c70b5795a156ba8
Reviewed-on: https://chromium-review.googlesource.com/1153566
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578824}
[modify] https://crrev.com/0b8a0ab46cd487ecf42081735aef1292abc604b9/third_party/blink/renderer/core/imagebitmap/image_bitmap.cc

Project Member

Comment 7 by ClusterFuzz, Jul 28

ClusterFuzz has detected this issue as fixed in range 578819:578824.

Detailed report: https://clusterfuzz.com/testcase?key=6741794084356096

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  blink::IntRect::MaxY
  NormalizeRect
  blink::ParseOptions
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=549059:549062
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=578819:578824

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6741794084356096

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Jul 28

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6741794084356096 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment