Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of chaopeng@chromium.org compile failing on 7 builders Builders failed on: - Linux x64: https://build.chromium.org/p/chromium/builders/Linux%20x64 - Win x64: https://build.chromium.org/p/chromium/builders/Win%20x64 - linux-chromeos-rel: https://build.chromium.org/p/chromium.chromiumos/builders/linux-chromeos-rel - Linux Builder (dbg)(32): https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29%2832%29 - Linux Builder (dbg): https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29 - Linux Builder: https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder
[11179/24650] CXX obj/extensions/common/unit_tests/extension_unittest.o FAILED: obj/extensions/common/unit_tests/extension_unittest.o /b/c/goma_client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/extensions/common/unit_tests/extension_unittest.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DCR_CLANG_REVISION=\"328716-2\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DOS_CHROMEOS -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DCR_LIBCXX_REVISION=329375 -DCR_LIBCXXABI_REVISION=329629 -DCR_SYSROOT_HASH=85ac8d5e0f6cff99fc323fd3d29cb73e2aa970e2 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DWEBP_EXTERN=extern -DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL -DGTEST_API_= -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=1 -DGTEST_HAS_TR1_TUPLE=0 -DTOOLKIT_VIEWS=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DV8_USE_EXTERNAL_STARTUP_DATA -DLEVELDB_PLATFORM_CHROMIUM=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSK_SUPPORT_GPU=1 -DMESA_EGL_NO_X11_HEADERS -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DGTEST_RELATIVE_PATH -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_LINUX -DCHROMEOS -DUNIT_TEST -I../.. -Igen -I../../third_party/libwebp/src -I../../third_party/khronos -I../../gpu -I../../third_party/libyuv/include -I../../third_party/googletest/custom -I../../third_party/googletest/src/googletest/include -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/protobuf/src -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/boringssl/src/include -I../../third_party/leveldatabase -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase/src/include -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/encode -I../../third_party/skia/include/gpu -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -I../../third_party/libwebm/source -I../../third_party/mesa/src/include -I../../third_party/blink -Igen/third_party/blink -I../../v8/include -Igen/v8/include -I../../third_party/googletest/src/googlemock/include -I../../third_party/webrtc_overrides -I../../third_party/webrtc -Igen -I../../third_party/flatbuffers/src/include -fno-strict-aliasing -fmerge-all-constants -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -pthread -fcolor-diagnostics -fdebug-prefix-map=/b/c/b/linux_chromeos_rel/src/out/Release=. -no-canonical-prefixes -m64 -march=x86-64 -Wall -Werror -Wextra -Wimplicit-fallthrough -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-null-pointer-arithmetic -Wno-ignored-pragma-optimize -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g0 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang no-realpath -Xclang -plugin-arg-find-bad-constructs -Xclang check-enum-max-value -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wno-header-guard -isystem../../build/linux/debian_sid_amd64-sysroot/usr/include/nss -isystem../../build/linux/debian_sid_amd64-sysroot/usr/include/nspr -Wno-exit-time-destructors -std=gnu++14 -fno-exceptions -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include --sysroot=../../build/linux/debian_sid_amd64-sysroot -fvisibility-inlines-hidden -c ../../extensions/common/extension_unittest.cc -o obj/extensions/common/unit_tests/extension_unittest.o ../../extensions/common/extension_unittest.cc:176:10: error: no member named 'SetBoolean' in 'extensions::DictionaryBuilder' .SetBoolean("converted_from_user_script", true); ^ 1 error generated.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/348808c076714a5422e9f6be8aca7e206d4c7464 commit 348808c076714a5422e9f6be8aca7e206d4c7464 Author: Jianpeng Chao <chaopeng@chromium.org> Date: Fri Apr 13 03:11:24 2018 Revert "[Extensions] Stop loading manifest v1 extensions" This reverts commit 6c5c219bd2ad58651dcb596b1211ce948d67a53a. Reason for revert: buildbot failed Original change's description: > [Extensions] Stop loading manifest v1 extensions > > Manifest v1 extensions have been deprecated for a long time. > Stop loading these extensions unless a special (existing) commandline > flag is present. There are a few straggling tests (which rely on > packaged extension resources, like .crx files) that still need to be > updated; use the commandline flag (or a runtime variant) in those tests. > These will be cleaned up in follow-up CLs. > > Bug: 831909 > Change-Id: If2323829cd75f826d54a34b713eecf7c28973667 > Reviewed-on: https://chromium-review.googlesource.com/1009070 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Reviewed-by: Min Qin <qinmin@chromium.org> > Commit-Queue: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550426} TBR=stevenjb@chromium.org,pastarmovj@chromium.org,lazyboy@chromium.org,rdevlin.cronin@chromium.org,qinmin@chromium.org Change-Id: I5a0a4c7f90421d139dce7cdc27d1affa2059c5a4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 831909 , 832488 Reviewed-on: https://chromium-review.googlesource.com/1011710 Reviewed-by: Jianpeng Chao <chaopeng@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#550482} [modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/chromeos/extensions/active_tab_permission_granter_delegate_chromeos_unittest.cc [modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc [modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/chromeos/extensions/extension_tab_util_delegate_chromeos_unittest.cc [modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/chromeos/extensions/permissions_updater_delegate_chromeos_unittest.cc [modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/chromeos/file_system_provider/service_unittest.cc [modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/chromeos/policy/device_local_account_browsertest.cc [modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/chromeos/ui/idle_app_name_notification_view_unittest.cc [modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/download/download_browsertest.cc [modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/extensions/component_loader_unittest.cc [modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/extensions/extension_browsertest.cc [modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc [modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/extensions/extension_service_test_base.cc [modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/extensions/extension_service_test_base.h [modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/extensions/startup_helper_browsertest.cc [modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/policy/policy_browsertest.cc [modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/ui/app_list/search/launcher_search/launcher_search_icon_image_loader_unittest.cc [modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc [modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc [modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/browser/ui/webui/extensions/extension_settings_browsertest.h [modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/chrome/common/extensions/manifest_tests/extension_manifests_manifest_version_unittest.cc [modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/extensions/browser/sandboxed_unpacker_unittest.cc [modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/extensions/common/BUILD.gn [modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/extensions/common/extension.cc [modify] https://crrev.com/348808c076714a5422e9f6be8aca7e206d4c7464/extensions/common/extension.h [delete] https://crrev.com/0fe1d4fc31ce423c8caacd4a86dadee389474b37/extensions/common/extension_unittest.cc
Both conflicting CLs have been reverted.
Comment 1 by chaopeng@chromium.org
, Apr 13 2018