Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of chaopeng@chromium.org compile failure on chromium.win/WinMSVC64 (dbg) Builders failed on: - WinMSVC64 (dbg): https://build.chromium.org/p/chromium.win/builders/WinMSVC64%20%28dbg%29
FAILED: obj/media/gpu/ipc/service/service/picture_buffer_manager.obj ninja -t msvc -e environment.x64 -- C:\b\c\goma_client/gomacc.exe "C:\b\c\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\VC\Tools\MSVC\14.11.25503\bin\HostX64\x64/cl.exe" /nologo /showIncludes -DV8_DEPRECATION_WARNINGS -DUSE_AURA=1 -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_HAS_EXCEPTIONS=0 -DCOMPONENT_BUILD -D__STD_C -D_CRT_RAND_S -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -D_ATL_NO_OPENGL -D_WINDOWS -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DPSAPI_VERSION=1 -DWIN32 -D_SECURE_ATL -D_USING_V110_SDK71_ -DWINAPI_FAMILY=WINAPI_FAMILY_DESKTOP_APP -DWIN32_LEAN_AND_MEAN -DNOMINMAX -D_UNICODE -DUNICODE -DNTDDI_VERSION=0x0A000002 -D_WIN32_WINNT=0x0A00 -DWINVER=0x0A00 -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -DWEBP_EXTERN=extern -DUSE_EGL -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_SUPPORT_GPU=1 -DGR_GL_FUNCTION_TYPE=__stdcall -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=wchar_t -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DPROTOBUF_USE_DLLS -DLEVELDB_PLATFORM_CHROMIUM=1 -DDeleteFile=DeleteFileW -DOS_WIN -DMESA_EGL_NO_X11_HEADERS -I../../third_party/mesa/src/include -I../.. -Igen -I../../third_party/khronos -I../../gpu -I../../third_party/libwebp/src -I../../third_party/wtl/include -I../../third_party/libyuv/include -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/encode -I../../third_party/skia/include/gpu -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/protobuf/src -I../../third_party/libwebm/source -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/leveldatabase -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase/src/include -I../../third_party/mesa/src/include /utf-8 /wd4117 /D__DATE__= /D__TIME__= /D__TIMESTAMP__= /Gy /FS /bigobj /d2FastFail /Zc:sizedDealloc- /W4 /WX /wd4091 /wd4127 /wd4251 /wd4275 /wd4312 /wd4324 /wd4351 /wd4355 /wd4503 /wd4589 /wd4611 /wd4100 /wd4121 /wd4244 /wd4505 /wd4510 /wd4512 /wd4610 /wd4838 /wd4995 /wd4996 /wd4456 /wd4457 /wd4458 /wd4459 /Od /Ob0 /GF /MDd /wd4267 /TP /wd4577 /GR- /c ../../media/gpu/ipc/service/picture_buffer_manager.cc /Foobj/media/gpu/ipc/service/service/picture_buffer_manager.obj /Fd"obj/media/gpu/ipc/service/service_cc.pdb" ../..\base/logging.h(780): error C2220: warning treated as error - no 'object' file generated ../../media/gpu/ipc/service/picture_buffer_manager.cc(77): note: see reference to function template instantiation 'std::string *logging::CheckLEImpl<uint32_t,>(const t1 &,const t2 &,const char *)' being compiled with [ t1=uint32_t, t2= ] ../..\base/logging.h(780): warning C4018: '<=': signed/unsigned mismatch
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42fdcfd16ef0da4502b1440449cee9abfe4308df commit 42fdcfd16ef0da4502b1440449cee9abfe4308df Author: Jianpeng Chao <chaopeng@chromium.org> Date: Fri Apr 13 03:06:21 2018 Revert "[media] VdaVideoDecoder" This reverts commit e192695db1c49298532a4ca9e872f3430003222f. Reason for revert: Buildbot failed. Original change's description: > [media] VdaVideoDecoder > > This adds VdaVideoDecoder, an adapter that implements the media::VideoDecoder interface using a > media::VideoDecodeAccelerator. VdaVideoDecoder expects to run in the GPU process, with access > to a command buffer stub, as will be the case for decoders created by MojoVideoDecoder. > > VdaVideoDecoder runs on the (mojo) IO thread as much as possible, but the VDA interface is > inherently tied to the GPU thread. > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I23f81c92b9ad72a5f0141c2eec2a528de1ffa9d3 > Bug: 522298 > Reviewed-on: https://chromium-review.googlesource.com/940336 > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Commit-Queue: Dan Sanders <sandersd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550471} TBR=xhwang@chromium.org,sandersd@chromium.org,liberato@chromium.org Change-Id: I706bf6a9b8b31d430b5facd0151e7e20dc73bcfb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 522298, 832484 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1011709 Reviewed-by: Jianpeng Chao <chaopeng@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#550480} [modify] https://crrev.com/42fdcfd16ef0da4502b1440449cee9abfe4308df/media/BUILD.gn [modify] https://crrev.com/42fdcfd16ef0da4502b1440449cee9abfe4308df/media/gpu/BUILD.gn [delete] https://crrev.com/c38bba2dcbdf40ac601dcedf6ead8163ee2e784c/media/gpu/command_buffer_helper.cc [delete] https://crrev.com/c38bba2dcbdf40ac601dcedf6ead8163ee2e784c/media/gpu/command_buffer_helper.h [delete] https://crrev.com/c38bba2dcbdf40ac601dcedf6ead8163ee2e784c/media/gpu/fake_command_buffer_helper.cc [delete] https://crrev.com/c38bba2dcbdf40ac601dcedf6ead8163ee2e784c/media/gpu/fake_command_buffer_helper.h [modify] https://crrev.com/42fdcfd16ef0da4502b1440449cee9abfe4308df/media/gpu/gles2_decoder_helper.cc [modify] https://crrev.com/42fdcfd16ef0da4502b1440449cee9abfe4308df/media/gpu/gles2_decoder_helper.h [modify] https://crrev.com/42fdcfd16ef0da4502b1440449cee9abfe4308df/media/gpu/ipc/service/BUILD.gn [delete] https://crrev.com/c38bba2dcbdf40ac601dcedf6ead8163ee2e784c/media/gpu/ipc/service/picture_buffer_manager.cc [delete] https://crrev.com/c38bba2dcbdf40ac601dcedf6ead8163ee2e784c/media/gpu/ipc/service/picture_buffer_manager.h [delete] https://crrev.com/c38bba2dcbdf40ac601dcedf6ead8163ee2e784c/media/gpu/ipc/service/picture_buffer_manager_unittest.cc [delete] https://crrev.com/c38bba2dcbdf40ac601dcedf6ead8163ee2e784c/media/gpu/ipc/service/vda_video_decoder.cc [delete] https://crrev.com/c38bba2dcbdf40ac601dcedf6ead8163ee2e784c/media/gpu/ipc/service/vda_video_decoder.h [delete] https://crrev.com/c38bba2dcbdf40ac601dcedf6ead8163ee2e784c/media/gpu/ipc/service/vda_video_decoder_unittest.cc [modify] https://crrev.com/42fdcfd16ef0da4502b1440449cee9abfe4308df/media/mojo/services/mojo_video_decoder_service.cc [modify] https://crrev.com/42fdcfd16ef0da4502b1440449cee9abfe4308df/media/mojo/test/mojo_video_decoder_integration_test.cc
Comment 1 by chaopeng@chromium.org
, Apr 13 2018