New issue
Advanced search Search tips

Issue 832483 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 830259
Owner: ----
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

ios-simulator: Don't run isolate.shard EarlGrey test if it doesn't exist

Project Member Reported by hinoka@chromium.org, Apr 13 2018

Issue description

https://ci.chromium.org/buildbot/tryserver.chromium.mac/ios-simulator/434054

The ios/try recipe tries to run the "isolate.shard EarlGrey test" step even if the binary doesn't exist.  IE if analyze says theres nothing to do.
 
Cc: jbudorick@chromium.org
Labels: -Pri-2 Pri-0
Making this builder 100% experimental until we can fix this, in order to avoid blocking CLs.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cf8deb5cd4e3e09de3f5fff6a05f2a4b55a6541

commit 5cf8deb5cd4e3e09de3f5fff6a05f2a4b55a6541
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Apr 13 04:18:23 2018

[cq.cfg] Make ios-simulator 100% experimental

Unfortunately this builder seems to have a recipe bug with
analyze and the way it runs one of the test suites.

R=jchinlee@chromium.org, tandrii@chromium.org
TBR=jbudorick@chromium.org

Bug:  832483 
Change-Id: I64d774535b52a92981a597d6c23e45659ae6aae1
Reviewed-on: https://chromium-review.googlesource.com/1011825
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550512}
[modify] https://crrev.com/5cf8deb5cd4e3e09de3f5fff6a05f2a4b55a6541/infra/config/branch/cq.cfg

Components: -Infra>Client>iOS Infra>Client>Chrome
Labels: -OS-Mac OS-iOS
Status: Available (was: Unconfirmed)
Summary: ios-simulator: Don't run isolate.shard EarlGrey test if it doesn't exist (was: Don't run isolate.shard EarlGrey test if it doesn't exist)
Labels: -Pri-0 Pri-1
I don't think this is a P0? It's an unfortunate bug in the recipe to be sure, but the work around is to keep at 100% experimental until all the bots have built that binary.

And it looks like they're all nearly there: (ignoring the disk space problems, but that's another issue)
https://ci.chromium.org/buildbot/tryserver.chromium.mac/ios-simulator/?limit=200
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd8b4ed33efdea76e37dfdefed34faa61402af17

commit cd8b4ed33efdea76e37dfdefed34faa61402af17
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Fri Apr 13 21:07:55 2018

Revert "[cq.cfg] Make ios-simulator 100% experimental"

This reverts commit 5cf8deb5cd4e3e09de3f5fff6a05f2a4b55a6541.

Reason for revert:

After cleaning up the unused Xcode versions and iOS runtime versions, disk usage has dropped to around 80%. Putting ios-simulator back to CQ.

Original change's description:
> [cq.cfg] Make ios-simulator 100% experimental
> 
> Unfortunately this builder seems to have a recipe bug with
> analyze and the way it runs one of the test suites.
> 
> R=​jchinlee@chromium.org, tandrii@chromium.org
> TBR=jbudorick@chromium.org
> 
> Bug:  832483 
> Change-Id: I64d774535b52a92981a597d6c23e45659ae6aae1
> Reviewed-on: https://chromium-review.googlesource.com/1011825
> Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550512}

TBR=iannucci@chromium.org,jchinlee@chromium.org,tandrii@chromium.org,jbudorick@chromium.org

Change-Id: Ib83e5589367de8b0d698dd614f5a3ddeaf56aff8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 832434
Reviewed-on: https://chromium-review.googlesource.com/1012819
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550764}
[modify] https://crrev.com/cd8b4ed33efdea76e37dfdefed34faa61402af17/infra/config/branch/cq.cfg

Mergedinto: 830259
Status: Duplicate (was: Available)
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cf8deb5cd4e3e09de3f5fff6a05f2a4b55a6541

commit 5cf8deb5cd4e3e09de3f5fff6a05f2a4b55a6541
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Apr 13 04:18:23 2018

[cq.cfg] Make ios-simulator 100% experimental

Unfortunately this builder seems to have a recipe bug with
analyze and the way it runs one of the test suites.

R=jchinlee@chromium.org, tandrii@chromium.org
TBR=jbudorick@chromium.org

Bug:  832483 
Change-Id: I64d774535b52a92981a597d6c23e45659ae6aae1
Reviewed-on: https://chromium-review.googlesource.com/1011825
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550512}
[modify] https://crrev.com/5cf8deb5cd4e3e09de3f5fff6a05f2a4b55a6541/infra/config/branch/cq.cfg

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd8b4ed33efdea76e37dfdefed34faa61402af17

commit cd8b4ed33efdea76e37dfdefed34faa61402af17
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Fri Apr 13 21:07:55 2018

Revert "[cq.cfg] Make ios-simulator 100% experimental"

This reverts commit 5cf8deb5cd4e3e09de3f5fff6a05f2a4b55a6541.

Reason for revert:

After cleaning up the unused Xcode versions and iOS runtime versions, disk usage has dropped to around 80%. Putting ios-simulator back to CQ.

Original change's description:
> [cq.cfg] Make ios-simulator 100% experimental
> 
> Unfortunately this builder seems to have a recipe bug with
> analyze and the way it runs one of the test suites.
> 
> R=​jchinlee@chromium.org, tandrii@chromium.org
> TBR=jbudorick@chromium.org
> 
> Bug:  832483 
> Change-Id: I64d774535b52a92981a597d6c23e45659ae6aae1
> Reviewed-on: https://chromium-review.googlesource.com/1011825
> Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550512}

TBR=iannucci@chromium.org,jchinlee@chromium.org,tandrii@chromium.org,jbudorick@chromium.org

Change-Id: Ib83e5589367de8b0d698dd614f5a3ddeaf56aff8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 832434
Reviewed-on: https://chromium-review.googlesource.com/1012819
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550764}
[modify] https://crrev.com/cd8b4ed33efdea76e37dfdefed34faa61402af17/infra/config/branch/cq.cfg

Sign in to add a comment