New issue
Advanced search Search tips

Issue 832399 link

Starred by 2 users
Status: Fixed
Owner:
billorr@chromium.org
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-XR


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Update/Add WebV/XR gamepad tests

Project Member Reported by bsheedy@chromium.org, Apr 13 2018 
https://chromium-review.googlesource.com/c/chromium/src/+/1003732 changed the behavior of the gamepad API for WebVR and WebXR, so tests need to be added and updated to match this new behavior. This means:

1. Change the existing WebVR tests (both DDView and Cardboard) to run with gamepad extensions disabled, as a gamepad should still be returned in this case https://cs.chromium.org/chromium/src/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrInputTest.java?q=webvrinputtest&sq=package:chromium&dr=CSs&l=164

2. Add a new test with WebXR enabled and WebXRGamepadSupport disabled and ensure a gamepad is not returned.

3. Add a new test with WebXR and WebXRGamepadSupport enabled and ensure a gamepad is returned.

4. Add a new test with WebVR, WebXR, and WebXRGamepadSupport disabled and ensure a gamepad is not returned.
Project Member

Comment 1 by bugdroid1@chromium.org, May 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ded7989effc86bb0ff914562b158c4b28746954

commit 6ded7989effc86bb0ff914562b158c4b28746954
Author: bsheedy <bsheedy@chromium.org>
Date: Thu May 31 02:29:46 2018

Add additional WebXR gamepad tests

Removes the --enable-gamepad-extensions flag from the WebVrInputTest
class since all its tests should work without it. Also adds DDView/
Cardboard tests for the following scenarios.

1. WebXR enabled, WebXRGamepadSupport disabled -> no gamepads available
2. WebXR enabled, WebXRGamepadSupport enabled -> gamepad available
3. WebXR disabled, WebXRGamepadsupport disabled -> no gamepads available

Bug:  832399 
Change-Id: Ic73a7d312faad19b33020fc790bc22f0b33ede43
Reviewed-on: https://chromium-review.googlesource.com/1038442
Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563120}
[modify] https://crrev.com/6ded7989effc86bb0ff914562b158c4b28746954/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrInputTest.java
[add] https://crrev.com/6ded7989effc86bb0ff914562b158c4b28746954/chrome/test/data/vr/e2e_test_files/html/test_webxr_gamepad_support.html
[add] https://crrev.com/6ded7989effc86bb0ff914562b158c4b28746954/chrome/test/data/vr/e2e_test_files/html/test_webxr_gamepad_support_nowebxr.html

Comment 2 by bsheedy@chromium.org, Jun 11 2018

Status: Fixed (was: Assigned)

Comment 3 by btebbs@chromium.org, Jul 4

Components: Internals>XR
►

Sign in to add a comment