New issue
Advanced search Search tips

Issue 832389 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

DownloadShelfControllerTest failing on chromium.mac/Mac10.13 Tests (dbg)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Apr 13 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of kmarshall@chromium.org

unit_tests failing on chromium.mac/Mac10.13 Tests (dbg)

Builders failed on: 
- Mac10.13 Tests (dbg): 
  https://build.chromium.org/p/chromium.mac/builders/Mac10.13%20Tests%20%28dbg%29


 
Owner: qin...@chromium.org
Status: Assigned (was: Available)

Comment 2 by jwd@chromium.org, Apr 19 2018

Labels: -Sheriff-Chromium
Seems gone, but this bug is assigned so I'm leaving it open.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a75887e34e825633002fd3d4084c63e3d128e457

commit a75887e34e825633002fd3d4084c63e3d128e457
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Thu Apr 19 18:41:47 2018

Suppress flaky DownloadShelfControllerTest.AddAndRemoveWithActiveItem.

TBR=qinmin@chromium.org

Bug: 832389
Change-Id: I3ba544b2413a6ce30038e60ae314a11abbab7bf6
Reviewed-on: https://chromium-review.googlesource.com/1011662
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552095}
[modify] https://crrev.com/a75887e34e825633002fd3d4084c63e3d128e457/chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm

Components: UI>Browser>Downloads
Labels: OS-Mac Type-Bug
Sadly the original link is dead, so now how do we know what failed? I had to track it down to:

https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8948796877911363520%2F%2B%2Fsteps%2Funit_tests%2F0%2Fstdout

[ RUN      ] DownloadShelfControllerTest.AddAndRemoveWithActiveItem
2018-04-19 10:43:15.604 unit_tests[51409:2943044] *** Owner supplied to -[NSTrackingArea initWithRect:options:owner:userInfo:] referenced a deallocating object. Tracking area behavior is undefined. Break on NSTrackingAreaDeallocatingOwnerError to debug.

Which looks familiar to a failure in DownloadShelfControllerTest.HideAndUnhide:

https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8948489811220488544%2F%2B%2Fsteps%2Funit_tests%2F0%2Fstdout

[ RUN      ] DownloadShelfControllerTest.HideAndUnhide
2018-04-22 20:06:42.059 unit_tests[40834:559956] *** Owner supplied to -[NSTrackingArea initWithRect:options:owner:userInfo:] referenced a deallocating object. Tracking area behavior is undefined. Break on NSTrackingAreaDeallocatingOwnerError to debug.
Backtrace from -dealloc:
0   libzombies.dylib                    0x000000014b733bcc (anonymous namespace)::ZombieDealloc(objc_object*, objc_selector*) + 588
1   libbase.dylib                       0x0000000133e36f4d base::internal::ScopedNSProtocolTraitsRelease(objc_object*) + 29
2   unit_tests                          0x000000010e1ccef5 base::internal::ScopedNSProtocolTraits<ViewResizerPong*>::Release(ViewResizerPong*) + 21
3   unit_tests                          0x000000010e1ccfda base::ScopedTypeRef<ViewResizerPong*, base::internal::ScopedNSProtocolTraits<ViewResizerPong*> >::~ScopedTypeRef() + 42
4   unit_tests                          0x000000010e1ccfa5 base::scoped_nsprotocol<ViewResizerPong*>::~scoped_nsprotocol() + 21
5   unit_tests                          0x000000010e1ccf85 base::scoped_nsobject<ViewResizerPong>::~scoped_nsobject() + 21
6   unit_tests                          0x000000010e1ccb55 base::scoped_nsobject<ViewResizerPong>::~scoped_nsobject() + 21
7   unit_tests                          0x000000010e387b23 (anonymous namespace)::DownloadShelfControllerTest::~DownloadShelfControllerTest() + 51
8   unit_tests                          0x000000010e38bee5 (anonymous namespace)::DownloadShelfControllerTest_HideAndUnhide_Test::~DownloadShelfControllerTest_HideAndUnhide_Test() + 21
9   unit_tests                          0x000000010e38b0f5 (anonymous namespace)::DownloadShelfControllerTest_HideAndUnhide_Test::~DownloadShelfControllerTest_HideAndUnhide_Test() + 21
10  unit_tests                          0x000000010e38b119 (anonymous namespace)::DownloadShelfControllerTest_HideAndUnhide_Test::~DownloadShelfControllerTest_HideAndUnhide_Test() + 25
11  unit_tests                          0x000000010ec3c58b testing::Test::DeleteSelf_() + 43
Summary: DownloadShelfControllerTest failing on chromium.mac/Mac10.13 Tests (dbg) (was: unit_tests failing on chromium.mac/Mac10.13 Tests (dbg))
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d28e6aabf534dd7f0fbc3a036b4d28434aae3e5d

commit d28e6aabf534dd7f0fbc3a036b4d28434aae3e5d
Author: Lei Zhang <thestig@chromium.org>
Date: Mon Apr 23 22:11:10 2018

Disable DownloadShelfControllerTest.HideAndUnhide.

It is crashing in a flaky manner.

BUG=832389
TBR=yoichio@chromium.org
NOTRY=true

Change-Id: Ic8b28082b990c85942aea6e6d90cd98d53b01dba
Reviewed-on: https://chromium-review.googlesource.com/1024736
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552854}
[modify] https://crrev.com/d28e6aabf534dd7f0fbc3a036b4d28434aae3e5d/chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm

Sign in to add a comment