New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 832387 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows
Pri: 1
Type: Bug
Proj-VR
Proj-XR



Sign in to add a comment

Add Origin Trial Tests for WebVR and WebXR

Project Member Reported by offenwanger@chromium.org, Apr 13 2018

Issue description

To ensure WebVR and WebXR Origin Tiral flags work, especially as the logic around the WebXR and the WebXRGamepadSupport trial is somewhat complicated, some Origin trial tests are required. 
 
Components: Blink>WebVR
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ac67ba2327c901a85b8cfb5b8bbda623dfea0a9

commit 1ac67ba2327c901a85b8cfb5b8bbda623dfea0a9
Author: Anna Offenwanger <offenwanger@chromium.org>
Date: Tue Apr 17 00:18:42 2018

Add tests for WebXR and WebVR origin trials.

Adding tests as per request of the origin trial team.

Bug:  832387 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie7d09c127f46d7de2928388d69712b2c73fdd630
Reviewed-on: https://chromium-review.googlesource.com/1003041
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Jason Chase <chasej@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551179}
[modify] https://crrev.com/1ac67ba2327c901a85b8cfb5b8bbda623dfea0a9/content/child/runtime_features.cc
[modify] https://crrev.com/1ac67ba2327c901a85b8cfb5b8bbda623dfea0a9/content/test/gpu/gpu_tests/webgl_conformance_integration_test.py
[add] https://crrev.com/1ac67ba2327c901a85b8cfb5b8bbda623dfea0a9/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/xr/webvr-gamepad-origin-trial-interfaces.html
[add] https://crrev.com/1ac67ba2327c901a85b8cfb5b8bbda623dfea0a9/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/xr/webvr-origin-trial-interfaces.html
[add] https://crrev.com/1ac67ba2327c901a85b8cfb5b8bbda623dfea0a9/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/xr/webxr-gamepad-origin-trial-interfaces.html
[add] https://crrev.com/1ac67ba2327c901a85b8cfb5b8bbda623dfea0a9/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/xr/webxr-origin-trial-interfaces.html
[modify] https://crrev.com/1ac67ba2327c901a85b8cfb5b8bbda623dfea0a9/third_party/blink/renderer/platform/runtime_enabled_features.json5

Labels: Merge-Request-67
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 18 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by gov...@chromium.org, Apr 18 2018

Pls merge your change to M67 branch 3396 ASAP. Thank you.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 18 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15ea7a01bc9c37f534f24308e46ce6c4becbb35b

commit 15ea7a01bc9c37f534f24308e46ce6c4becbb35b
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Wed Apr 18 15:13:58 2018

Add tests for WebXR and WebVR origin trials.

Adding tests as per request of the origin trial team.

TBR=offenwanger@chromium.org

(cherry picked from commit 1ac67ba2327c901a85b8cfb5b8bbda623dfea0a9)

Bug:  832387 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie7d09c127f46d7de2928388d69712b2c73fdd630
Reviewed-on: https://chromium-review.googlesource.com/1003041
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Jason Chase <chasej@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#551179}
Reviewed-on: https://chromium-review.googlesource.com/1017040
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#80}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/15ea7a01bc9c37f534f24308e46ce6c4becbb35b/content/child/runtime_features.cc
[modify] https://crrev.com/15ea7a01bc9c37f534f24308e46ce6c4becbb35b/content/test/gpu/gpu_tests/webgl_conformance_integration_test.py
[add] https://crrev.com/15ea7a01bc9c37f534f24308e46ce6c4becbb35b/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/xr/webvr-gamepad-origin-trial-interfaces.html
[add] https://crrev.com/15ea7a01bc9c37f534f24308e46ce6c4becbb35b/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/xr/webvr-origin-trial-interfaces.html
[add] https://crrev.com/15ea7a01bc9c37f534f24308e46ce6c4becbb35b/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/xr/webxr-gamepad-origin-trial-interfaces.html
[add] https://crrev.com/15ea7a01bc9c37f534f24308e46ce6c4becbb35b/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/xr/webxr-origin-trial-interfaces.html
[modify] https://crrev.com/15ea7a01bc9c37f534f24308e46ce6c4becbb35b/third_party/blink/renderer/platform/runtime_enabled_features.json5

Status: Fixed (was: Started)
Labels: Test-Complete
Components: Blink>WebXR

Sign in to add a comment