linker errors with linux component build and dcheck_is_configurable |
||||||
Issue descriptionJust saw dcheck_is_configurable in the list of gn args, but it can cause the build to fail. $ cat out/Release/args.gn enable_nacl = false enable_pdf = false enable_print_preview = false google_api_key = ... google_default_client_id = ... google_default_client_secret = ... is_component_build = true # removing this line results in successful build use_goma = true is_debug = false dcheck_is_configurable = true $ ninja -C out/Release -j1024 content_shell ninja: Entering directory `out/Release' [1/1] Regenerating ninja files [23483/23585] SOLINK ./libcontent.so FAILED: libcontent.so libcontent.so.TOC python "../../build/toolchain/gcc_solink_wrapper.py" --readelf="readelf" --nm="nm" --sofile="./libcontent.so" --tocfile="./libcontent.so.TOC" --output="./libcontent.so" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--no-as-needed -lpthread -Wl,--as-needed -fuse-ld=lld -Wl,--icf=all -m64 -Werror -Wl,-O2 -Wl,--gc-sections -Wl,--fatal-warnings -nostdlib++ --sysroot=../../build/linux/debian_sid_amd64-sysroot -L../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,--export-dynamic -o "./libcontent.so" -Wl,-soname="libcontent.so" @"./libcontent.so.rsp" /usr/local/google/home/dgrogan/c/1/src/out/Release/../../third_party/llvm-build/Release+Asserts/bin/ld.lld: error: undefined symbol: base::kDCheckIsFatalFeature >>> referenced by render_process_impl.cc >>> obj/content/renderer/renderer/render_process_impl.o:(content::RenderProcessImpl::RenderProcessImpl(std::__1::unique_ptr<base::TaskScheduler::InitParams, std::__1::default_delete<base::TaskScheduler::InitParams> >)) clang: error: linker command failed with exit code 1 (use -v to see invocation) [23560/23585] CXX obj/content/test/test_support/navigation_simulator.o ninja: build stopped: subcommand failed.
,
Apr 13 2018
|dcheck_is_configurable=true| is only used for an instrumented Windows official build (i.e. not a component build), so I expect this is just a missing BASE_EXPORT on that symbol.
,
Apr 13 2018
,
Apr 13 2018
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be978d748f8d136dc9ac8d73eb2bd36edfea0279 commit be978d748f8d136dc9ac8d73eb2bd36edfea0279 Author: Wez <wez@chromium.org> Date: Fri Apr 13 17:47:15 2018 Add missing BASE_EXPORT to base::kDCheckIsFatal constant. Bug: 832380 Change-Id: I0f059b801826147a8e86a7ba141215e95f57c734 Reviewed-on: https://chromium-review.googlesource.com/1011646 Reviewed-by: David Grogan <dgrogan@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#550676} [modify] https://crrev.com/be978d748f8d136dc9ac8d73eb2bd36edfea0279/base/feature_list.h
,
Apr 16 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be978d748f8d136dc9ac8d73eb2bd36edfea0279 commit be978d748f8d136dc9ac8d73eb2bd36edfea0279 Author: Wez <wez@chromium.org> Date: Fri Apr 13 17:47:15 2018 Add missing BASE_EXPORT to base::kDCheckIsFatal constant. Bug: 832380 Change-Id: I0f059b801826147a8e86a7ba141215e95f57c734 Reviewed-on: https://chromium-review.googlesource.com/1011646 Reviewed-by: David Grogan <dgrogan@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#550676} [modify] https://crrev.com/be978d748f8d136dc9ac8d73eb2bd36edfea0279/base/feature_list.h |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dgro...@chromium.org
, Apr 13 2018