New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 832348 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

[MacViewsBrowser]: "Zoom" text in settings menu is not translated in Spanish?

Project Member Reported by manoranj...@chromium.org, Apr 12 2018

Issue description

Chrome Version: 67.0.3395.0
OS: macOS 10.13.5 Beta (17F35e)

What steps will reproduce the problem?
(1) --enable-features=ViewsBrowserWindows
(2) Launch Chrome
(3) Wrench Menu -> Settings Menu

What is the expected result?
"Zoom" text in settings menu should be translated to 'Spanish'

What happens instead?
"Zoom" text in settings menu is not translated in Spanish?

Please see the attached screen shots for your reference.

Thank you!
 
Zoom_Spanish.png
80.9 KB View Download
Cc: -ellyjo...@chromium.org
Owner: ellyjo...@chromium.org
Status: Assigned (was: Untriaged)
Weird! The code is using IDS_ZOOM_MENU2, so I don't immediately see why it wouldn't have been translated. The old Cocoa menu was using IDS_ZOOM_MENU instead. I'll take a quick look at this but it *may* be simply a missing string.
Cc: ellyjo...@chromium.org
Owner: gov...@chromium.org
I confirmed that on my Mac build IDS_ZOOM_MENU is translated to "&Tamaño" (lit. "Size" I think, my Spanish is not good) but IDS_ZOOM_MENU2 is translated to "Zoom". Perhaps we missed a string?

govind@, can you help route this?

Comment 3 by gov...@chromium.org, Apr 13 2018

Cc: -ellyjo...@chromium.org gov...@chromium.org
Owner: ellyjo...@chromium.org
ellyjones@, could you pls provide a CL with .grd file which includes this string change so I can check whether the string is submitted for translation or not?
Sure - IDS_ZOOM_MENU2 actually dates to <https://codereview.chromium.org/657443004> which landed on 2014-10-23. It appears to have a correct translation already on Windows. I'm surprised that translation text is missing on Mac.

Comment 5 by gov...@chromium.org, Apr 13 2018

Cc: ellyjo...@chromium.org melliem@google.com jungshik@google.com
Owner: js...@chromium.org
Thank you Elly.
Per comment #4, string should be already translated as it was submitted on 2014-10-23.

jshin@, could you ptal?


Comment 6 by js...@chromium.org, Apr 13 2018

Owner: gov...@chromium.org
See http://shortn/_Homk1SsF1o (it's  link to the internal TC). 
https://screenshot.googleplex.com/Q7QJApqKd3m.png . 

I believe it's intentionally "translated" into "Zoom" in es-419. es-ES has different translation. 

If you want to check with linguist and make sure that it's indeed the case, file a bug at https://gloc-qm.appspot.com/bugs/add/ (moma search 'l10n bug').   Or, talk to Chrome's LPM (I forgot who that is). 




Comment 7 by gov...@chromium.org, Apr 13 2018

Owner: melliem@chromium.org
Thank you jshin@.

+melliem@ (Localization PgM, could you ptal comment #6 and confirm?

Comment 8 by js...@chromium.org, Apr 13 2018

Cc: srahim@chromium.org
+srahim for the consistency issue. 

BTW, 'zoom' comes up in a lot of messages and es and es-419 do not have internal consistency (see the page linked in comment 6 or the screenshot).  This may need some clean-up after establishing the guideline. So, LPM and linguists need to be involved for that 'clean-up'. 

Comment 9 by melliem@google.com, Apr 16 2018

Hi, I just checked acrolinx (https://acrolinx.corp.google.com/termbrowser/Standardview.html#termDatabaseId=69537820)and zoom shouldn't be translated in both es-es and es-419.
We can set up a clean up to keep consistency. 

Comment 10 by melliem@google.com, Apr 17 2018

quick update here to let you know that we just kicked of a clean up on Chrome TC projects - I'm happy to let you know once it's done

Comment 11 by melliem@google.com, Apr 24 2018

Quick update to let you that the clean-up has been completed
To be clear re #9, the word "Zoom" should appear in es-419 and es-ES as "Zoom" and not "Tamaño"?

Comment 13 by melliem@google.com, Apr 25 2018

that's correct
Status: WontFix (was: Assigned)
Alright - in that case this is WontFix.

Sign in to add a comment