New issue
Advanced search Search tips

Issue 832333 link

Starred by 1 user

Issue metadata

Status: Unconfirmed
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Add firmware signature validation for logitech-updater

Reported by l...@logitech.com, Apr 12 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36

Steps to reproduce the problem:
N/A

What is the expected behavior?
Validate firmware signature when run logitech-updater.

What went wrong?
The previous updater still works but it should validate the firmware signature to ensure firmware is signed by Logitech.

Did this work before? N/A 

Chrome version: 65.0.3325.181  Channel: stable
OS Version: 
Flash Version:
 
Components: Tools
Project Member

Comment 2 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/logitech-updater/+/ff3bf88a5cba9a6c6fcb6cf54e3388406395eb82

commit ff3bf88a5cba9a6c6fcb6cf54e3388406395eb82
Author: Lam Lu <llu7@logitech.com>
Date: Fri May 25 02:30:21 2018

Add firmware signature validation for logitech-updater.

Validate firmware payload signature to ensure firmware
is signed by Logitech when running logitech-updater.
Use --test_sig if payload are signed by test key.

BUG=chromium:832333
TEST=Run /sbin/minijail0 -u cfm-firmware-updaters -u
cfm-firmware-updaters -G -e -i -l -r -n -p -v -S
/usr/share/policy/logitech-updater-seccomp.policy
/usr/sbin/logitech-updater --lock --delay=10
--update_components.

Change-Id: I3ac4d6424ba336c6c26d2cae2475ec2e2845ef8b
Reviewed-on: https://chromium-review.googlesource.com/1012465
Commit-Ready: Zhongze Hu <frankhu@google.com>
Tested-by: Zhongze Hu <frankhu@google.com>
Reviewed-by: Zhongze Hu <frankhu@google.com>

[modify] https://crrev.com/ff3bf88a5cba9a6c6fcb6cf54e3388406395eb82/src/module.mk
[modify] https://crrev.com/ff3bf88a5cba9a6c6fcb6cf54e3388406395eb82/src/main.cc
[modify] https://crrev.com/ff3bf88a5cba9a6c6fcb6cf54e3388406395eb82/src/utilities.h
[modify] https://crrev.com/ff3bf88a5cba9a6c6fcb6cf54e3388406395eb82/src/utilities.cc

Sign in to add a comment