New issue
Advanced search Search tips

Issue 832332 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Timeline hangs on "Stopping timeline phase"

Project Member Reported by alph@chromium.org, Apr 12 2018

Issue description

It sometimes happens when the user records page reload and stops it manually. Auto stopping races with manual stop.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4aa38134417e6af065b4063fe3cc599de9494c94

commit 4aa38134417e6af065b4063fe3cc599de9494c94
Author: Alexei Filippov <alph@chromium.org>
Date: Fri Apr 13 16:59:50 2018

DevTools: Fix timeline stop recording race.

The recording could have already being stopped by the time auto stop kicks in.

BUG= 832332 

Change-Id: Ia25f8b7c3fc9c0ba62956ed5d8286fdcc786cdee
Reviewed-on: https://chromium-review.googlesource.com/1011399
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550655}
[modify] https://crrev.com/4aa38134417e6af065b4063fe3cc599de9494c94/third_party/blink/renderer/devtools/front_end/timeline/TimelinePanel.js

Project Member

Comment 2 by sheriffbot@chromium.org, Apr 16 2018

This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone.

All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly.

This issue is marked as a release blocker with no OS labels associated. Please add an appropriate OS label.

All release blocking issues should have OS labels associated to it, so that the issue can tracked and promptly verified, once it gets fixed.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by alph@chromium.org, Apr 16 2018

Labels: Merge-Request-67

Comment 4 by gov...@chromium.org, Apr 16 2018

Pls apply appropriate OSs label. Thank you.

Comment 5 by alph@chromium.org, Apr 16 2018

Labels: OS-Linux OS-Mac OS-Windows
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 17 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 17 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1d37084232503512ab344c2df193e1ab5106b5b

commit a1d37084232503512ab344c2df193e1ab5106b5b
Author: Alexei Filippov <alph@chromium.org>
Date: Tue Apr 17 17:20:03 2018

DevTools: Fix timeline stop recording race.

The recording could have already being stopped by the time auto stop kicks in.

BUG= 832332 
TBR=alph@chromium.org

(cherry picked from commit 4aa38134417e6af065b4063fe3cc599de9494c94)

Change-Id: Ia25f8b7c3fc9c0ba62956ed5d8286fdcc786cdee
Reviewed-on: https://chromium-review.googlesource.com/1011399
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550655}
Reviewed-on: https://chromium-review.googlesource.com/1015294
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#47}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/a1d37084232503512ab344c2df193e1ab5106b5b/third_party/blink/renderer/devtools/front_end/timeline/TimelinePanel.js

Comment 8 by alph@chromium.org, Apr 17 2018

Status: Fixed (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4aa38134417e6af065b4063fe3cc599de9494c94

commit 4aa38134417e6af065b4063fe3cc599de9494c94
Author: Alexei Filippov <alph@chromium.org>
Date: Fri Apr 13 16:59:50 2018

DevTools: Fix timeline stop recording race.

The recording could have already being stopped by the time auto stop kicks in.

BUG= 832332 

Change-Id: Ia25f8b7c3fc9c0ba62956ed5d8286fdcc786cdee
Reviewed-on: https://chromium-review.googlesource.com/1011399
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550655}
[modify] https://crrev.com/4aa38134417e6af065b4063fe3cc599de9494c94/third_party/blink/renderer/devtools/front_end/timeline/TimelinePanel.js

Comment 10 by alph@chromium.org, Apr 27 2018

Cc: paulir...@chromium.org
Labels: Merge-Request-66
People reporting it in M66.
Labels: M-67
how widespread is this issue? Is it happening in M67?
Cc: gov...@chromium.org
Labels: -M-67
This is already merged to M67 per at #7. So removing "M-67" label. 
Labels: -Merge-Request-66 Merge-Rejected-66

Sign in to add a comment