New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 832326 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----

Blocking:
issue 829949



Sign in to add a comment

Step name is not the same as isolated target name

Project Member Reported by st...@chromium.org, Apr 12 2018

Issue description

What is the bug or feature:
For test step mus_browser_tests, the isolated target name is browser_tests instead of the test name.

Context or examples:
https://chromium-review.googlesource.com/c/infra/infra/+/976373/3//COMMIT_MSG#10

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/ca490022f001179ebf8d70a543eb32115e19dfa0

commit ca490022f001179ebf8d70a543eb32115e19dfa0
Author: Shuotao Gao <stgao@chromium.org>
Date: Thu Apr 12 22:47:34 2018

[Findit] Get isolate sha correctly for test step like mus_browser_tests.

One assumption is that for one single test step there is only one isolate target.
This seems true for most cases like gtests and webkit_layout_tests, but might
need further verification.

Bug:  832326 
Change-Id: I3d8c83fa3ad678bd4be7dc5d28012a9842ec7da5
Reviewed-on: https://chromium-review.googlesource.com/1011409
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/ca490022f001179ebf8d70a543eb32115e19dfa0/appengine/findit/pipelines/flake_failure/get_isolate_sha_pipeline.py

Comment 2 by st...@chromium.org, Apr 12 2018

Owner: st...@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment