New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 832320 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocking:
issue 829949



Sign in to add a comment

Should not trigger a try-job twice if exception occurrence right after triggering

Project Member Reported by st...@chromium.org, Apr 12 2018

Issue description

What is the bug or feature:
Currently, if a try-job is triggered after data is not processed successfully resulting an exception, pipeline will retry 3 times and that will cause multiple try-jobs to be triggered. 

Context or examples:
https://pantheon.corp.google.com/errors/CPuwhObCm8ngIg?time=P1D&project=findit-for-me

Expected:


 
Owner: lijeffrey@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e0617dd42e66a778512f45eef3f50606a394a009

commit e0617dd42e66a778512f45eef3f50606a394a009
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Wed Apr 25 19:51:18 2018

[Findit] Flake Analyzer - Refactoring RunFlakeTryJobPipeline

1. Refactor RunFlakeTryJobPipeline to take advantage of new async pipeline
2. Speculative fix for the original error that was surfacing the try-except
   that should ensure the try job entity is available before updating it.

Bug:  832320 
Change-Id: Ic8538b7eb814a688180353a460c62dd705999148
Reviewed-on: https://chromium-review.googlesource.com/1022476
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/e0617dd42e66a778512f45eef3f50606a394a009/appengine/findit/pipelines/flake_failure/run_flake_try_job_pipeline.py
[modify] https://crrev.com/e0617dd42e66a778512f45eef3f50606a394a009/appengine/findit/services/flake_failure/flake_try_job.py
[modify] https://crrev.com/e0617dd42e66a778512f45eef3f50606a394a009/appengine/findit/services/test/try_job_test.py
[modify] https://crrev.com/e0617dd42e66a778512f45eef3f50606a394a009/appengine/findit/services/flake_failure/test/flake_try_job_test.py
[modify] https://crrev.com/e0617dd42e66a778512f45eef3f50606a394a009/appengine/findit/services/try_job.py
[modify] https://crrev.com/e0617dd42e66a778512f45eef3f50606a394a009/appengine/findit/pipelines/flake_failure/test/run_flake_try_job_pipeline_test.py

Status: Fixed (was: Started)

Sign in to add a comment