New issue
Advanced search Search tips

Issue 832313 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

CPU profiles are not shown for OOPIFs

Project Member Reported by alph@chromium.org, Apr 12 2018

Issue description

CPU profiles are not shown for OOPIFs
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 25 2018

Comment 2 by alph@chromium.org, Apr 25 2018

Labels: Merge-Request-67 M-67 OS-Linux OS-Mac OS-Windows
Status: Fixed (was: Assigned)
Status: Started (was: Fixed)
Tests are failing on https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/7386.
02:10:11.205 13893 Retrying 1 unexpected failure, attempt 3 of 3...
02:10:11.205 13893 Sharding tests ...
02:10:11.205 13893 Starting 1 worker ...
02:10:11.205 13893 worker/0 starting
02:11:17.789 13893 killed pid 1613
02:11:17.790 13893 worker/0 http/tests/devtools/oopif/oopif-performance-cpu-profiles.js output stderr lines:
02:11:17.791 13893   
02:11:17.791 13893   DevTools listening on ws://127.0.0.1:43796/devtools/browser/2f380ac0-a8c6-4606-98c2-b3239eb3f997
02:11:17.791 13893   [1:1:0426/021049.867350:WARNING:trace_log.cc(1003)] The following threads haven't finished flush in time. If this happens stably for some thread, please call TraceLog::GetInstance()->SetCurrentThreadBlocksMessageLoop() from the thread to avoid its trace events from being lost.
02:11:17.792 13893 [1/1] http/tests/devtools/oopif/oopif-performance-cpu-profiles.js failed unexpectedly (test timed out)
02:11:17.792 13893 worker/0 killing primary driver
02:11:17.792 13893 worker/0 killing secondary driver
02:11:17.792 13893 worker/0 http/tests/devtools/oopif/oopif-performance-cpu-profiles.js failed:
02:11:17.792 13893 worker/0  test timed out
02:11:17.792 13893 worker/0 killing secondary driver
02:11:17.792 13893 worker/0 exiting
02:11:17.792 13893 worker/0 cleaning up
02:11:17.792 13893 worker/0 killing primary driver
02:11:17.792 13893 worker/0 killing secondary driver
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cc61059c915c9b707a75671c5ae134a930ff993

commit 1cc61059c915c9b707a75671c5ae134a930ff993
Author: Max Morin <maxmorin@chromium.org>
Date: Thu Apr 26 11:57:45 2018

Revert "DevTools: Support CPU profiles in OOPIFs"

This reverts commit 91d5ec53554dafd2ab13ad1908ba47b16842468f.

Reason for revert: Failing test,  crbug.com/832313 

Original change's description:
> DevTools: Support CPU profiles in OOPIFs
> 
> BUG= 832313 , 820250 
> 
> Change-Id: I53d730d4ff7e747eb0ccfe9a055738c1fe9858cf
> Reviewed-on: https://chromium-review.googlesource.com/1011350
> Commit-Queue: Alexei Filippov <alph@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553688}

TBR=dgozman@chromium.org,alph@chromium.org

Change-Id: I895c77652fdb343f9fa19735575173367f77ef44
No-Presubmit: true
No-Tree-Checks: true
Bug:  832313 ,  820250 
Reviewed-on: https://chromium-review.googlesource.com/1029973
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553987}
[delete] https://crrev.com/defcedc9d83d2e4dd9443c83a4191ace7445ed58/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-performance-cpu-profiles-expected.txt
[delete] https://crrev.com/defcedc9d83d2e4dd9443c83a4191ace7445ed58/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-performance-cpu-profiles.js
[modify] https://crrev.com/1cc61059c915c9b707a75671c5ae134a930ff993/third_party/blink/renderer/devtools/front_end/platform/utilities.js
[modify] https://crrev.com/1cc61059c915c9b707a75671c5ae134a930ff993/third_party/blink/renderer/devtools/front_end/sdk/TracingModel.js
[modify] https://crrev.com/1cc61059c915c9b707a75671c5ae134a930ff993/third_party/blink/renderer/devtools/front_end/timeline/TimelineController.js
[modify] https://crrev.com/1cc61059c915c9b707a75671c5ae134a930ff993/third_party/blink/renderer/devtools/front_end/timeline/TimelinePanel.js

Comment 5 by alph@chromium.org, Apr 26 2018

Labels: -Merge-Request-67
Project Member

Comment 6 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/250e7ef199a3aa19ed838120b9ab64c7b5fcfb55

commit 250e7ef199a3aa19ed838120b9ab64c7b5fcfb55
Author: Alexei Filippov <alph@chromium.org>
Date: Fri May 18 21:32:24 2018

Reland "DevTools: Support CPU profiles in OOPIFs"

This is a reland of 91d5ec53554dafd2ab13ad1908ba47b16842468f

Original change's description:
> DevTools: Support CPU profiles in OOPIFs
>
> BUG= 832313 , 820250 
>
> Change-Id: I53d730d4ff7e747eb0ccfe9a055738c1fe9858cf
> Reviewed-on: https://chromium-review.googlesource.com/1011350
> Commit-Queue: Alexei Filippov <alph@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553688}

TBR=dgozman

Bug:  832313 ,  820250 
Change-Id: I177e0d404b8efe595ddc680368b21c32160cd5de
Reviewed-on: https://chromium-review.googlesource.com/1065230
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560049}
[add] https://crrev.com/250e7ef199a3aa19ed838120b9ab64c7b5fcfb55/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-performance-cpu-profiles-expected.txt
[add] https://crrev.com/250e7ef199a3aa19ed838120b9ab64c7b5fcfb55/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-performance-cpu-profiles.js
[modify] https://crrev.com/250e7ef199a3aa19ed838120b9ab64c7b5fcfb55/third_party/blink/renderer/devtools/front_end/platform/utilities.js
[modify] https://crrev.com/250e7ef199a3aa19ed838120b9ab64c7b5fcfb55/third_party/blink/renderer/devtools/front_end/sdk/TracingModel.js
[modify] https://crrev.com/250e7ef199a3aa19ed838120b9ab64c7b5fcfb55/third_party/blink/renderer/devtools/front_end/timeline/TimelineController.js
[modify] https://crrev.com/250e7ef199a3aa19ed838120b9ab64c7b5fcfb55/third_party/blink/renderer/devtools/front_end/timeline/TimelinePanel.js

Project Member

Comment 7 by bugdroid1@chromium.org, May 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/420d63a70103a202b12702a7339cea79e8ca44b8

commit 420d63a70103a202b12702a7339cea79e8ca44b8
Author: calamity <calamity@chromium.org>
Date: Mon May 21 04:56:55 2018

Revert "Reland "DevTools: Support CPU profiles in OOPIFs""

This reverts commit 250e7ef199a3aa19ed838120b9ab64c7b5fcfb55.

Reason for revert: oopif-performance-cpu-profiles.js failing
consistently in:
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/7812

Original change's description:
> Reland "DevTools: Support CPU profiles in OOPIFs"
> 
> This is a reland of 91d5ec53554dafd2ab13ad1908ba47b16842468f
> 
> Original change's description:
> > DevTools: Support CPU profiles in OOPIFs
> >
> > BUG= 832313 , 820250 
> >
> > Change-Id: I53d730d4ff7e747eb0ccfe9a055738c1fe9858cf
> > Reviewed-on: https://chromium-review.googlesource.com/1011350
> > Commit-Queue: Alexei Filippov <alph@chromium.org>
> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#553688}
> 
> TBR=dgozman
> 
> Bug:  832313 ,  820250 
> Change-Id: I177e0d404b8efe595ddc680368b21c32160cd5de
> Reviewed-on: https://chromium-review.googlesource.com/1065230
> Commit-Queue: Alexei Filippov <alph@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560049}

TBR=dgozman@chromium.org,alph@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  832313 ,  820250 
Change-Id: Idf9a6925438105817159658fd8fa19ba00d1b530
Reviewed-on: https://chromium-review.googlesource.com/1065539
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560229}
[delete] https://crrev.com/c1f91311a28508c744db10dd4428f3eec0f6c712/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-performance-cpu-profiles-expected.txt
[delete] https://crrev.com/c1f91311a28508c744db10dd4428f3eec0f6c712/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-performance-cpu-profiles.js
[modify] https://crrev.com/420d63a70103a202b12702a7339cea79e8ca44b8/third_party/blink/renderer/devtools/front_end/platform/utilities.js
[modify] https://crrev.com/420d63a70103a202b12702a7339cea79e8ca44b8/third_party/blink/renderer/devtools/front_end/sdk/TracingModel.js
[modify] https://crrev.com/420d63a70103a202b12702a7339cea79e8ca44b8/third_party/blink/renderer/devtools/front_end/timeline/TimelineController.js
[modify] https://crrev.com/420d63a70103a202b12702a7339cea79e8ca44b8/third_party/blink/renderer/devtools/front_end/timeline/TimelinePanel.js

Components: Internals>Sandbox>SiteIsolation
Project Member

Comment 9 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0a2c26539a8a4e3a5352de72be82ade08fcdf24

commit d0a2c26539a8a4e3a5352de72be82ade08fcdf24
Author: Alexei Filippov <alph@chromium.org>
Date: Wed May 30 22:31:33 2018

Reland "Reland "DevTools: Support CPU profiles in OOPIFs""

This is a reland of 250e7ef199a3aa19ed838120b9ab64c7b5fcfb55

Original change's description:
> Reland "DevTools: Support CPU profiles in OOPIFs"
>
> This is a reland of 91d5ec53554dafd2ab13ad1908ba47b16842468f
>
> Original change's description:
> > DevTools: Support CPU profiles in OOPIFs
> >
> > BUG= 832313 , 820250 
> >
> > Change-Id: I53d730d4ff7e747eb0ccfe9a055738c1fe9858cf
> > Reviewed-on: https://chromium-review.googlesource.com/1011350
> > Commit-Queue: Alexei Filippov <alph@chromium.org>
> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#553688}
>
> TBR=dgozman
>
> Bug:  832313 ,  820250 
> Change-Id: I177e0d404b8efe595ddc680368b21c32160cd5de
> Reviewed-on: https://chromium-review.googlesource.com/1065230
> Commit-Queue: Alexei Filippov <alph@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560049}

TBR=dgozman

Bug:  832313 ,  820250 
Change-Id: I7eee078d51e23034ac8c08ce315949c4d78c7092
Reviewed-on: https://chromium-review.googlesource.com/1079729
Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563032}
[modify] https://crrev.com/d0a2c26539a8a4e3a5352de72be82ade08fcdf24/third_party/WebKit/LayoutTests/MSANExpectations
[add] https://crrev.com/d0a2c26539a8a4e3a5352de72be82ade08fcdf24/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-performance-cpu-profiles-expected.txt
[add] https://crrev.com/d0a2c26539a8a4e3a5352de72be82ade08fcdf24/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-performance-cpu-profiles.js
[modify] https://crrev.com/d0a2c26539a8a4e3a5352de72be82ade08fcdf24/third_party/blink/renderer/devtools/front_end/platform/utilities.js
[modify] https://crrev.com/d0a2c26539a8a4e3a5352de72be82ade08fcdf24/third_party/blink/renderer/devtools/front_end/sdk/TracingModel.js
[modify] https://crrev.com/d0a2c26539a8a4e3a5352de72be82ade08fcdf24/third_party/blink/renderer/devtools/front_end/timeline/TimelineController.js
[modify] https://crrev.com/d0a2c26539a8a4e3a5352de72be82ade08fcdf24/third_party/blink/renderer/devtools/front_end/timeline/TimelinePanel.js

Status: Fixed (was: Started)

Sign in to add a comment