New issue
Advanced search Search tips

Issue 832309 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Sign in to add a comment

Implement skylab inventory management tool

Project Member Reported by nxia@chromium.org, Apr 12 2018

Issue description

support atest with --skylab to manage skylab inventory repo.
 

Comment 1 by nxia@chromium.org, Apr 12 2018

Summary: Implement lab inventory management tool (was: Lab inventory management tool.)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/skylab_inventory/+/a6b021f33c87f328b3f3e02f9acf7e5c6aef198f

commit a6b021f33c87f328b3f3e02f9acf7e5c6aef198f
Author: Ningning Xia <nxia@google.com>
Date: Fri Apr 13 18:23:48 2018

Remove timestamp_pb2.py and change bin/check_proto_bindings

BUG= chromium:832309 
TEST=None

Change-Id: If5a325347dbf4bdbade90750ec2173b2a8a1bf91
Reviewed-on: https://chromium-review.googlesource.com/1012585
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[delete] https://crrev.com/ea67589cba431ce735fd44bfc9ce60854e0e77fd/venv/skylab_inventory/protos/timestamp_pb2.py
[modify] https://crrev.com/a6b021f33c87f328b3f3e02f9acf7e5c6aef198f/bin/check_proto_bindings

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/03f2bfdc3979f56aeb8dccced4af53514bd62574

commit 03f2bfdc3979f56aeb8dccced4af53514bd62574
Author: Ningning Xia <nxia@google.com>
Date: Fri Apr 13 20:48:09 2018

Comment 4 by nxia@chromium.org, May 19 2018

Blockedon: 832964

Comment 5 by nxia@chromium.org, May 19 2018

Blockedon: 840039

Comment 6 by nxia@chromium.org, May 19 2018

Blockedon: 842357

Comment 7 by nxia@chromium.org, May 19 2018

Blockedon: 842754

Comment 8 by nxia@chromium.org, May 19 2018

Blockedon: 842767

Comment 9 by nxia@chromium.org, May 19 2018

Blockedon: 826492

Comment 10 by nxia@chromium.org, May 23 2018

Blockedon: 846057
Components: Infra>Client>ChromeOS>Test
Summary: Implement skylab inventory management tool (was: Implement lab inventory management tool)

Comment 11 by nxia@chromium.org, Jun 1 2018

Blockedon: 846915

Comment 12 by nxia@chromium.org, Jun 1 2018

Blockedon: 848394
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ddc277e99c89057b7686a24dbe2956b40c4b19b2

commit ddc277e99c89057b7686a24dbe2956b40c4b19b2
Author: Ningning Xia <nxia@google.com>
Date: Tue Jun 05 00:23:25 2018

Raise an error if inventory-repo-dir is not clean.

Raise an exception when "atest server/host" is given an
inventory-repo-dir with local uncommitted changes.

BUG= chromium:832309 
TEST="atest server/host list"

Change-Id: I347153fa758a8dfab71661dd977c675fb24f5a7c
Reviewed-on: https://chromium-review.googlesource.com/1081667
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/ddc277e99c89057b7686a24dbe2956b40c4b19b2/cli/skylab_utils.py
[modify] https://crrev.com/ddc277e99c89057b7686a24dbe2956b40c4b19b2/cli/server.py

Project Member

Comment 14 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/69c2198ff0a1508005fdd3d863a36e2e154a7b4b

commit 69c2198ff0a1508005fdd3d863a36e2e154a7b4b
Author: Ningning Xia <nxia@chromium.org>
Date: Tue Jun 05 00:48:27 2018

Revert "Raise an error if inventory-repo-dir is not clean."

This reverts commit ddc277e99c89057b7686a24dbe2956b40c4b19b2.

Reason for revert: should only check git status for initialized repo

Original change's description:
> Raise an error if inventory-repo-dir is not clean.
> 
> Raise an exception when "atest server/host" is given an
> inventory-repo-dir with local uncommitted changes.
> 
> BUG= chromium:832309 
> TEST="atest server/host list"
> 
> Change-Id: I347153fa758a8dfab71661dd977c675fb24f5a7c
> Reviewed-on: https://chromium-review.googlesource.com/1081667
> Commit-Ready: Ningning Xia <nxia@chromium.org>
> Tested-by: Ningning Xia <nxia@chromium.org>
> Reviewed-by: Xixuan Wu <xixuan@chromium.org>

Bug:  chromium:832309 
Change-Id: I41656653dc2f9ff87604f9b3931c65a0b415154b
Reviewed-on: https://chromium-review.googlesource.com/1086387
Reviewed-by: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/69c2198ff0a1508005fdd3d863a36e2e154a7b4b/cli/skylab_utils.py
[modify] https://crrev.com/69c2198ff0a1508005fdd3d863a36e2e154a7b4b/cli/server.py

Project Member

Comment 15 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d23cf2f21b68a22b59692789bea808db222d2055

commit d23cf2f21b68a22b59692789bea808db222d2055
Author: Ningning Xia <nxia@google.com>
Date: Wed Jun 06 12:00:44 2018

Raise an error if inventory-repo-dir is not clean.

Raise an exception when "atest server/host" is given an
inventory-repo-dir with local uncommitted changes.

BUG= chromium:832309 
TEST="atest server/host list"

Change-Id: I085a29d4daf23ba2da68a65db854e33dd510b6c7
Reviewed-on: https://chromium-review.googlesource.com/1086378
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/d23cf2f21b68a22b59692789bea808db222d2055/cli/skylab_utils.py
[modify] https://crrev.com/d23cf2f21b68a22b59692789bea808db222d2055/cli/server.py

Project Member

Comment 16 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/38c18eb01f6935f16a80d5f536ec621b06047e0e

commit 38c18eb01f6935f16a80d5f536ec621b06047e0e
Author: Ningning Xia <nxia@google.com>
Date: Fri Jun 08 00:00:13 2018

Enforce --skylab for "atest server".

Enable --skylab by default for "atest server" and delete unused
list format options.

BUG= chromium:832309 
TEST="atest server commands"

Change-Id: I257add48ac2a13d81f25a385178739c01df2eb6f
Reviewed-on: https://chromium-review.googlesource.com/1087506
Reviewed-by: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/38c18eb01f6935f16a80d5f536ec621b06047e0e/cli/topic_common.py
[modify] https://crrev.com/38c18eb01f6935f16a80d5f536ec621b06047e0e/cli/skylab_utils.py
[modify] https://crrev.com/38c18eb01f6935f16a80d5f536ec621b06047e0e/cli/server.py
[modify] https://crrev.com/38c18eb01f6935f16a80d5f536ec621b06047e0e/site_utils/server_manager_utils.py

Cc: xixuan@chromium.org
Owner: ayatane@chromium.org
Status: Assigned (was: Untriaged)
Keeping to reland enforcing skylab
Blockedon: 845337
Project Member

Comment 19 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/44fbd139094a2f03ff828ad488bea00957c9609d

commit 44fbd139094a2f03ff828ad488bea00957c9609d
Author: Allen Li <ayatane@chromium.org>
Date: Tue Jun 12 20:52:30 2018

Revert "Enforce --skylab for "atest server"."

This reverts commit 38c18eb01f6935f16a80d5f536ec621b06047e0e.

Reason for revert: sysmon not fixed yet, broke in staging

Original change's description:
> Enforce --skylab for "atest server".
> 
> Enable --skylab by default for "atest server" and delete unused
> list format options.
> 
> BUG= chromium:832309 
> TEST="atest server commands"
> 
> Change-Id: I257add48ac2a13d81f25a385178739c01df2eb6f
> Reviewed-on: https://chromium-review.googlesource.com/1087506
> Reviewed-by: Ningning Xia <nxia@chromium.org>
> Tested-by: Ningning Xia <nxia@chromium.org>

Bug:  chromium:832309 
Change-Id: I28b70f08ca85c93c0cae33b909e918a7c007df49
Reviewed-on: https://chromium-review.googlesource.com/1097746
Reviewed-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/44fbd139094a2f03ff828ad488bea00957c9609d/cli/topic_common.py
[modify] https://crrev.com/44fbd139094a2f03ff828ad488bea00957c9609d/cli/skylab_utils.py
[modify] https://crrev.com/44fbd139094a2f03ff828ad488bea00957c9609d/cli/server.py
[modify] https://crrev.com/44fbd139094a2f03ff828ad488bea00957c9609d/site_utils/server_manager_utils.py

Project Member

Comment 20 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/skylab_inventory/+/5642a36311666338f27233adb562f8dacbae9e66

commit 5642a36311666338f27233adb562f8dacbae9e66
Author: Ningning Xia <nxia@google.com>
Date: Wed Jun 13 17:54:42 2018

Support updating host environment.

1) allow "atest host mod --skylab" to update host environment.
2) fix "atest host list --skylab" without hostnames.

BUG= chromium:832309 
TEST="atest host mod"; "atest host list"

Change-Id: I1c9b88c704495c30e4075f59b481659090f4ffb4
Reviewed-on: https://chromium-review.googlesource.com/1093457
Reviewed-by: Xixuan Wu <xixuan@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/5642a36311666338f27233adb562f8dacbae9e66/venv/skylab_inventory/lib/device.py

Project Member

Comment 21 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1dd82ee87a267763143b0ff331a3ef6909f1cd90

commit 1dd82ee87a267763143b0ff331a3ef6909f1cd90
Author: Ningning Xia <nxia@google.com>
Date: Wed Jun 13 17:55:17 2018

Support updating the host environment in skylab.

BUG= chromium:832309 
TEST="atest host mod --skylab"
CQ-DEPEND=CL:1093457

Change-Id: Ibde83af8dfbb47b878e418cbb38c051bb7437315
Reviewed-on: https://chromium-review.googlesource.com/1093535
Reviewed-by: Xixuan Wu <xixuan@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/1dd82ee87a267763143b0ff331a3ef6909f1cd90/cli/host.py

Project Member

Comment 22 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/75e3d34d86b0cfb8b944a28318c7275617c52859

commit 75e3d34d86b0cfb8b944a28318c7275617c52859
Author: Allen Li <ayatane@chromium.org>
Date: Tue Aug 07 08:50:51 2018

Reland "Enforce --skylab for "atest server"."

This reverts commit 44fbd139094a2f03ff828ad488bea00957c9609d.

Reason for revert: metrics are now using skylab inventory

Original change's description:
> Revert "Enforce --skylab for "atest server"."
>
> This reverts commit 38c18eb01f6935f16a80d5f536ec621b06047e0e.
>
> Reason for revert: sysmon not fixed yet, broke in staging
>
> Original change's description:
> > Enforce --skylab for "atest server".
> >
> > Enable --skylab by default for "atest server" and delete unused
> > list format options.
> >
> > BUG= chromium:832309 
> > TEST="atest server commands"
> >
> > Change-Id: I257add48ac2a13d81f25a385178739c01df2eb6f
> > Reviewed-on: https://chromium-review.googlesource.com/1087506
> > Reviewed-by: Ningning Xia <nxia@chromium.org>
> > Tested-by: Ningning Xia <nxia@chromium.org>
>
> Bug:  chromium:832309 
> Change-Id: I28b70f08ca85c93c0cae33b909e918a7c007df49
> Reviewed-on: https://chromium-review.googlesource.com/1097746
> Reviewed-by: Allen Li <ayatane@chromium.org>
> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
> Commit-Queue: Allen Li <ayatane@chromium.org>
> Tested-by: Allen Li <ayatane@chromium.org>

Bug:  chromium:832309 
Change-Id: I9042da968b78fd1c1c0fac08148e72b5086940f6
Reviewed-on: https://chromium-review.googlesource.com/1163965
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/75e3d34d86b0cfb8b944a28318c7275617c52859/cli/topic_common.py
[modify] https://crrev.com/75e3d34d86b0cfb8b944a28318c7275617c52859/cli/skylab_utils.py
[modify] https://crrev.com/75e3d34d86b0cfb8b944a28318c7275617c52859/cli/server.py
[modify] https://crrev.com/75e3d34d86b0cfb8b944a28318c7275617c52859/site_utils/server_manager_utils.py

Status: Fixed (was: Assigned)

Sign in to add a comment