New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 832307 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Tidy up the U-Boot ebuild

Project Member Reported by sjg@chromium.org, Apr 12 2018

Issue description

This has a lot of cruft in it from when U-Boot was the default boot loader. We should tidy it up and simplify it. Then we can actually use it to build vanilla U-Boot (without verified boot) for those who want to.
 

Comment 1 by sjg@chromium.org, Apr 12 2018

Owner: sjg@chromium.org
Status: Started (was: Untriaged)

Comment 2 by sjg@chromium.org, Apr 12 2018

Cc: rrangel@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9d8c1c593488c9fccfa3f23f94dd6e0fcd0b523a

commit 9d8c1c593488c9fccfa3f23f94dd6e0fcd0b523a
Author: Simon Glass <sjg@chromium.org>
Date: Thu Apr 19 00:35:25 2018

chromeos-u-boot: Drop special case for tegra

We don't build this anymore. Drop the special-case code.

BUG= chromium:832307 
TEST=./build_packages --board=puppy --nowithautotest

Change-Id: I25603033ce75cfef5201ffc8739a744d4fb9e2f5
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1012129
Reviewed-by: Raul E Rangel <rrangel@chromium.org>

[modify] https://crrev.com/9d8c1c593488c9fccfa3f23f94dd6e0fcd0b523a/sys-boot/chromeos-u-boot/chromeos-u-boot-9999.ebuild

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/316b5f0e742b858be25321d26716c60b7557e9de

commit 316b5f0e742b858be25321d26716c60b7557e9de
Author: Simon Glass <sjg@chromium.org>
Date: Thu Apr 19 00:35:26 2018

chromeos-u-boot: Drop special case for exynos

We don't build this anymore. Drop the special-case code.

BUG= chromium:832307 
TEST=./build_packages --board=peach_pit --nowithautotest

Change-Id: Iad79314e8809eec94c92382b44b9eb4801fc5da4
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1012130
Reviewed-by: Raul E Rangel <rrangel@chromium.org>

[modify] https://crrev.com/316b5f0e742b858be25321d26716c60b7557e9de/sys-boot/chromeos-u-boot/chromeos-u-boot-9999.ebuild

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/cadaa36e5924e1d76fe6a5ab12d7333fa09c1025

commit cadaa36e5924e1d76fe6a5ab12d7333fa09c1025
Author: Simon Glass <sjg@chromium.org>
Date: Sat Apr 21 06:01:30 2018

chromeos-u-boot: Drop special case for beaglebone

This U-Boot is not actually used for beaglebone. It still uses a
7-year-old version called u-boot-2013.07 in the beaglebone overlay. Drop
this unused code.

BUG= chromium:832307 
TEST=./build_packages --board=beaglebone --nowithautotest
See that it still completes OK

Change-Id: I1fb8ec9df1c4e5d0223e585a1c621479222ecdb3
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1012131
Reviewed-by: Raul E Rangel <rrangel@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/cadaa36e5924e1d76fe6a5ab12d7333fa09c1025/sys-boot/chromeos-u-boot/chromeos-u-boot-9999.ebuild

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/dc51cbbd3ccb1749e4715e4a5b585e1ad073869e

commit dc51cbbd3ccb1749e4715e4a5b585e1ad073869e
Author: Simon Glass <sjg@chromium.org>
Date: Mon Apr 23 22:36:40 2018

chromeos-u-boot: Convert to use master config for build targets

Firmware build targets are defined by the master configuration now. Update
the ebuild to use this, and drop the old code.

BUG= chromium:832307 
TEST=with other changes, emerge-grunt chromeos-u-boot
See that it builds the right target

Change-Id: If6d4d45ef1bd1ecf5f82b0f1ebcbdde3f7c0c766
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1012132
Reviewed-by: Raul E Rangel <rrangel@chromium.org>

[modify] https://crrev.com/dc51cbbd3ccb1749e4715e4a5b585e1ad073869e/sys-boot/chromeos-u-boot/chromeos-u-boot-9999.ebuild

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/df49334636c9690a632662f4d2ef3338c6c1173d

commit df49334636c9690a632662f4d2ef3338c6c1173d
Author: Simon Glass <sjg@chromium.org>
Date: Tue Apr 24 15:39:38 2018

chromeos-u-boot: Drop old netboot and profiling targets

We don't need these now. We will always build in netboot functionality,
and don't need to worry about profiling vboot anymore.

BUG= chromium:832307 
TEST=with other changes, emerge-grunt chromeos-u-boot
See that it builds OK

Change-Id: I17b8e91de53178b34fa351aa4605511296a48de9
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1024482
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/df49334636c9690a632662f4d2ef3338c6c1173d/sys-boot/chromeos-u-boot/chromeos-u-boot-9999.ebuild

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/df8a69f7e12816618cb093c15613fa121948f9bb

commit df8a69f7e12816618cb093c15613fa121948f9bb
Author: Simon Glass <sjg@chromium.org>
Date: Tue Apr 24 15:39:39 2018

chromeos-u-boot: Tidy up unused USE flags, deps, vars, etc.

None of this is used. Drop it.

BUG= chromium:832307 
TEST=with other changes, emerge-grunt chromeos-u-boot
See that it builds OK

Change-Id: I7643b93eb786af98914507b94e2d70c61a579088
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1024483
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/df8a69f7e12816618cb093c15613fa121948f9bb/sys-boot/chromeos-u-boot/chromeos-u-boot-9999.ebuild

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ec213fbe200795f8d7801e8774f8a81c144eddc1

commit ec213fbe200795f8d7801e8774f8a81c144eddc1
Author: Simon Glass <sjg@chromium.org>
Date: Tue Apr 24 20:31:28 2018

chromeos-config: Support U-Boot as a firmware build target

In some cases it is useful to add U-Boot to a build image. It has a
command line which is useful for testing and a full feature set compared
to depthcharge.

BUG= chromium:832307 
TEST=with other changes, emerge-grunt u-boot; see that it builds OK

Change-Id: I044ed4b5f097ae168611c0ab5af9522511663e98
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1014709

[modify] https://crrev.com/ec213fbe200795f8d7801e8774f8a81c144eddc1/chromeos-config/README.md
[modify] https://crrev.com/ec213fbe200795f8d7801e8774f8a81c144eddc1/chromeos-config/libcros_config/test.yaml
[modify] https://crrev.com/ec213fbe200795f8d7801e8774f8a81c144eddc1/chromeos-config/cros_config_host/cros_config_schema.yaml
[modify] https://crrev.com/ec213fbe200795f8d7801e8774f8a81c144eddc1/chromeos-config/libcros_config/test_build.json
[modify] https://crrev.com/ec213fbe200795f8d7801e8774f8a81c144eddc1/chromeos-config/cros_config_host/validate_config.py

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e4d47db501d3ebf8a942a630922a7b9c8c7514b9

commit e4d47db501d3ebf8a942a630922a7b9c8c7514b9
Author: Simon Glass <sjg@chromium.org>
Date: Wed Apr 25 01:53:08 2018

chromeos-u-boot: Make verified boot optional

It is useful to be able to build U-Boot without verified-boot support,
particularly when including it in a ROM where we have that already.

BUG= chromium:832307 
TEST=with other changes, emerge-grunt chromeos-u-boot
See that it builds OK
No test for vboot at present

Change-Id: Ic0571a75c62331da668bef784f116c2c2c3a0b8f
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1024484
Reviewed-by: Raul E Rangel <rrangel@chromium.org>

[modify] https://crrev.com/e4d47db501d3ebf8a942a630922a7b9c8c7514b9/sys-boot/chromeos-u-boot/chromeos-u-boot-9999.ebuild

Comment 11 by sjg@chromium.org, Apr 25 2018

Status: Fixed (was: Started)
This is looking good now

Sign in to add a comment