New issue
Advanced search Search tips

Issue 832292 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Remove the servo dependency from AU tests that suspend/resume

Project Member Reported by dhadd...@chromium.org, Apr 12 2018

Issue description

Currently we make use of the lid_close servo call to suspend resume during the interruptions AU test. 

This is known to be:
1. Flaky
2. Fail on boards without a lid
3. Fail on some boards which don't support it.

I will update the test to just do a regular suspend with powerd



 
On the most recent run I count 4 unique failure reasons related to servo:

1. retry exception (function="ready_test()"), timeout = 60s
2. Check ribbon cable: 'pwr_button' is stuck
3. Setting 'lid_open' to 'no' :: Map na doesn't contain key no
4. servod not running on chromeos6-row1-rack18-labstation port 9995
Cc: abod...@chromium.org mkarkada@chromium.org sdantul...@chromium.org ahass...@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/afde7657e3d4c2f55440e051ce325a01337e650f

commit afde7657e3d4c2f55440e051ce325a01337e650f
Author: David Haddock <dhaddock@chromium.org>
Date: Sat Apr 14 04:37:39 2018

Remove dependency on servo for suspend/resume in AU tests.

We currently use servo's lid_close to suspend in the AU tests. This will
not work on chromebases, as well as some chromebooks that dont support
it.

This CL changes it to use powerd which is supported by all chrome
devices.

I've also reduced the max pecentage to interrupt the update to 70%
(down from 80%) as the update was sometimes finishing before the
interruptions :)

BUG= chromium:832292 
TEST=autoupdate_ForcedOOBEUpdate.interrupt.full

Change-Id: I1900712bd75bc2173ff70579258bfd348c136fb2
Reviewed-on: https://chromium-review.googlesource.com/1012988
Commit-Ready: David Haddock <dhaddock@chromium.org>
Tested-by: David Haddock <dhaddock@chromium.org>
Reviewed-by: Kalin Stoyanov <kalin@chromium.org>

[modify] https://crrev.com/afde7657e3d4c2f55440e051ce325a01337e650f/server/site_tests/autoupdate_ForcedOOBEUpdate/control.interrupt.full
[modify] https://crrev.com/afde7657e3d4c2f55440e051ce325a01337e650f/server/site_tests/autoupdate_ForcedOOBEUpdate/autoupdate_ForcedOOBEUpdate.py

Status: Fixed (was: Assigned)

Sign in to add a comment