"cit cros_pin update master" fails for some users
Reported by
jrbarnette@chromium.org,
Apr 12 2018
|
|||||||||||
Issue description
While trying to address issue 831408, I ran up against this error
when running "cit cros_pin update master":
Traceback (most recent call last):
File "/usr/local/google/home/jrbarnette/.chrome-infra/infra/run.py", line 29, in <module>
sys.exit(run_helper.run_py_main(sys.argv[1:], RUNPY_PATH, ENV_PATH, 'infra'))
File "/usr/local/google/home/jrbarnette/.chrome-infra/infra/bootstrap/run_helper.py", line 123, in run_py_main
runpy.run_module(args[0], run_name='__main__', alter_sys=True)
File "/usr/lib/python2.7/runpy.py", line 188, in run_module
fname, loader, pkg_name)
File "/usr/lib/python2.7/runpy.py", line 82, in _run_module_code
mod_name, mod_fname, mod_loader, pkg_name)
File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
exec code in run_globals
File "/usr/local/google/home/jrbarnette/.chrome-infra/infra/infra/tools/cros_pin/__main__.py", line 32, in <module>
sys.exit(main(sys.argv[1:]))
File "/usr/local/google/home/jrbarnette/.chrome-infra/infra/infra/tools/cros_pin/__main__.py", line 28, in main
return args.func(args)
File "/usr/local/google/home/jrbarnette/.chrome-infra/infra/infra/tools/cros_pin/cros_pin.py", line 156, in subcommand_update
tracker.update()
File "/usr/local/google/home/jrbarnette/.chrome-infra/infra/infra/tools/cros_pin/cros_pin.py", line 281, in update
self._generate_commit_message(updates))
File "/usr/local/google/home/jrbarnette/.chrome-infra/infra/infra/tools/cros_pin/cros_pin.py", line 339, in _upload_patch
output = execute.check_call(args, cwd=repo_path, dry_run=self._dry_run)
File "/usr/local/google/home/jrbarnette/.chrome-infra/infra/infra/tools/cros_pin/execute.py", line 35, in check_call
raise subprocess.CalledProcessError(rv, cmd, None)
subprocess.CalledProcessError: Command '['git', 'cl', 'upload', '--bypass-hooks', '--send-mail', '--message-file', '/tmp/tmps54CZg', '-f', '--use-commit-queue', '--tbr-owners']' returned non-zero exit status 1
The CL is uploaded, but apparently I don't have permission to submit
the CL automatically. I should.
,
Apr 12 2018
I should add: some CrOS Infra team members report being able to do this without trouble. Others can't.
,
Apr 13 2018
,
Apr 17 2018
,
Apr 18 2018
-> assign to dnj@ as you worked on cros_pin recently.
,
Apr 26 2018
If my case is like the others, the true problem is that some of Cros Infra don't have Code Review rights on Chrome CLs. (See also crrev.com/i/615088, where this came up.)
,
Apr 26 2018
,
Apr 27 2018
-> estaab@ is there an owner of cit cros_pin, or somebody who can help resolve the various permissions issues? People on my team keep running into this, and it is not clear which ACL lists they are missing from.
,
Apr 27 2018
I don't think anyone knows how this works besides Dan unless someone on Chrome OS infra already does. Is the problem just that there aren't enough infra committers on the team or something else?
,
Apr 27 2018
I think it's is probably a group membership or committers issue, but I don't understand/have dug into the various membership rules enough to know.
,
Apr 27 2018
Re #9: "Is the problem just that there aren't enough infra committers on the team or something else?" The whole team should be Chrome infra committers, because we all take shifts in the deputy rotation and some of the deputy's routine duties require committer permissions.
,
May 11 2018
Someone on ChromeOS infra will need to take ownership of cit cros_pin and figure out what permissions need to be granted. I can help with granting those permissions after it's determined so please assign back to me when you have that info.
,
May 12 2018
Why was this removed from dnj?
,
May 14 2018
,
May 29 2018
Just went through having new CI team members do this for the past 2 weeks and everything seems to be set up correctly for the wider team. Closing this for now. |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by jrbarnette@chromium.org
, Apr 12 2018