New issue
Advanced search Search tips

Issue 832255 link

Starred by 1 user
Status: WontFix
Owner:
beccahughes@chromium.org
Closed: Jul 30
Cc:
beccahughes@chromium.org
chcunningham@chromium.org
mlamouri@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression


Participants' hotlists:
Modern-Media-Controls


Sign in to add a comment

28.4%-189% regression in media.desktop at 549673:549767

Project Member Reported by chcunningham@chromium.org, Apr 12 2018 
All appear to be a return to previous values from a few days back. Ref graph held steady. Perhaps something was reverted.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Apr 12 2018 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=832255

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=42cfa33b3411d77ca15c86f3f7514fd23946c73ae497f20c070023c764dab9f5


Bot(s) for this bug's original alert(s):

chromium-rel-mac11-pro
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Apr 12 2018

Cc: beccahughes@chromium.org mlamouri@chromium.org
Owner: beccahughes@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14d0884ac40000

Media Controls: Fix scrim not showing up by beccahughes@chromium.org
https://chromium.googlesource.com/chromium/src/+/5632d9ab33eacb3baedb033f2d24230d10288198

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 4 by beccahughes@chromium.org, May 2 2018

Owner: ----

Comment 5 by chcunningham@chromium.org, Jul 27

Cc: -beccahughes@chromium.org
Owner: beccahughes@chromium.org
beccahuges@, can you give some context for un-assigning?

Is it simply that we saw a performance improvement when media controls didn't show up and fixing the issue regressed (restored) perf metrics?

Comment 6 by chcunningham@chromium.org, Jul 27

Cc: beccahughes@chromium.org
 Issue 832253  has been merged into this issue.

Comment 7 by beccahughes@chromium.org, Jul 30

Status: WontFix (was: Assigned)
@chcunningham - hey sorry, I unassigned it by accident.

Yes there was a bug when we were not showing the images on high DPI devices so the fix caused a performance regression which is actually restoring the metrics back to normal.
►

Sign in to add a comment