New issue
Advanced search Search tips

Issue 832246 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Bad-cast to blink::LayoutBlock from blink::LayoutText in blink::ToLayoutBlock

Project Member Reported by ClusterFuzz, Apr 12 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5214266685390848

Fuzzer: bj_broddelwerk
Job Type: linux_cfi_chrome
Platform Id: linux

Crash Type: Bad-cast
Crash Address: 0x55f883735240
Crash State:
  Bad-cast to blink::LayoutBlock from blink::LayoutText
  blink::ToLayoutBlock
  blink::TextOffsetMapping::ComputeContainigBlock
  
Sanitizer: cfi (CFI)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_cfi_chrome&range=550071:550107

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5214266685390848

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Apr 13 2018

Labels: M-67
Project Member

Comment 2 by sheriffbot@chromium.org, Apr 13 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 13 2018

Labels: Pri-1
Components: Blink
Owner: nikunjb@chromium.org
Status: Assigned (was: Untriaged)
nikunjb: It looks like crrev.com/c/963843 has a change in visible_units_word.cc, which might be related, can you take a look? Thanks.
Components: -Blink Blink>Editing Blink>Layout
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 18 2018

Labels: -Security_Impact-Head Security_Impact-Beta

Comment 7 by vakh@chromium.org, Apr 23 2018

Cc: yoichio@chromium.org nikunjb@chromium.org xiaoche...@chromium.org
Components: Blink>Editing>Selection
Owner: yosin@chromium.org
It looks like the culprit CL might be: https://chromium-review.googlesource.com/c/chromium/src/+/1004536

Assigning owner on the basis of that.

Comment 8 by gov...@chromium.org, Apr 25 2018

M67 Stable promotion is coming soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.


Comment 9 by yosin@chromium.org, Apr 26 2018

Labels: -M-67 M-68
Change ReleaseBlock to M68 because the patch caused by this bug is reverted on M67 branch http://crrev.com/c/1013445
Status: Started (was: Assigned)

Comment 11 by yosin@chromium.org, May 10 2018

Status: Fixed (was: Started)
http://crrev.com/c/1018923 should fix this issue.
Project Member

Comment 12 by ClusterFuzz, May 10 2018

ClusterFuzz has detected this issue as fixed in range 557391:557426.

Detailed report: https://clusterfuzz.com/testcase?key=5214266685390848

Fuzzer: bj_broddelwerk
Job Type: linux_cfi_chrome
Platform Id: linux

Crash Type: Bad-cast
Crash Address: 0x55f883735240
Crash State:
  Bad-cast to blink::LayoutBlock from blink::LayoutText
  blink::ToLayoutBlock
  blink::TextOffsetMapping::ComputeContainigBlock
  
Sanitizer: cfi (CFI)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_cfi_chrome&range=550071:550107
Fixed: https://clusterfuzz.com/revisions?job=linux_cfi_chrome&range=557391:557426

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5214266685390848

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 13 by ClusterFuzz, May 10 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5214266685390848 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 14 by sheriffbot@chromium.org, May 10 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Stable
Project Member

Comment 16 by sheriffbot@chromium.org, Jun 8 2018

Labels: Merge-Request-68
Project Member

Comment 17 by sheriffbot@chromium.org, Jun 8 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-68
no merge needed
Project Member

Comment 19 by sheriffbot@chromium.org, Aug 16

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment