Issue metadata
Sign in to add a comment
|
[MacViews-Browser] Edit-text & Cut-button overlap each other in the Settings Menu |
||||||||||||||||||||||
Issue descriptionChrome Version: Canary 67.0.3395.0 OS: macOS 10.12.6 What steps will reproduce the problem? (1) Enable MacViews-Browser (2) Use Chrome in language DE (3) Click on the Settings Button, so that the Menu appears What is the expected result? They should not overlap. What happens instead? Edit-text & Cut-button overlap each other. A screenshot is attached. Thanks Mehmet
,
Apr 13 2018
Ah, hm. We need a more adaptive behavior than just "320pt width always", or we need to rework the design of that menu section. Over to bettes@ for UX guidance.
,
Apr 13 2018
,
Apr 20 2018
This UI has unique properties given it's size and content so I think the Harmony-style "width snapping" might be too aggressive here. Can you provide screenshots of how "320 as a minimum but allow menus to be wider" implementation would look like for locales like German?
,
Apr 23 2018
#4: Sure - I'll prototype today or tomorrow and post here.
,
Apr 24 2018
The NextAction date has arrived: 2018-04-24
,
Apr 24 2018
Screenshots attached for <https://chromium-review.googlesource.com/c/chromium/src/+/1026052>: "english" is with en-US strings. "german" is with de-DE strings. "mangled" is with en-US strings and --mangle-localized-strings, to show that no strings are truncated/overlapping/etc.
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce874203d5aea46192d31408e064d88b42e75bb0 commit ce874203d5aea46192d31408e064d88b42e75bb0 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Apr 25 16:02:11 2018 macviews: change menu widths from fixed to minimums Fixed menu widths turned out not to work well in locales with longer strings. This change changes the menu widths to be minimums instead. See screenshots attached to the bug for examples. Bug: 832239 Change-Id: I4cae9efb53b86b08c4cd8b56d4eb089446e872d9 Reviewed-on: https://chromium-review.googlesource.com/1026052 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#553584} [modify] https://crrev.com/ce874203d5aea46192d31408e064d88b42e75bb0/ui/views/controls/menu/menu_config.cc [modify] https://crrev.com/ce874203d5aea46192d31408e064d88b42e75bb0/ui/views/controls/menu/menu_config.h [modify] https://crrev.com/ce874203d5aea46192d31408e064d88b42e75bb0/ui/views/controls/menu/menu_config_mac.mm [modify] https://crrev.com/ce874203d5aea46192d31408e064d88b42e75bb0/ui/views/controls/menu/menu_item_view.cc [modify] https://crrev.com/ce874203d5aea46192d31408e064d88b42e75bb0/ui/views/controls/menu/menu_item_view.h [modify] https://crrev.com/ce874203d5aea46192d31408e064d88b42e75bb0/ui/views/controls/menu/menu_item_view_unittest.cc
,
Apr 25 2018
,
May 4 2018
Able to reproduce this issue on build without fix hence verifying on latest canary 68.0.3419.0 using Mac 10.12.6. No overlapping is seen near Edit-text & Cut-button in wrench menu when opened browser in language 'de'. Attaching screenshot for reference. As fix is working as expected. Adding Verified labels. Thanks! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by meh...@chromium.org
, Apr 12 2018