New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 832238 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 696345
issue 818383

Blocking:
issue 662644


Participants' hotlists:
webgl-conformance-all


Sign in to add a comment

conformance2/transform_feedback/switching-objects.html and too-small-buffers.html are Flaky

Project Member Reported by ccameron@chromium.org, Apr 12 2018

Issue description

The following failure is happening on the following bots:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20FYI%20Release%20%28AMD%20R7%20240%29
https://ci.chromium.org/buildbot/chromium.gpu.fyi/Win10%20FYI%20Release%20%28NVIDIA%29/

On the first of those bots, the blamelist is at
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20FYI%20Release%20%28AMD%20R7%20240%29/497

Which includes the r550025: Transform feedback fixes are in, remove test failure expectations.

I suspect we need a couple more suppressions here.

jdarpinian@ could you take a look?
 
I think these have already been suppressed https://chromium-review.googlesource.com/c/chromium/src/+/1010520

I am taking a look at this and a couple of other failures.
Looks like there are two test failures. too-small-buffers is flaky with the ANGLE GL backend on Windows:

https://ci.chromium.org/buildbot/chromium.gpu.fyi/Win10%20FYI%20Release%20%28NVIDIA%29/741

And switching-objects fails consistently on Linux AMD with an error on glPauseTransformFeedback:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20FYI%20Release%20%28AMD%20R7%20240%29/501

Given that we don't ship the ANGLE GL backend on Windows, and the AMD issue seems low severity, I will treat this as low priority and leave the tests disabled for now.

Comment 3 by kbr@chromium.org, Apr 12 2018

Blockedon: 696345
Oh, there was also a flake on Linux Nvidia with the ANGLE GL backend:

https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_angle_rel_ng/556

https://chromium-review.googlesource.com/1010770 didn't cover Win non-passthrough failure. Going to update the expectation again.
Summary: conformance2/transform_feedback/switching-objects.html and too-small-buffers.html are Flaky (was: WebglConformance_conformance2_transform_feedback_switching_objects failing on two bots)
Essentially, these two tests are going to be marked Flaky everywhere.
I haven't seen flakes for Win non-passthrough, can you provide a link?
Actually, https://ci.chromium.org/buildbot/chromium.gpu.fyi/Win10%20FYI%20Release%20%28NVIDIA%29/741 you've mentioned in #2 was also non-passthrough
Oh I see, OpenGL with no-passthrough. The tests should still be running and not flaky on the D3D backend that we actually ship, so that's OK.
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a9ab1ca2dddb874b3f60ded07c701204ed1e373

commit 7a9ab1ca2dddb874b3f60ded07c701204ed1e373
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Fri Apr 13 04:16:01 2018

Mark one WebGL2 test Flaky

conformance2/transform_feedback/too-small-buffers.html
on Win NVIDIA OpenGL no_passthrough

BUG=832238
TBR=kbr@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie44d23e20053e06e7c355b2b20609a37b3d049ba
Reviewed-on: https://chromium-review.googlesource.com/1011597
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550510}
[modify] https://crrev.com/7a9ab1ca2dddb874b3f60ded07c701204ed1e373/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Project Member

Comment 12 by bugdroid1@chromium.org, Apr 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f9e79de613ec2daf5adf9791cb7823136d77bba

commit 6f9e79de613ec2daf5adf9791cb7823136d77bba
Author: Kenneth Russell <kbr@chromium.org>
Date: Sat Apr 14 00:39:06 2018

Strengthen verify_all_expectations_unittest.

Also test Windows, ANGLE, OpenGL backend, validating command decoder
(which is on the waterfall).

Tbr: jdarpinian@chromium.org
Bug: 832238
Change-Id: Ied1e0cb16d1d220f19a5562c82a1167cfa042fda
Reviewed-on: https://chromium-review.googlesource.com/1013090
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550833}
[modify] https://crrev.com/6f9e79de613ec2daf5adf9791cb7823136d77bba/content/test/gpu/gpu_tests/verify_all_expectations_unittest.py

Project Member

Comment 13 by bugdroid1@chromium.org, Apr 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2758a80cac1658c2463c86284783c0c20024805

commit d2758a80cac1658c2463c86284783c0c20024805
Author: James Darpinian <jdarpinian@chromium.org>
Date: Sat Apr 14 00:45:33 2018

One more transform feedback test suppression.

Mark:
  conformance2/transform_feedback/switching-objects.html
  conformance2/transform_feedback/too-small-buffers.html
flaky on Windows Nvidia OpenGL non-passthrough.

Bug: 832238
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Icade6b90feaa3691998c71c88ecc44e842794539
Reviewed-on: https://chromium-review.googlesource.com/1012928
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550835}
[modify] https://crrev.com/d2758a80cac1658c2463c86284783c0c20024805/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Project Member

Comment 14 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d7ee08a37f5b411cade70bb546c7d38a9f8da4b

commit 5d7ee08a37f5b411cade70bb546c7d38a9f8da4b
Author: Jamie Madill <jmadill@chromium.org>
Date: Tue Apr 17 13:53:55 2018

Upgrade XFB failing expectation.

This flaky expectation for "too-small-buffers" was not sufficient
to prevent try jobs from failing. Upgrade it to "Fail" so it will
prevent flaky retries.

Examples:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20Release%20%28NVIDIA%29/182
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20Release%20%28NVIDIA%29/181

Bug: 832238
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I646cb3815d93c11f3cb39d1e919f7db2283e4ba5
Tbr: kbr@chromium.org
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/1014734
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551312}
[modify] https://crrev.com/5d7ee08a37f5b411cade70bb546c7d38a9f8da4b/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Project Member

Comment 15 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a9ab1ca2dddb874b3f60ded07c701204ed1e373

commit 7a9ab1ca2dddb874b3f60ded07c701204ed1e373
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Fri Apr 13 04:16:01 2018

Mark one WebGL2 test Flaky

conformance2/transform_feedback/too-small-buffers.html
on Win NVIDIA OpenGL no_passthrough

BUG=832238
TBR=kbr@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie44d23e20053e06e7c355b2b20609a37b3d049ba
Reviewed-on: https://chromium-review.googlesource.com/1011597
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550510}
[modify] https://crrev.com/7a9ab1ca2dddb874b3f60ded07c701204ed1e373/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Project Member

Comment 16 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f9e79de613ec2daf5adf9791cb7823136d77bba

commit 6f9e79de613ec2daf5adf9791cb7823136d77bba
Author: Kenneth Russell <kbr@chromium.org>
Date: Sat Apr 14 00:39:06 2018

Strengthen verify_all_expectations_unittest.

Also test Windows, ANGLE, OpenGL backend, validating command decoder
(which is on the waterfall).

Tbr: jdarpinian@chromium.org
Bug: 832238
Change-Id: Ied1e0cb16d1d220f19a5562c82a1167cfa042fda
Reviewed-on: https://chromium-review.googlesource.com/1013090
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550833}
[modify] https://crrev.com/6f9e79de613ec2daf5adf9791cb7823136d77bba/content/test/gpu/gpu_tests/verify_all_expectations_unittest.py

Project Member

Comment 17 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2758a80cac1658c2463c86284783c0c20024805

commit d2758a80cac1658c2463c86284783c0c20024805
Author: James Darpinian <jdarpinian@chromium.org>
Date: Sat Apr 14 00:45:33 2018

One more transform feedback test suppression.

Mark:
  conformance2/transform_feedback/switching-objects.html
  conformance2/transform_feedback/too-small-buffers.html
flaky on Windows Nvidia OpenGL non-passthrough.

Bug: 832238
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Icade6b90feaa3691998c71c88ecc44e842794539
Reviewed-on: https://chromium-review.googlesource.com/1012928
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550835}
[modify] https://crrev.com/d2758a80cac1658c2463c86284783c0c20024805/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Project Member

Comment 18 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c27837e44eca9080b40187feaa30cb15bbba6c55

commit c27837e44eca9080b40187feaa30cb15bbba6c55
Author: Jamie Madill <jmadill@chromium.org>
Date: Fri Apr 20 13:41:45 2018

Broaden WebGL XFB Flaky expectation.

This seems to flake on Linux, Windows and Mac across multiple GPUs.
Broaden the expectation to encompass any OpenGL configuration.

Bug: 832238
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I76b2250d542c19279912b21040f7ed2894a21533
Tbr: kbr@chromium.org
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/1021795
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552317}
[modify] https://crrev.com/c27837e44eca9080b40187feaa30cb15bbba6c55/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

A weird thing, I got WebglConformance_conformance2_transform_feedback_too_small_buffers failing in https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_optional_gpu_tests_rel/1898, which is based on revision 552356, so it should include CL #18 from revision 552317, which should mark the test Flaky on all GL.
Oh, got it, the CL in #18 changed the expectation from Fail to Flaky.
Project Member

Comment 21 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f244d572c394aeeb0ce3203a75410ff640f938c

commit 1f244d572c394aeeb0ce3203a75410ff640f938c
Author: Jamie Madill <jmadill@chromium.org>
Date: Fri Apr 20 17:37:00 2018

Upgrade WebGL XFB flaky test to failing.

This test is too flaky to be marked flaky, it should be marked as
fail to avoid failing tests.

Bug: 832238
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I57f1e398d86eace64c731a578edc75d30a6eae01
Tbr: kbr@chromium.org
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/1022171
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552372}
[modify] https://crrev.com/1f244d572c394aeeb0ce3203a75410ff640f938c/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Comment 22 by piman@chromium.org, Apr 20 2018

Cc: jmad...@chromium.org piman@chromium.org
 Issue 835389  has been merged into this issue.
Project Member

Comment 23 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb5c1e0cf189753dd8993e82b02fcd21163fd32d

commit bb5c1e0cf189753dd8993e82b02fcd21163fd32d
Author: Jamie Madill <jmadill@chromium.org>
Date: Fri Apr 20 21:31:44 2018

Expand WebGL 2 XFB test expectation again.

It seems 'opengl' does not cover Mac configurations. Rephrase the
expectation.

Bug: 832238
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I493a86bc9c1c594f64fae6de6b11adbde4b33007
Tbr: kbr@chromium.org
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/1022731
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552478}
[modify] https://crrev.com/bb5c1e0cf189753dd8993e82b02fcd21163fd32d/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Comment 24 by kbr@chromium.org, Apr 28 2018

Cc: kbr@chromium.org
 Issue 835587  has been merged into this issue.

Comment 25 by kbr@chromium.org, Apr 28 2018

Blockedon: 818383
Components: Blink>WebGL
Labels: -Pri-3 Pri-2
Linking to  Issue 818383  in which the too-small-buffers.html test was added.

Upgrading to P2 because since it's concerning that this test is flaky on so many configurations. It might indicate bugs in ANGLE, or bugs in drivers that should be reported. See  Issue 835587 .

Blocking: 662644
Labels: webgl-conformance
Labels: GPU-AMD GPU-NVidia
Project Member

Comment 29 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12b45fcf5c2627a4ee64cadf4fba6b8cebf918bf

commit 12b45fcf5c2627a4ee64cadf4fba6b8cebf918bf
Author: James Darpinian <jdarpinian@chromium.org>
Date: Wed Dec 19 01:53:23 2018

Suppress WebGL test flake

conformance2/transform_feedback/switching-objects.html is already marked
as flaky on many platforms. I just had a failure on Linux Nvidia as
well:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_angle_rel_ng/4689

Bug: 832238
TBR: kbr@chromium.org
Change-Id: Idc408d3bb2bb341a3274012d91d82b0f6759c943
Reviewed-on: https://chromium-review.googlesource.com/c/1382507
Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617707}
[modify] https://crrev.com/12b45fcf5c2627a4ee64cadf4fba6b8cebf918bf/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Sign in to add a comment