UseCounter counting usage of CSS properties and HTML features on inspector overlay pages |
||
Issue descriptionWhen loading a page, open the inspector, some CSS properties are observed to be recorded (usage could even be > total pages visited). This is because inspector create overlay page that never committed. UseCounter filters out unwanted pages during loadcommit, which missed the inspector pages. As a result, incorrect usage is counted.
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74cd94454630db0f3cee6eb5b3f5fd6aeef80aea commit 74cd94454630db0f3cee6eb5b3f5fd6aeef80aea Author: Luna Lu <loonybear@chromium.org> Date: Wed May 23 19:35:28 2018 UseCounter only accept ordinary pages to avoid counting features from inspector overly pages Inspector overlay pages has a UseCounter associated with them and record usage on the page. This CL adds a check for ordinary pages to prevent overlay pages from recording UseCounter usage. Bug: 832236 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I99db8e45576556566bf79ac75c7f77ee78ce941e Reviewed-on: https://chromium-review.googlesource.com/1011245 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#561205} [modify] https://crrev.com/74cd94454630db0f3cee6eb5b3f5fd6aeef80aea/third_party/WebKit/LayoutTests/http/tests/devtools/layers/no-overlay-layers.js [modify] https://crrev.com/74cd94454630db0f3cee6eb5b3f5fd6aeef80aea/third_party/blink/renderer/core/frame/use_counter.cc [modify] https://crrev.com/74cd94454630db0f3cee6eb5b3f5fd6aeef80aea/third_party/blink/renderer/core/frame/use_counter_test.cc [modify] https://crrev.com/74cd94454630db0f3cee6eb5b3f5fd6aeef80aea/third_party/blink/renderer/core/testing/dummy_page_holder.cc
,
May 31 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by iclell...@chromium.org
, May 3 2018