New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 832234 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Restrict user navigation / exit unload flow to 500ms

Project Member Reported by panicker@chromium.org, Apr 12 2018

Issue description

Currently we have 1s limit on end-of-life handlers when the user navigates or closes a tab (pagevisibility, pagehide, unload, beforeunload) 
But it's 2s in practice due to bugs.
We should restrict this to 500ms - which accommodates (sum of handlers) at 99.9th%ile

UMA for duration of handlers on Windows stable (in milliseconds)
90th %ile: 
unload: .002; beforeunload: 0.28; pagehide: 0.004ms; vibilityhidden: 0.008

95th
unload: .021; beforeunload: 1.4; pagehide: 0.006ms; vibilityhidden: 0.04

99th
unload: 3.8; beforeunload: 14.3; pagehide: 0.75ms; vibilityhidden: 1

99.9th
unload: 53; beforeunload: 272; pagehide: 5.3ms; vibilityhidden: 5.3

 

Comment 1 by creis@chromium.org, Jun 14 2018

Components: UI>Browser>Navigation
Cc: panicker@chromium.org creis@chromium.org clamy@chromium.org nasko@chromium.org dcheng@chromium.org
 Issue 701434  has been merged into this issue.
Cc: nduca@chromium.org a...@chromium.org
 Issue 701435  has been merged into this issue.
Labels: -Pri-3 Pri-2
Owner: kdillon@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbaa821f243a48ddbe53587336e14c00709537ee

commit fbaa821f243a48ddbe53587336e14c00709537ee
Author: kdillon <kdillon@chromium.org>
Date: Wed Jan 02 22:07:57 2019

Restricting exit unload flow.

Currently the limit on end-of-life handlers when the user navigates or
closes a tab is 1s. This change restricts that to 500ms which accomodates
at the 99.9th percentile.

Bug:  832234 
Change-Id: I09c9038dbe184910e44664e6d33b1b530c2645ae
Reviewed-on: https://chromium-review.googlesource.com/c/1384790
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Katie Dillon <kdillon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619510}
[modify] https://crrev.com/fbaa821f243a48ddbe53587336e14c00709537ee/content/browser/renderer_host/render_view_host_impl.cc

Status: Fixed (was: Available)

Sign in to add a comment