Startup task is using objects on UI thread in background thread. |
||
Issue descriptionThe ArchiveManager and Policy Controller are created on UI thread, and it's not safe to call their methods directly on background thread. It should be implemented as copying the information needed and bind in order to use then on a background thread. Check this for all tasks.
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee07658e8d02146594fa9e3fad7b12e6d6c403dc commit ee07658e8d02146594fa9e3fad7b12e6d6c403dc Author: Yafei Duan <romax@chromium.org> Date: Wed Apr 25 21:03:56 2018 [Offline Pages] Fix objects on UI thread being used in background thread As dewittj@ pointed out, in StartupMaintenanceTask some raw pointers to the objects on UI thread are being used in background thread, which is unsafe. This CL fixes the issue by making copy of objects on UI thread and bind them before hopping to background thread. Fortunately other tasks didn't have the wrong implementation. Bug: 832232 Change-Id: Ia8913ba6036b9c2ce357d53857f968fe1629c03d Reviewed-on: https://chromium-review.googlesource.com/1027130 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#553743} [modify] https://crrev.com/ee07658e8d02146594fa9e3fad7b12e6d6c403dc/components/offline_pages/core/model/startup_maintenance_task.cc
,
Apr 25 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by romax@chromium.org
, Apr 25 2018