New issue
Advanced search Search tips

Issue 832230 link

Starred by 1 user
Status: Assigned
Owner:
waff...@chromium.org
Cc:
sorin@chromium.org
mevissen@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Omaha clients should separate updater name and version

Project Member Reported by waff...@chromium.org, Apr 12 2018 
Clients currently send the updater version as a string with both the updater name and version joined together with a "-", with the exception of Omaha which sends no name.

We would like clients to instead send the updater name and version separately, in different attrs. So e.g. the Component updater changes

<request protocol="3.1" version="chrome-64.0.1234.5678" ...>
to
<request protocol="3.1" updater="chrome" updaterversion="64.0.1234.5678" ...>
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bfdf3eca67d8ad5f732a09256786131854061ae

commit 4bfdf3eca67d8ad5f732a09256786131854061ae
Author: Sorin Jianu <sorin@chromium.org>
Date: Mon Apr 23 22:33:19 2018

Separate updater name and version in Component Updater.

Bug: 832230
Change-Id: I31ee1843106eb158e5422a86941832e0f0e45fe7
Reviewed-on: https://chromium-review.googlesource.com/1011598
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552866}
[modify] https://crrev.com/4bfdf3eca67d8ad5f732a09256786131854061ae/components/update_client/protocol_builder.cc
[modify] https://crrev.com/4bfdf3eca67d8ad5f732a09256786131854061ae/components/update_client/protocol_builder_unittest.cc
[modify] https://crrev.com/4bfdf3eca67d8ad5f732a09256786131854061ae/components/update_client/update_checker_unittest.cc
►

Sign in to add a comment