New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 832224 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Don't include the CT Log URL in source

Project Member Reported by rsleevi@chromium.org, Apr 12 2018

Issue description

We track the CT Log URL on the CTLogVerifier and through the known logs list, except this URL is never used, nor is it anticipated that clients would ever directly talk to this log URL.

Save a few bytes and some code complexity by removing it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8b0a837516b6713871b4275d81032132eddea82

commit a8b0a837516b6713871b4275d81032132eddea82
Author: Ryan Sleevi <rsleevi@chromium.org>
Date: Thu Apr 12 22:41:17 2018

Don't track the Certificate Transparency Log URL

The CT Log URL was initially included as part of the log metadata,
as it was anticipated that clients may fetch STHs directly from the
log. However, in further design review, it was realized this would
disproportionately add to log load, and unnecessarily. Instead, STHs
are distributed to clients via the component updater, and it's not
necessary to track the log URL in the client (nor has it ever been
used). Remove it and save a few bytes - and delete dead code.

BUG= 832224 

Change-Id: I61f207b2583774b3d65cd586e58d51f8e50db77a
Reviewed-on: https://chromium-review.googlesource.com/1010519
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550395}
[modify] https://crrev.com/a8b0a837516b6713871b4275d81032132eddea82/components/certificate_transparency/single_tree_tracker_unittest.cc
[modify] https://crrev.com/a8b0a837516b6713871b4275d81032132eddea82/components/certificate_transparency/tree_state_tracker_unittest.cc
[modify] https://crrev.com/a8b0a837516b6713871b4275d81032132eddea82/net/cert/ct_known_logs.cc
[modify] https://crrev.com/a8b0a837516b6713871b4275d81032132eddea82/net/cert/ct_log_verifier.cc
[modify] https://crrev.com/a8b0a837516b6713871b4275d81032132eddea82/net/cert/ct_log_verifier.h
[modify] https://crrev.com/a8b0a837516b6713871b4275d81032132eddea82/net/cert/ct_log_verifier_unittest.cc
[modify] https://crrev.com/a8b0a837516b6713871b4275d81032132eddea82/net/cert/ct_objects_extractor_unittest.cc
[modify] https://crrev.com/a8b0a837516b6713871b4275d81032132eddea82/net/cert/multi_log_ct_verifier_unittest.cc
[modify] https://crrev.com/a8b0a837516b6713871b4275d81032132eddea82/net/quic/chromium/crypto/proof_verifier_chromium_test.cc
[modify] https://crrev.com/a8b0a837516b6713871b4275d81032132eddea82/net/tools/ct_log_list/make_ct_known_logs_list.py
[modify] https://crrev.com/a8b0a837516b6713871b4275d81032132eddea82/net/tools/ct_log_list/make_ct_known_logs_list_unittest.py

Status: Verified (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8b0a837516b6713871b4275d81032132eddea82

commit a8b0a837516b6713871b4275d81032132eddea82
Author: Ryan Sleevi <rsleevi@chromium.org>
Date: Thu Apr 12 22:41:17 2018

Don't track the Certificate Transparency Log URL

The CT Log URL was initially included as part of the log metadata,
as it was anticipated that clients may fetch STHs directly from the
log. However, in further design review, it was realized this would
disproportionately add to log load, and unnecessarily. Instead, STHs
are distributed to clients via the component updater, and it's not
necessary to track the log URL in the client (nor has it ever been
used). Remove it and save a few bytes - and delete dead code.

BUG= 832224 

Change-Id: I61f207b2583774b3d65cd586e58d51f8e50db77a
Reviewed-on: https://chromium-review.googlesource.com/1010519
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550395}
[modify] https://crrev.com/a8b0a837516b6713871b4275d81032132eddea82/components/certificate_transparency/single_tree_tracker_unittest.cc
[modify] https://crrev.com/a8b0a837516b6713871b4275d81032132eddea82/components/certificate_transparency/tree_state_tracker_unittest.cc
[modify] https://crrev.com/a8b0a837516b6713871b4275d81032132eddea82/net/cert/ct_known_logs.cc
[modify] https://crrev.com/a8b0a837516b6713871b4275d81032132eddea82/net/cert/ct_log_verifier.cc
[modify] https://crrev.com/a8b0a837516b6713871b4275d81032132eddea82/net/cert/ct_log_verifier.h
[modify] https://crrev.com/a8b0a837516b6713871b4275d81032132eddea82/net/cert/ct_log_verifier_unittest.cc
[modify] https://crrev.com/a8b0a837516b6713871b4275d81032132eddea82/net/cert/ct_objects_extractor_unittest.cc
[modify] https://crrev.com/a8b0a837516b6713871b4275d81032132eddea82/net/cert/multi_log_ct_verifier_unittest.cc
[modify] https://crrev.com/a8b0a837516b6713871b4275d81032132eddea82/net/quic/chromium/crypto/proof_verifier_chromium_test.cc
[modify] https://crrev.com/a8b0a837516b6713871b4275d81032132eddea82/net/tools/ct_log_list/make_ct_known_logs_list.py
[modify] https://crrev.com/a8b0a837516b6713871b4275d81032132eddea82/net/tools/ct_log_list/make_ct_known_logs_list_unittest.py

Sign in to add a comment