New issue
Advanced search Search tips

Issue 832223 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

Overflow Menu - Missing menu items after closing Incognito tabs

Project Member Reported by dougman@chromium.org, Apr 12 2018

Issue description

Chrome Version: 67.0.3395.0 Canary
OS: Android 8.1.0 on Pixel 2

What steps will reproduce the problem?
(1) Navigate to https://www.google.com
(2) Enter VR Browsing
(3) Click on the Overflow menu - New incognito tab 
(4) Click on the Overflow menu - Close incognito tabs
(5) Click on the Overflow menu

What is the expected result?
The Overflow menu should have the "Close incognito tabs" menu item removed and the menus size reduced by one item.

What happens instead?
The "Close incognito tabs" menu item is gone but the space for it remains.  Giving the appears of a missing menu item.

 
Screenshot_20180413-024155.png
399 KB View Download

Comment 1 by sko...@chromium.org, Apr 13 2018

Labels: -Pri-1 Pri-2
Status: Available (was: Untriaged)
Owner: cjgrant@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Status: Fixed (was: Started)
I believe this issue was due to broken state between the introduction of the tree-walk optimization, and a separate follow-on cleanup change that fixed frame lifecycle and layout issues.

The problem is no longer producible for me on either ToT or Canary 3396.

It would have been fixed at commit position 549911, by:

https://chromium-review.googlesource.com/c/chromium/src/+/1007322

Labels: Test-Complete
Status: Verified (was: Fixed)
Verified that this is fixed in build 67.0.3396.3 Canary.
We have a test case that covers this scenario.

Sign in to add a comment