clean up and enable Wreturn-std-move |
||||
Issue description
clang grew a cool new warning Wreturn-std-move that's part of -Wall.
It looks like so:
../../components/zucchini/equivalence_map_unittest.cc:254:16: error: local variable 'equivalences' will be copied despite being returned by name [-Werror,-Wreturn-std-move]
return equivalences;
^~~~~~~~~~~~
../../components/zucchini/equivalence_map_unittest.cc:254:16: note: call 'std::move' explicitly to avoid copying
return equivalences;
^~~~~~~~~~~~
std::move(equivalences)
We should clean up the codebase and enable it.
,
Apr 16 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d4c2ae362c304bb1c2d76cfe3ec611c4586fc62 commit 4d4c2ae362c304bb1c2d76cfe3ec611c4586fc62 Author: Nico Weber <thakis@chromium.org> Date: Thu Apr 12 21:30:10 2018 Suppress new warning -Wreturn-std-move on clang tot bots. TBR=hans@chromium.org Bug: 832211 Change-Id: I48e93524b532b33430219ccfb9758e940238a43a Reviewed-on: https://chromium-review.googlesource.com/1010533 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#550366} [modify] https://crrev.com/4d4c2ae362c304bb1c2d76cfe3ec611c4586fc62/build/config/compiler/BUILD.gn
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e04c725a492c27cae91ab4c76192273ea5a35f9 commit 6e04c725a492c27cae91ab4c76192273ea5a35f9 Author: Takuto Ikuta <tikuta@chromium.org> Date: Wed Apr 25 11:14:06 2018 Remove -Wno-return-std-move flag Bug: 832211 Change-Id: I9dbfdb0c49aa10f6655454e0d9958f869454f31c Reviewed-on: https://chromium-review.googlesource.com/1025435 Reviewed-by: Greg Thompson <grt@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#553510} [modify] https://crrev.com/6e04c725a492c27cae91ab4c76192273ea5a35f9/build/config/compiler/BUILD.gn [modify] https://crrev.com/6e04c725a492c27cae91ab4c76192273ea5a35f9/components/password_manager/core/browser/password_reuse_detector.cc [modify] https://crrev.com/6e04c725a492c27cae91ab4c76192273ea5a35f9/components/zucchini/equivalence_map_unittest.cc [modify] https://crrev.com/6e04c725a492c27cae91ab4c76192273ea5a35f9/third_party/blink/renderer/core/imagebitmap/image_bitmap.cc
,
Apr 25 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Apr 12 2018