New issue
Advanced search Search tips

Issue 832211 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

clean up and enable Wreturn-std-move

Project Member Reported by thakis@chromium.org, Apr 12 2018

Issue description

clang grew a cool new warning Wreturn-std-move that's part of -Wall.

It looks like so:

../../components/zucchini/equivalence_map_unittest.cc:254:16: error: local variable 'equivalences' will be copied despite being returned by name [-Werror,-Wreturn-std-move]
        return equivalences;
               ^~~~~~~~~~~~
../../components/zucchini/equivalence_map_unittest.cc:254:16: note: call 'std::move' explicitly to avoid copying
        return equivalences;
               ^~~~~~~~~~~~
               std::move(equivalences)


We should clean up the codebase and enable it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d4c2ae362c304bb1c2d76cfe3ec611c4586fc62

commit 4d4c2ae362c304bb1c2d76cfe3ec611c4586fc62
Author: Nico Weber <thakis@chromium.org>
Date: Thu Apr 12 21:30:10 2018

Suppress new warning -Wreturn-std-move on clang tot bots.

TBR=hans@chromium.org

Bug:  832211 
Change-Id: I48e93524b532b33430219ccfb9758e940238a43a
Reviewed-on: https://chromium-review.googlesource.com/1010533
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550366}
[modify] https://crrev.com/4d4c2ae362c304bb1c2d76cfe3ec611c4586fc62/build/config/compiler/BUILD.gn

Comment 2 by pkl@chromium.org, Apr 16 2018

Owner: thakis@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d4c2ae362c304bb1c2d76cfe3ec611c4586fc62

commit 4d4c2ae362c304bb1c2d76cfe3ec611c4586fc62
Author: Nico Weber <thakis@chromium.org>
Date: Thu Apr 12 21:30:10 2018

Suppress new warning -Wreturn-std-move on clang tot bots.

TBR=hans@chromium.org

Bug:  832211 
Change-Id: I48e93524b532b33430219ccfb9758e940238a43a
Reviewed-on: https://chromium-review.googlesource.com/1010533
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550366}
[modify] https://crrev.com/4d4c2ae362c304bb1c2d76cfe3ec611c4586fc62/build/config/compiler/BUILD.gn

Comment 5 by tikuta@chromium.org, Apr 25 2018

Owner: tikuta@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment