Download Manager UI does not show up after app relaunch |
||||||
Issue descriptionApp Version (from "Chrome Settings > About Chrome"): 67.0.3395.0 iOS Version: 11.3 Device: iPhone SE Steps to reproduce: 1.) Load https://www.barebones.com/products/bbedit/download.html 2.) Tap Download 3.) Quit the app 4.) Open the app 5.) Tap Download Observed behavior: Download Manager UI does not show up Expected behavior: Download Manager UI has to show up
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/464ebff95463a4d94cb1137b102d8eb0411ed14c commit 464ebff95463a4d94cb1137b102d8eb0411ed14c Author: Eugene But <eugenebut@google.com> Date: Fri Apr 13 19:58:03 2018 Ensure that DownloadManagerTabHelper has a delegate. DownloadManagerTabHelper does not work without delegate, so make sure that DownloadManagerCoordinator is created before DownloadManagerTabHelper. Previously DownloadManagerCoordinator was created in viewDidLoad which is called after all Tab Helpers are attached to the restored tabs. Bug: 832210 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id5bcbec42b0723007aef4d8a25a065cb30238484 Reviewed-on: https://chromium-review.googlesource.com/1011182 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#550731} [modify] https://crrev.com/464ebff95463a4d94cb1137b102d8eb0411ed14c/ios/chrome/browser/ui/browser_view_controller.mm
,
Apr 13 2018
,
Apr 14 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6cd0f55a3cfb218db493e463a58a04a462e4fd5 commit b6cd0f55a3cfb218db493e463a58a04a462e4fd5 Author: Eugene But <eugenebut@google.com> Date: Mon Apr 16 22:05:41 2018 Ensure that DownloadManagerTabHelper has a delegate. DownloadManagerTabHelper does not work without delegate, so make sure that DownloadManagerCoordinator is created before DownloadManagerTabHelper. Previously DownloadManagerCoordinator was created in viewDidLoad which is called after all Tab Helpers are attached to the restored tabs. TBR=eugenebut@google.com (cherry picked from commit 464ebff95463a4d94cb1137b102d8eb0411ed14c) Bug: 832210 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id5bcbec42b0723007aef4d8a25a065cb30238484 Reviewed-on: https://chromium-review.googlesource.com/1011182 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550731} Reviewed-on: https://chromium-review.googlesource.com/1014476 Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#27} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/b6cd0f55a3cfb218db493e463a58a04a462e4fd5/ios/chrome/browser/ui/browser_view_controller.mm
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/464ebff95463a4d94cb1137b102d8eb0411ed14c commit 464ebff95463a4d94cb1137b102d8eb0411ed14c Author: Eugene But <eugenebut@google.com> Date: Fri Apr 13 19:58:03 2018 Ensure that DownloadManagerTabHelper has a delegate. DownloadManagerTabHelper does not work without delegate, so make sure that DownloadManagerCoordinator is created before DownloadManagerTabHelper. Previously DownloadManagerCoordinator was created in viewDidLoad which is called after all Tab Helpers are attached to the restored tabs. Bug: 832210 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id5bcbec42b0723007aef4d8a25a065cb30238484 Reviewed-on: https://chromium-review.googlesource.com/1011182 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#550731} [modify] https://crrev.com/464ebff95463a4d94cb1137b102d8eb0411ed14c/ios/chrome/browser/ui/browser_view_controller.mm
,
Apr 17 2018
Issue verified Version: Chrome Canary 68.0.3398.0 Device: iPhone SE iOS: 11.3 Download Manager UI shows up https://drive.google.com/open?id=1pI4IS0N7F9d7dZzOSQONdIoRGd0ICQC8
,
Apr 25 2018
Verified on 67.0.3396.17 Beta on iPhone X(iOS 4Beta2), iPhone SE(iOS 11.4), iPhone 8plus(iOS 11.2.6) and iPhone 7plus(iOS 10.3.3) Download Manager UI shows up after app launch |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by eugene...@chromium.org
, Apr 12 2018