New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 832205 link

Starred by 1 user
Status: Verified
Owner:
ntfschr@chromium.org
Closed: Apr 2018
Cc:
█ gsennton@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 781764



Sign in to add a comment

Feature flags for webresourceerror and safebrowsingresponse

Project Member Reported by ntfschr@chromium.org, Apr 12 2018 
These classes are implemented, but we should add feature flags for the methods on WebResourceErrorCompat and SafeBrowsingResponseCompat.

This tracks the chromium work, which is to declare the APK supports these features being called.

I'll file a buganizer issue to track Support-lib side changes.

Comment 1 by ntfschr@chromium.org, Apr 12 2018 

Buganizer issue: http://b/77967793
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0da5a0c829eb7faf5aad202d8a67a3be9d52d155

commit 0da5a0c829eb7faf5aad202d8a67a3be9d52d155
Author: Nate Fischer <ntfschr@chromium.org>
Date: Thu Apr 12 19:27:49 2018

AW: add feature flags for methods on callback-related classes

This adds feature flags for WebResourceError and SafeBrowsingResponse
methods (objects which are passed back in WebViewClient callbacks).

Support for these methods landed a while ago, so this CL declares the
features are implemented.

Bug:  832205 
Test: N/A
Change-Id: I73665515915cc9305636f09b72fbad8d6a9313ca
Reviewed-on: https://chromium-review.googlesource.com/1010717
Reviewed-by: Gustav Sennton <gsennton@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550305}
[modify] https://crrev.com/0da5a0c829eb7faf5aad202d8a67a3be9d52d155/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/util/Features.java
[modify] https://crrev.com/0da5a0c829eb7faf5aad202d8a67a3be9d52d155/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebViewChromiumFactory.java

Comment 3 by ntfschr@chromium.org, Apr 12 2018

Status: Fixed (was: Started)
No verification necessary.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0da5a0c829eb7faf5aad202d8a67a3be9d52d155

commit 0da5a0c829eb7faf5aad202d8a67a3be9d52d155
Author: Nate Fischer <ntfschr@chromium.org>
Date: Thu Apr 12 19:27:49 2018

AW: add feature flags for methods on callback-related classes

This adds feature flags for WebResourceError and SafeBrowsingResponse
methods (objects which are passed back in WebViewClient callbacks).

Support for these methods landed a while ago, so this CL declares the
features are implemented.

Bug:  832205 
Test: N/A
Change-Id: I73665515915cc9305636f09b72fbad8d6a9313ca
Reviewed-on: https://chromium-review.googlesource.com/1010717
Reviewed-by: Gustav Sennton <gsennton@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550305}
[modify] https://crrev.com/0da5a0c829eb7faf5aad202d8a67a3be9d52d155/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/util/Features.java
[modify] https://crrev.com/0da5a0c829eb7faf5aad202d8a67a3be9d52d155/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebViewChromiumFactory.java

Comment 5 by sbash...@chromium.org, Apr 24 2018 

Please add the manual verification steps to verify the changes and we can track these Changes . Thanks

Comment 6 by ntfschr@chromium.org, Apr 24 2018 

No verification necessary.

Comment 7 by ntfschr@chromium.org, Aug 24

Status: Verified (was: Fixed)
Bulk edit: marking stale 'fixed' bugs as 'verified' since they don't need verification at this point.
►

Sign in to add a comment