"KeyboardOperations/FileManagerBrowserTest.Test/7" is flaky/broken |
||||||||||
Issue description"KeyboardOperations/FileManagerBrowserTest.Test/7" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 5 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOwsSBUZsYWtlIjBLZXlib2FyZE9wZXJhdGlvbnMvRmlsZU1hbmFnZXJCcm93c2VyVGVzdC5UZXN0LzcM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Apr 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d44feced6426dccb54f29c10a5370f9a510f4d1 commit 7d44feced6426dccb54f29c10a5370f9a510f4d1 Author: Kevin Marshall <kmarshall@chromium.org> Date: Thu Apr 12 22:47:49 2018 Disable FileManagerBrowserTest KeyboardOperations/7 due to flakiness. See the bug for more details. TBR=fukino@chromium.org Bug: 832192 Change-Id: I24052278924c70b2fb4de9b55777c393724022d3 Reviewed-on: https://chromium-review.googlesource.com/1011230 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#550399} [modify] https://crrev.com/7d44feced6426dccb54f29c10a5370f9a510f4d1/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
Apr 12 2018
+kmarshall@ is the current goal to disable all the FileManagerBrowserTests? I figure it would be helpful to fukino-san@ if you could save a build log showing this test failing to this bug.
,
Apr 12 2018
crbug.com 829310#c14 Our colleagues here are so very polite, and won't complain, but when speaking to them and others about their, I sensed they would be unhappy if I disabled all their tests :)
,
Apr 13 2018
Detected 3 new flakes for test/step "KeyboardOperations/FileManagerBrowserTest.Test/7". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOwsSBUZsYWtlIjBLZXlib2FyZE9wZXJhdGlvbnMvRmlsZU1hbmFnZXJCcm93c2VyVGVzdC5UZXN0LzcM. This message was posted automatically by the chromium-try-flakes app.
,
Apr 14 2018
Despite the test being disabled in #2 above, I just saw this flake here: KeyboardOperations/FileManagerBrowserTest.Test/7 https://ci.chromium.org/buildbot/tryserver.chromium.chromiumos/linux-chromeos-rel/102085 It looks like the tests may have gotten renumbered when you disabled that test, which means the one that's failing now is probably: TestParameter(NOT_IN_GUEST_MODE, "renameFileDrive"), So perhaps the previous test (test /6) TestParameter(IN_GUEST_MODE, "renameFileDownloads") is causing whatever test follows it to flake?
,
Apr 17 2018
Disabling: https://chromium-review.googlesource.com/c/chromium/src/+/1015003
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02dcc3909d88d832e67d10b588867124610115a3 commit 02dcc3909d88d832e67d10b588867124610115a3 Author: Rune Lillesveen <futhark@chromium.org> Date: Tue Apr 17 14:48:15 2018 Disable flaky tests in file_manager_browsertest.cc TBR=fukino@chromium.org Bug: 833049 , 832192 , 833752 , 832799 , 832798 Change-Id: I7d3316f2deae4f0e415e41a95211ee1f105cdf32 Reviewed-on: https://chromium-review.googlesource.com/1015003 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#551331} [modify] https://crrev.com/02dcc3909d88d832e67d10b588867124610115a3/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
Apr 17 2018
Maybe they flaked 4 days ago, but these tests are not flaking anymore [1] after crrev.com/551279 https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=KeyboardOperations%2FFileManagerBrowserTest.Test
,
Apr 17 2018
So I should just revert it?
,
Apr 17 2018
KeyboardOperations/FileManagerBrowserTest.Test/7 is not flaking according to the current flakiness dashboard. We could revert yes, but that might not be so simple given that multiple tests we disabled in one patch, and you have other gardening todos I expect. We'll take the bug and clean up. About the only expected way the FileManagerBrowser could flake at this time, is due to issue 829306 mind.
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d44feced6426dccb54f29c10a5370f9a510f4d1 commit 7d44feced6426dccb54f29c10a5370f9a510f4d1 Author: Kevin Marshall <kmarshall@chromium.org> Date: Thu Apr 12 22:47:49 2018 Disable FileManagerBrowserTest KeyboardOperations/7 due to flakiness. See the bug for more details. TBR=fukino@chromium.org Bug: 832192 Change-Id: I24052278924c70b2fb4de9b55777c393724022d3 Reviewed-on: https://chromium-review.googlesource.com/1011230 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#550399} [modify] https://crrev.com/7d44feced6426dccb54f29c10a5370f9a510f4d1/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
Apr 18 2018
$6 > It looks like the tests may have gotten renumbered when you disabled that test, which means the one that's failing now is probably [sic] "something else". Yes exactly. These test disables cause these tests to be re-numbered and that causes some confusion in this bug: "which test was disabled, exactly?" Anyhow, the fix has landed in issue 831074 is is working its way through our bots. The KeyboardOperations test group can be re-enabled. But can't just do a clean revert of #8 because it had multi-bug. So, I'm gonna back out all KeyboardOperations disables by hand.
,
Apr 18 2018
,
Apr 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b3aa2169ee994aa26072f91fd1c68c515477f51 commit 3b3aa2169ee994aa26072f91fd1c68c515477f51 Author: Noel Gordon <noel@chromium.org> Date: Wed Apr 18 04:17:22 2018 Re-enable some KeyboardOperations FileManagerBrowserTests Bug: 832192 Change-Id: Id3c33aebbd262c6b78f464cde1d201024309cf0e Reviewed-on: https://chromium-review.googlesource.com/1015143 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#551578} [modify] https://crrev.com/3b3aa2169ee994aa26072f91fd1c68c515477f51/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
Apr 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42a55ac19ff0abf3ec3abc074e55a341a6cc17ee commit 42a55ac19ff0abf3ec3abc074e55a341a6cc17ee Author: Noel Gordon <noel@chromium.org> Date: Wed Apr 18 07:15:37 2018 Re-enable KeyboardOperations "keyboardDeleteDrive" browser test Bug: 832192 , 833049 Change-Id: I9e4816bbe1fe071a55791d706017ea5efa4e87fa Reviewed-on: https://chromium-review.googlesource.com/1015337 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#551603} [modify] https://crrev.com/42a55ac19ff0abf3ec3abc074e55a341a6cc17ee/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
Apr 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e0cdfd2ebfe83025e4bb9b0d19a998f3bd74a6f commit 5e0cdfd2ebfe83025e4bb9b0d19a998f3bd74a6f Author: Noel Gordon <noel@chromium.org> Date: Wed Apr 18 11:20:52 2018 Re-enable KeyboardOperations "renameNewDirectoryDrive" browser test Tbr: yamaguchi-san Bug: 832192 , 833752 Change-Id: I71207ce1d98d86c896a6fac91d29cf8e85fe4a43 Reviewed-on: https://chromium-review.googlesource.com/1016480 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#551634} [modify] https://crrev.com/5e0cdfd2ebfe83025e4bb9b0d19a998f3bd74a6f/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
Apr 18 2018
,
Apr 18 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by kmarshall@chromium.org
, Apr 12 2018Status: Assigned (was: Untriaged)
Summary: "KeyboardOperations/FileManagerBrowserTest.Test/7" is flaky/broken (was: "KeyboardOperations/FileManagerBrowserTest.Test/7" is flaky)